All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Bulekov <alxndr@bu.edu>
Cc: darren.kenny@oracle.com, bsd@redhat.com, philmd@redhat.com,
	qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [PATCH v3 05/16] fuzz: Declare DMA Read callback function
Date: Mon, 12 Oct 2020 08:59:43 +0200	[thread overview]
Message-ID: <2bc8a9b9-49c1-58cb-4696-fd83f7e3257f@redhat.com> (raw)
In-Reply-To: <20201011154524.wvq2vsff7eig27c4@mozz.bu.edu>

On 11/10/20 17:45, Alexander Bulekov wrote:
> On 201008 0939, Paolo Bonzini wrote:
>> On 21/09/20 04:24, Alexander Bulekov wrote:
>>> This patch declares the fuzz_dma_read_cb function and uses the
>>> preprocessor and linker(weak symbols) to handle these cases:
>>>
>>> When we build softmmu/all with --enable-fuzzing, there should be no
>>> strong symbol defined for fuzz_dma_read_cb, and we link against a weak
>>> stub function.
>>>
>>> When we build softmmu/fuzz with --enable-fuzzing, we link against the
>>> strong symbol in general_fuzz.c
>>>
>>> When we build softmmu/all without --enable-fuzzing, fuzz_dma_read_cb is
>>> an empty, inlined function. As long as we don't call any other functions
>>> when building the arguments, there should be no overhead.
>>
>> Can you move the weak function somewhere in tests/qtest/fuzz instead?
>> Then you don't need an #ifdef because you can add it to specific_fuzz_ss.
> 
> If I understand correctly, specific_fuzz_ss is only used to build
> qemu-fuzz targets. The goal here was to support building qemu-system
> with --enable-fuzzing (ie CONFIG_FUZZ=y), where specific_fuzz isn't
> used. If its too ugly, we could make a stub file under tests/qtest/fuzz
> and add it to specific_ss when: 'CONFIG_FUZZ'.

You're right.

Paolo



  reply	other threads:[~2020-10-12  7:03 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-21  2:24 [PATCH v3 00/16] Add a General Virtual Device Fuzzer Alexander Bulekov
2020-09-21  2:24 ` [PATCH v3 01/16] memory: Add FlatView foreach function Alexander Bulekov
2020-10-08  6:57   ` Paolo Bonzini
2020-09-21  2:24 ` [PATCH v3 02/16] fuzz: Add general virtual-device fuzzer Alexander Bulekov
2020-09-21  5:43   ` Philippe Mathieu-Daudé
2020-09-21 14:34     ` Alexander Bulekov
2020-10-01 15:29       ` Darren Kenny
2020-10-07 13:39         ` Alexander Bulekov
2020-10-07 13:53           ` Darren Kenny
2020-10-08  7:03       ` Paolo Bonzini
2020-10-11 15:35         ` Alexander Bulekov
2020-10-12  7:02           ` Paolo Bonzini
2020-09-22 14:03   ` Alexander Bulekov
2020-10-08  7:04     ` Paolo Bonzini
2020-09-21  2:24 ` [PATCH v3 03/16] fuzz: Add PCI features to the general fuzzer Alexander Bulekov
2020-09-21  5:44   ` Philippe Mathieu-Daudé
2020-09-21 14:41     ` Alexander Bulekov
2020-09-21  2:24 ` [PATCH v3 04/16] fuzz: Add DMA support to the generic-fuzzer Alexander Bulekov
2020-10-08  7:43   ` Paolo Bonzini
2020-10-08 13:26     ` Alexander Bulekov
2020-09-21  2:24 ` [PATCH v3 05/16] fuzz: Declare DMA Read callback function Alexander Bulekov
2020-10-08  7:39   ` Paolo Bonzini
2020-10-11 15:45     ` Alexander Bulekov
2020-10-12  6:59       ` Paolo Bonzini [this message]
2020-09-21  2:24 ` [PATCH v3 06/16] fuzz: Add fuzzer callbacks to DMA-read functions Alexander Bulekov
2020-09-21  2:24 ` [PATCH v3 07/16] fuzz: Add support for custom crossover functions Alexander Bulekov
2020-09-21  2:24 ` [PATCH v3 08/16] fuzz: add a DISABLE_PCI op to general-fuzzer Alexander Bulekov
2020-09-21  2:24 ` [PATCH v3 09/16] fuzz: add a crossover function to generic-fuzzer Alexander Bulekov
2020-10-01 15:31   ` Darren Kenny
2020-10-15 13:43     ` Alexander Bulekov
2020-09-21  2:25 ` [PATCH v3 10/16] scripts/oss-fuzz: Add wrapper program for generic fuzzer Alexander Bulekov
2020-09-21  2:25 ` [PATCH v3 11/16] scripts/oss-fuzz: Add general-fuzzer build script Alexander Bulekov
2020-10-01 15:40   ` Darren Kenny
2020-10-08  7:35   ` Paolo Bonzini
2020-10-15 13:46     ` Alexander Bulekov
2020-09-21  2:25 ` [PATCH v3 12/16] scripts/oss-fuzz: Add general-fuzzer configs for oss-fuzz Alexander Bulekov
2020-09-21  2:25 ` [PATCH v3 13/16] scripts/oss-fuzz: build the general-fuzzer configs Alexander Bulekov
2020-09-21  2:25 ` [PATCH v3 14/16] scripts/oss-fuzz: Add script to reorder a general-fuzzer trace Alexander Bulekov
2020-10-08  7:42   ` Paolo Bonzini
2020-09-21  2:25 ` [PATCH v3 15/16] scripts/oss-fuzz: Add crash trace minimization script Alexander Bulekov
2020-09-21  2:25 ` [PATCH v3 16/16] fuzz: Add instructions for using general-fuzz Alexander Bulekov
2020-10-01 15:44   ` Darren Kenny
2020-09-21  2:45 ` [PATCH v3 00/16] Add a General Virtual Device Fuzzer no-reply
2020-09-21  2:58 ` no-reply
2020-09-21  3:30 ` no-reply
2020-09-21  3:43 ` no-reply
2020-09-21  3:46 ` no-reply
2020-09-21  4:30 ` no-reply
2020-09-21  4:39 ` no-reply
2020-09-21  5:22 ` no-reply
2020-09-21  5:31 ` no-reply
2020-09-21  6:17 ` no-reply
2020-09-21  6:26 ` no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bc8a9b9-49c1-58cb-4696-fd83f7e3257f@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alxndr@bu.edu \
    --cc=bsd@redhat.com \
    --cc=darren.kenny@oracle.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.