From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB501C433DB for ; Wed, 20 Jan 2021 05:27:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 733202313A for ; Wed, 20 Jan 2021 05:27:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729245AbhATFVV (ORCPT ); Wed, 20 Jan 2021 00:21:21 -0500 Received: from new1-smtp.messagingengine.com ([66.111.4.221]:36989 "EHLO new1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730129AbhATFRt (ORCPT ); Wed, 20 Jan 2021 00:17:49 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id CE60D580661; Wed, 20 Jan 2021 00:16:38 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Wed, 20 Jan 2021 00:16:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=PcJyYtudzRQd2L7XJQWnv/OgA9ryKAZ hSUK7NWDCh0I=; b=cWi81OjsDif1cVZ7S8+BWWAVbWdcEHBCqCrm9Xp+QUm6HOq sfiFSIX8cm0VccSlAfNmDYFq+Szus38GXIkPPpw23Nj9hxwDfjX98BnJvPbQUQ76 /HQharncbffM3e8xIs59cu1iy407oekr3Z/5VqI+TyqgQKn27vgJVdwA5+orKIx9 63RIplLN9PRFm9RlgL0X3y5frdNsV3SzTrRYl/NR+VO4onc2q0HPL8MlV1Dp9zhU 18UU83GNxqDLq+YN1wv7pUJ/JhitHEwEqKCgTs3WS2mGOvpcKXr2mN6nJNOh2pB8 UX2ikxtDNf/1I1ypA21Jzlt2Y0F9mkQyAebYtOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=PcJyYt udzRQd2L7XJQWnv/OgA9ryKAZhSUK7NWDCh0I=; b=K1fxRdrnOOc61H9m8BCmDb GG3R7CjsKc28FwokFYFG3UkxrEIfWUGnZSkw1mXsYHGvUtlgfnUjbY+QMm++G1rC az5n9Kd0RR4Hp7VaM1RQzlAU/tGau0jIecWKjb2JHnbxXXFv6evAucXF6BwdzvhX 4sD8uaJRIJokqY65oDA3H0Td8osqBguuo8oUOlFfhTQecrJW//3fEEJ28mGfiHF/ 8v9SkxPfaXxPpzDg4WBTonp/+uULDSgPcUEtyeMzqXdH8yELYAgNLFMsJX/GvGpE UAC2NN9KQjR2wfzHQihT+3vCqCfPQZNyAsfEtXN9wTmkHS9Ws6Zfrj5rVO1og+sQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddugdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtffrrg htthgvrhhnpeehhfefkefgkeduveehffehieehudejfeejveejfedugfefuedtuedvhefh veeuffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id A9351A0005D; Wed, 20 Jan 2021 00:16:37 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-78-g36b56e88ef-fm-20210120.001-g36b56e88 Mime-Version: 1.0 Message-Id: <2bf67d3a-cd5f-4f9c-b043-709b18a759d5@www.fastmail.com> In-Reply-To: <20210118065059.2478078-5-troy_lee@aspeedtech.com> References: <20210118065059.2478078-1-troy_lee@aspeedtech.com> <20210118065059.2478078-5-troy_lee@aspeedtech.com> Date: Wed, 20 Jan 2021 15:46:17 +1030 From: "Andrew Jeffery" To: "Troy Lee" , openbmc@lists.ozlabs.org, "Joel Stanley" , "Philipp Zabel" , "open list" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" Cc: "Ryan Chen" , "Chia-Wei, Wang" , "Troy Lee" , "kbuild test robot" Subject: Re: [PATCH v3 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Troy, On Mon, 18 Jan 2021, at 17:20, Troy Lee wrote: > Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and > 16 FAN tacho channel. > > Changes since v2: > - declare local function as static function > > Changes since v1: > - fixed review comments > - fixed double-looped calculation of div_h and div_l > - moving configuration to device tree > - register hwmon driver with devm_hwmon_device_register_with_info() > > Signed-off-by: Troy Lee > Reported-by: kernel test robot > --- > drivers/hwmon/Kconfig | 10 + > drivers/hwmon/Makefile | 1 + > drivers/hwmon/aspeed2600-pwm-tacho.c | 756 +++++++++++++++++++++++++++ > 3 files changed, 767 insertions(+) > create mode 100644 drivers/hwmon/aspeed2600-pwm-tacho.c ... > diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile > index 09a86c5e1d29..1a415d493ffc 100644 > --- a/drivers/hwmon/Makefile > +++ b/drivers/hwmon/Makefile > @@ -52,6 +52,7 @@ obj-$(CONFIG_SENSORS_ARM_SCPI) += scpi-hwmon.o > obj-$(CONFIG_SENSORS_AS370) += as370-hwmon.o > obj-$(CONFIG_SENSORS_ASC7621) += asc7621.o > obj-$(CONFIG_SENSORS_ASPEED) += aspeed-pwm-tacho.o > +obj-$(CONFIG_SENSORS_ASPEED2600_PWM_TACHO) += aspeed2600-pwm-tacho.o Why does this have to be a separate implementation from the existing ASPEED PWM/Tacho driver? Is there really nothing in common? Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56EF2C433DB for ; Wed, 20 Jan 2021 05:18:17 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C75DE2311C for ; Wed, 20 Jan 2021 05:18:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C75DE2311C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DLDLv124pzDqq8 for ; Wed, 20 Jan 2021 16:18:15 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=aj.id.au (client-ip=66.111.4.221; helo=new1-smtp.messagingengine.com; envelope-from=andrew@aj.id.au; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=aj.id.au header.i=@aj.id.au header.a=rsa-sha256 header.s=fm1 header.b=cWi81Ojs; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=K1fxRdrn; dkim-atps=neutral Received: from new1-smtp.messagingengine.com (new1-smtp.messagingengine.com [66.111.4.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DLDK53rBrzDqDN; Wed, 20 Jan 2021 16:16:41 +1100 (AEDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id CE60D580661; Wed, 20 Jan 2021 00:16:38 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Wed, 20 Jan 2021 00:16:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=PcJyYtudzRQd2L7XJQWnv/OgA9ryKAZ hSUK7NWDCh0I=; b=cWi81OjsDif1cVZ7S8+BWWAVbWdcEHBCqCrm9Xp+QUm6HOq sfiFSIX8cm0VccSlAfNmDYFq+Szus38GXIkPPpw23Nj9hxwDfjX98BnJvPbQUQ76 /HQharncbffM3e8xIs59cu1iy407oekr3Z/5VqI+TyqgQKn27vgJVdwA5+orKIx9 63RIplLN9PRFm9RlgL0X3y5frdNsV3SzTrRYl/NR+VO4onc2q0HPL8MlV1Dp9zhU 18UU83GNxqDLq+YN1wv7pUJ/JhitHEwEqKCgTs3WS2mGOvpcKXr2mN6nJNOh2pB8 UX2ikxtDNf/1I1ypA21Jzlt2Y0F9mkQyAebYtOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=PcJyYt udzRQd2L7XJQWnv/OgA9ryKAZhSUK7NWDCh0I=; b=K1fxRdrnOOc61H9m8BCmDb GG3R7CjsKc28FwokFYFG3UkxrEIfWUGnZSkw1mXsYHGvUtlgfnUjbY+QMm++G1rC az5n9Kd0RR4Hp7VaM1RQzlAU/tGau0jIecWKjb2JHnbxXXFv6evAucXF6BwdzvhX 4sD8uaJRIJokqY65oDA3H0Td8osqBguuo8oUOlFfhTQecrJW//3fEEJ28mGfiHF/ 8v9SkxPfaXxPpzDg4WBTonp/+uULDSgPcUEtyeMzqXdH8yELYAgNLFMsJX/GvGpE UAC2NN9KQjR2wfzHQihT+3vCqCfPQZNyAsfEtXN9wTmkHS9Ws6Zfrj5rVO1og+sQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddugdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtffrrg htthgvrhhnpeehhfefkefgkeduveehffehieehudejfeejveejfedugfefuedtuedvhefh veeuffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id A9351A0005D; Wed, 20 Jan 2021 00:16:37 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-78-g36b56e88ef-fm-20210120.001-g36b56e88 Mime-Version: 1.0 Message-Id: <2bf67d3a-cd5f-4f9c-b043-709b18a759d5@www.fastmail.com> In-Reply-To: <20210118065059.2478078-5-troy_lee@aspeedtech.com> References: <20210118065059.2478078-1-troy_lee@aspeedtech.com> <20210118065059.2478078-5-troy_lee@aspeedtech.com> Date: Wed, 20 Jan 2021 15:46:17 +1030 From: "Andrew Jeffery" To: "Troy Lee" , openbmc@lists.ozlabs.org, "Joel Stanley" , "Philipp Zabel" , "open list" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" Subject: Re: [PATCH v3 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer Content-Type: text/plain X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Chia-Wei, Wang" , Ryan Chen , Troy Lee , kbuild test robot Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hi Troy, On Mon, 18 Jan 2021, at 17:20, Troy Lee wrote: > Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and > 16 FAN tacho channel. > > Changes since v2: > - declare local function as static function > > Changes since v1: > - fixed review comments > - fixed double-looped calculation of div_h and div_l > - moving configuration to device tree > - register hwmon driver with devm_hwmon_device_register_with_info() > > Signed-off-by: Troy Lee > Reported-by: kernel test robot > --- > drivers/hwmon/Kconfig | 10 + > drivers/hwmon/Makefile | 1 + > drivers/hwmon/aspeed2600-pwm-tacho.c | 756 +++++++++++++++++++++++++++ > 3 files changed, 767 insertions(+) > create mode 100644 drivers/hwmon/aspeed2600-pwm-tacho.c ... > diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile > index 09a86c5e1d29..1a415d493ffc 100644 > --- a/drivers/hwmon/Makefile > +++ b/drivers/hwmon/Makefile > @@ -52,6 +52,7 @@ obj-$(CONFIG_SENSORS_ARM_SCPI) += scpi-hwmon.o > obj-$(CONFIG_SENSORS_AS370) += as370-hwmon.o > obj-$(CONFIG_SENSORS_ASC7621) += asc7621.o > obj-$(CONFIG_SENSORS_ASPEED) += aspeed-pwm-tacho.o > +obj-$(CONFIG_SENSORS_ASPEED2600_PWM_TACHO) += aspeed2600-pwm-tacho.o Why does this have to be a separate implementation from the existing ASPEED PWM/Tacho driver? Is there really nothing in common? Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B62AC433E0 for ; Wed, 20 Jan 2021 05:18:28 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DDE3A2311C for ; Wed, 20 Jan 2021 05:18:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DDE3A2311C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aj.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:To:From:Date:References:In-Reply-To: Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GAVvRW9Q+k5WnxH8D03xw3gYoCsArcadbXyJDnb2Cp0=; b=uIrX6xODRly9DdwzABXeTLQSz W6SWUE+NLsnExg9NjWIRGsCgClTgwUG3RAlk/ybsuMptFSl0SP5lfYERwK4aXowoQquA6dLzxRLuS YutICHa9eBjd3onGzo51JBZoDz3zmH9l22BE+T8uQ8AP1Q0VM298vjH0SmpsfVTAJtU5xkLB7FmHb hgFhNWPVqUTi/Rgycl2Ng2ggj1DW2NwUFz+TpFZt4lpU6OhF+giuLzxwJx8GH4mucf7XaQrOw43ej 6ZHU7E82+4/JBVBOea2B/VbE4JwJFq6xolKwqVlaDMWm3vyUMafaw2Ny2EWteZO7HqgXCXVLDVLax Fu6gHIM+Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l25rG-00047A-5r; Wed, 20 Jan 2021 05:16:42 +0000 Received: from new1-smtp.messagingengine.com ([66.111.4.221]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l25rE-00046j-39 for linux-arm-kernel@lists.infradead.org; Wed, 20 Jan 2021 05:16:40 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id CE60D580661; Wed, 20 Jan 2021 00:16:38 -0500 (EST) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Wed, 20 Jan 2021 00:16:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=PcJyYtudzRQd2L7XJQWnv/OgA9ryKAZ hSUK7NWDCh0I=; b=cWi81OjsDif1cVZ7S8+BWWAVbWdcEHBCqCrm9Xp+QUm6HOq sfiFSIX8cm0VccSlAfNmDYFq+Szus38GXIkPPpw23Nj9hxwDfjX98BnJvPbQUQ76 /HQharncbffM3e8xIs59cu1iy407oekr3Z/5VqI+TyqgQKn27vgJVdwA5+orKIx9 63RIplLN9PRFm9RlgL0X3y5frdNsV3SzTrRYl/NR+VO4onc2q0HPL8MlV1Dp9zhU 18UU83GNxqDLq+YN1wv7pUJ/JhitHEwEqKCgTs3WS2mGOvpcKXr2mN6nJNOh2pB8 UX2ikxtDNf/1I1ypA21Jzlt2Y0F9mkQyAebYtOg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=PcJyYt udzRQd2L7XJQWnv/OgA9ryKAZhSUK7NWDCh0I=; b=K1fxRdrnOOc61H9m8BCmDb GG3R7CjsKc28FwokFYFG3UkxrEIfWUGnZSkw1mXsYHGvUtlgfnUjbY+QMm++G1rC az5n9Kd0RR4Hp7VaM1RQzlAU/tGau0jIecWKjb2JHnbxXXFv6evAucXF6BwdzvhX 4sD8uaJRIJokqY65oDA3H0Td8osqBguuo8oUOlFfhTQecrJW//3fEEJ28mGfiHF/ 8v9SkxPfaXxPpzDg4WBTonp/+uULDSgPcUEtyeMzqXdH8yELYAgNLFMsJX/GvGpE UAC2NN9KQjR2wfzHQihT+3vCqCfPQZNyAsfEtXN9wTmkHS9Ws6Zfrj5rVO1og+sQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddugdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderredtnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucggtffrrg htthgvrhhnpeehhfefkefgkeduveehffehieehudejfeejveejfedugfefuedtuedvhefh veeuffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe grnhgurhgvfiesrghjrdhiugdrrghu X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id A9351A0005D; Wed, 20 Jan 2021 00:16:37 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-78-g36b56e88ef-fm-20210120.001-g36b56e88 Mime-Version: 1.0 Message-Id: <2bf67d3a-cd5f-4f9c-b043-709b18a759d5@www.fastmail.com> In-Reply-To: <20210118065059.2478078-5-troy_lee@aspeedtech.com> References: <20210118065059.2478078-1-troy_lee@aspeedtech.com> <20210118065059.2478078-5-troy_lee@aspeedtech.com> Date: Wed, 20 Jan 2021 15:46:17 +1030 From: "Andrew Jeffery" To: "Troy Lee" , openbmc@lists.ozlabs.org, "Joel Stanley" , "Philipp Zabel" , "open list" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" Subject: Re: [PATCH v3 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210120_001640_175972_7D145103 X-CRM114-Status: GOOD ( 13.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Chia-Wei, Wang" , Ryan Chen , Troy Lee , kbuild test robot Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Troy, On Mon, 18 Jan 2021, at 17:20, Troy Lee wrote: > Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and > 16 FAN tacho channel. > > Changes since v2: > - declare local function as static function > > Changes since v1: > - fixed review comments > - fixed double-looped calculation of div_h and div_l > - moving configuration to device tree > - register hwmon driver with devm_hwmon_device_register_with_info() > > Signed-off-by: Troy Lee > Reported-by: kernel test robot > --- > drivers/hwmon/Kconfig | 10 + > drivers/hwmon/Makefile | 1 + > drivers/hwmon/aspeed2600-pwm-tacho.c | 756 +++++++++++++++++++++++++++ > 3 files changed, 767 insertions(+) > create mode 100644 drivers/hwmon/aspeed2600-pwm-tacho.c ... > diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile > index 09a86c5e1d29..1a415d493ffc 100644 > --- a/drivers/hwmon/Makefile > +++ b/drivers/hwmon/Makefile > @@ -52,6 +52,7 @@ obj-$(CONFIG_SENSORS_ARM_SCPI) += scpi-hwmon.o > obj-$(CONFIG_SENSORS_AS370) += as370-hwmon.o > obj-$(CONFIG_SENSORS_ASC7621) += asc7621.o > obj-$(CONFIG_SENSORS_ASPEED) += aspeed-pwm-tacho.o > +obj-$(CONFIG_SENSORS_ASPEED2600_PWM_TACHO) += aspeed2600-pwm-tacho.o Why does this have to be a separate implementation from the existing ASPEED PWM/Tacho driver? Is there really nothing in common? Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel