From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH V1 1/2] leds: leds-qti-rgb: Add LED driver for QTI TRI_LED module Date: Thu, 1 Jun 2017 21:31:40 +0200 Message-ID: <2c01fa38-b711-56af-5458-e726540d37ea@gmail.com> References: <20170531061541.10808-1-fenglinw@codeaurora.org> <20170531061541.10808-2-fenglinw@codeaurora.org> <20170531075536.GA13028@amd> <001301d2d9e7$3102b720$93082560$@codeaurora.org> <20170531165540.GA9371@amd> <002d01d2da6e$42a987b0$c7fc9710$@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <002d01d2da6e$42a987b0$c7fc9710$@codeaurora.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wu Fenglin , 'Pavel Machek' Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, 'Richard Purdie' , 'Rob Herring' , 'Mark Rutland' , linux-leds-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, subbaram-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org, aghayal-Rm6X0d1/PG5y9aJCnZT0Uw@public.gmane.org, wruan-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org, kgunda-Rm6X0d1/PG5y9aJCnZT0Uw@public.gmane.org List-Id: linux-leds@vger.kernel.org Hi Wu, On 06/01/2017 02:30 AM, Wu Fenglin wrote: > Thanks Pavel. > I will remove these two dts properties and define the default on/off time > values in C code. There are many things to sort out regarding your patch. I'll be able to give you a detailed feedback probably no sooner than at the weekend. -- Best regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751248AbdFATc2 (ORCPT ); Thu, 1 Jun 2017 15:32:28 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:34304 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751097AbdFATc0 (ORCPT ); Thu, 1 Jun 2017 15:32:26 -0400 Subject: Re: [PATCH V1 1/2] leds: leds-qti-rgb: Add LED driver for QTI TRI_LED module To: Wu Fenglin , "'Pavel Machek'" References: <20170531061541.10808-1-fenglinw@codeaurora.org> <20170531061541.10808-2-fenglinw@codeaurora.org> <20170531075536.GA13028@amd> <001301d2d9e7$3102b720$93082560$@codeaurora.org> <20170531165540.GA9371@amd> <002d01d2da6e$42a987b0$c7fc9710$@codeaurora.org> Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, "'Richard Purdie'" , "'Rob Herring'" , "'Mark Rutland'" , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, subbaram@quicinc.com, aghayal@qti.qualcomm.com, wruan@quicinc.com, kgunda@qti.qualcomm.com From: Jacek Anaszewski X-Enigmail-Draft-Status: N1110 Message-ID: <2c01fa38-b711-56af-5458-e726540d37ea@gmail.com> Date: Thu, 1 Jun 2017 21:31:40 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.1 MIME-Version: 1.0 In-Reply-To: <002d01d2da6e$42a987b0$c7fc9710$@codeaurora.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wu, On 06/01/2017 02:30 AM, Wu Fenglin wrote: > Thanks Pavel. > I will remove these two dts properties and define the default on/off time > values in C code. There are many things to sort out regarding your patch. I'll be able to give you a detailed feedback probably no sooner than at the weekend. -- Best regards, Jacek Anaszewski