From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Damien Hedde" <damien.hedde@greensocs.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH-for-5.2 4/4] hw/char/serial: Use the Clock API to feed the UART reference clock
Date: Wed, 12 Aug 2020 10:46:42 -0700 [thread overview]
Message-ID: <2c086f30-ee19-0efd-0b45-efa4688a3c67@linaro.org> (raw)
In-Reply-To: <20200806130340.17316-5-f4bug@amsat.org>
On 8/6/20 6:03 AM, Philippe Mathieu-Daudé wrote:
> In the same chipset, UARTs can be clocked at different rate, or the
> input clock can be changed at runtime. The Clock API allow us to
> propagate such clock rate change to the device.
> Let the SerialState have its reference input clock (called 'rclk')
> and if not clock is connected to the device, use the currently provided
s/not/no/
> frequency, to not modify the current code behavior.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/char/serial.h | 3 +++
> hw/char/serial.c | 35 ++++++++++++++++++++++++++++-------
> 2 files changed, 31 insertions(+), 7 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-08-12 17:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 13:03 [PATCH-for-5.2 0/4] hw/char/serial: Use the Clock API to feed the UART reference clock Philippe Mathieu-Daudé
2020-08-06 13:03 ` [PATCH-for-5.2 1/4] hw/char/serial: Replace commented DPRINTF() by trace event Philippe Mathieu-Daudé
2020-08-12 17:41 ` Richard Henderson
2020-08-06 13:03 ` [PATCH-for-5.2 2/4] hw/char/serial: Remove old DEBUG_SERIAL commented code Philippe Mathieu-Daudé
2020-08-12 17:42 ` Richard Henderson
2020-08-06 13:03 ` [PATCH-for-5.2 3/4] hw/char/serial: Let SerialState have an 'id' field Philippe Mathieu-Daudé
2020-08-12 17:43 ` Richard Henderson
2020-08-06 13:03 ` [PATCH-for-5.2 4/4] hw/char/serial: Use the Clock API to feed the UART reference clock Philippe Mathieu-Daudé
2020-08-12 17:46 ` Richard Henderson [this message]
2020-08-22 20:00 ` [PATCH-for-5.2 0/4] " Philippe Mathieu-Daudé
2020-08-24 15:19 ` Peter Maydell
2020-08-26 9:52 ` Philippe Mathieu-Daudé
2020-09-01 16:54 ` Marc-André Lureau
2020-09-01 17:02 ` Paolo Bonzini
2020-09-02 10:41 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c086f30-ee19-0efd-0b45-efa4688a3c67@linaro.org \
--to=richard.henderson@linaro.org \
--cc=damien.hedde@greensocs.com \
--cc=f4bug@amsat.org \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.