From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5858C433F5 for ; Fri, 19 Nov 2021 01:57:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD3E961AFB for ; Fri, 19 Nov 2021 01:57:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231956AbhKSCAz (ORCPT ); Thu, 18 Nov 2021 21:00:55 -0500 Received: from twspam01.aspeedtech.com ([211.20.114.71]:4996 "EHLO twspam01.aspeedtech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbhKSCAy (ORCPT ); Thu, 18 Nov 2021 21:00:54 -0500 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1AJ1Vfjj078015; Fri, 19 Nov 2021 09:31:41 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from [192.168.2.115] (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 19 Nov 2021 09:55:28 +0800 Message-ID: <2c0cc308-16d4-69e4-f81f-597ceb9824f5@aspeedtech.com> Date: Fri, 19 Nov 2021 09:55:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v5 03/10] media: aspeed: add more debug log messages Content-Language: en-US To: Sakari Ailus CC: "eajames@linux.ibm.com" , "mchehab@kernel.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "hverkuil-cisco@xs4all.nl" , "gregkh@linuxfoundation.org" , "laurent.pinchart@ideasonboard.com" , "linux-media@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" References: <20211118074030.685-1-jammy_huang@aspeedtech.com> <20211118074030.685-4-jammy_huang@aspeedtech.com> From: Jammy Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1AJ1Vfjj078015 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sakari, On 2021/11/18 下午 07:57, Sakari Ailus wrote: > Hi Jammy, > > On Thu, Nov 18, 2021 at 03:40:24PM +0800, Jammy Huang wrote: >> The new messages are listed as below: >> 1. jpeg header and capture buffer information >> 2. information for each irq >> 3. current capture mode, sync or direct-fetch >> 4. time consumed for each frame >> 5. input timing changed information >> >> Signed-off-by: Jammy Huang >> --- >> v5: >> - no update >> v4: >> - modify log level >> v3: >> - update commit message >> v2: >> - new >> --- >> drivers/media/platform/aspeed-video.c | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c >> index 6af57467b6d4..e8dd0a7ebfc7 100644 >> --- a/drivers/media/platform/aspeed-video.c >> +++ b/drivers/media/platform/aspeed-video.c >> @@ -461,12 +461,17 @@ static void aspeed_video_write(struct aspeed_video *video, u32 reg, u32 val) >> >> static void update_perf(struct aspeed_video_perf *p) >> { >> + struct aspeed_video *v = container_of(p, struct aspeed_video, >> + perf); >> + >> p->duration = >> ktime_to_ms(ktime_sub(ktime_get(), p->last_sample)); >> p->totaltime += p->duration; >> >> p->duration_max = max(p->duration, p->duration_max); >> p->duration_min = min(p->duration, p->duration_min); >> + v4l2_dbg(2, debug, &v->v4l2_dev, "time consumed: %d ms\n", >> + p->duration); >> } >> >> static int aspeed_video_start_frame(struct aspeed_video *video) >> @@ -597,6 +602,12 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) >> struct aspeed_video *video = arg; >> u32 sts = aspeed_video_read(video, VE_INTERRUPT_STATUS); >> >> + v4l2_dbg(2, debug, &video->v4l2_dev, "irq sts=%#x %s%s%s%s\n", sts, >> + sts & VE_INTERRUPT_MODE_DETECT_WD ? ", unlock" : "", >> + sts & VE_INTERRUPT_MODE_DETECT ? ", lock" : "", >> + sts & VE_INTERRUPT_CAPTURE_COMPLETE ? ", capture-done" : "", >> + sts & VE_INTERRUPT_COMP_COMPLETE ? ", comp-done" : ""); >> + >> /* >> * Resolution changed or signal was lost; reset the engine and >> * re-initialize >> @@ -910,6 +921,7 @@ static void aspeed_video_set_resolution(struct aspeed_video *video) >> >> /* Don't use direct mode below 1024 x 768 (irqs don't fire) */ >> if (size < DIRECT_FETCH_THRESHOLD) { >> + v4l2_dbg(1, debug, &video->v4l2_dev, "Capture: Sync Mode\n"); >> aspeed_video_write(video, VE_TGS_0, >> FIELD_PREP(VE_TGS_FIRST, >> video->frame_left - 1) | >> @@ -921,6 +933,7 @@ static void aspeed_video_set_resolution(struct aspeed_video *video) >> video->frame_bottom + 1)); >> aspeed_video_update(video, VE_CTRL, 0, VE_CTRL_INT_DE); >> } else { >> + v4l2_dbg(1, debug, &video->v4l2_dev, "Capture: Direct Mode\n"); >> aspeed_video_update(video, VE_CTRL, 0, VE_CTRL_DIRECT_FETCH); >> } >> >> @@ -937,6 +950,10 @@ static void aspeed_video_set_resolution(struct aspeed_video *video) >> if (!aspeed_video_alloc_buf(video, &video->srcs[1], size)) >> goto err_mem; >> >> + v4l2_dbg(1, debug, &video->v4l2_dev, "src buf0 addr(%#x) size(%d)\n", >> + video->srcs[0].dma, video->srcs[0].size); >> + v4l2_dbg(1, debug, &video->v4l2_dev, "src buf1 addr(%#x) size(%d)\n", >> + video->srcs[1].dma, video->srcs[1].size); >> aspeed_video_write(video, VE_SRC0_ADDR, video->srcs[0].dma); >> aspeed_video_write(video, VE_SRC1_ADDR, video->srcs[1].dma); >> } >> @@ -1201,6 +1218,9 @@ static int aspeed_video_set_dv_timings(struct file *file, void *fh, >> >> timings->type = V4L2_DV_BT_656_1120; >> >> + v4l2_dbg(1, debug, &video->v4l2_dev, "set new timings(%dx%d)\n", >> + timings->bt.width, timings->bt.height); >> + >> return 0; >> } >> >> @@ -1383,6 +1403,7 @@ static void aspeed_video_resolution_work(struct work_struct *work) >> .u.src_change.changes = V4L2_EVENT_SRC_CH_RESOLUTION, >> }; >> >> + v4l2_dbg(1, debug, &video->v4l2_dev, "fire source change event\n"); >> v4l2_event_queue(&video->vdev, &ev); >> } else if (test_bit(VIDEO_STREAMING, &video->flags)) { >> /* No resolution change so just restart streaming */ >> @@ -1715,6 +1736,7 @@ static int aspeed_video_init(struct aspeed_video *video) >> dev_err(dev, "Unable to request IRQ %d\n", irq); >> return rc; >> } >> + dev_info(video->dev, "irq %d\n", irq); >> >> video->eclk = devm_clk_get(dev, "eclk"); >> if (IS_ERR(video->eclk)) { >> @@ -1751,6 +1773,8 @@ static int aspeed_video_init(struct aspeed_video *video) >> rc = -ENOMEM; >> goto err_release_reserved_mem; >> } >> + dev_info(video->dev, "alloc mem size(%d) at %#x for jpeg header\n", >> + VE_JPEG_HEADER_SIZE, video->jpeg.dma); >> >> aspeed_video_init_jpeg_table(video->jpeg.virt, video->yuv420); >> > You're using both v4l2_*() and dev_*() functions for printing messages. > They come with different prefixes, and it'd be better to stick with either, > not both. Sure, I agree with you. Why I still have dev_*() here is v4l2_dev isn't ready yet before v4l2_device_register(). I think it could better to keep dev_*() in dev's probe(). -- Best Regards Jammy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A64F4C433EF for ; Fri, 19 Nov 2021 01:58:19 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0E1E61A09 for ; Fri, 19 Nov 2021 01:58:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F0E1E61A09 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4HwKZK34Dtz30RS for ; Fri, 19 Nov 2021 12:58:17 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=aspeedtech.com (client-ip=211.20.114.71; helo=twspam01.aspeedtech.com; envelope-from=jammy_huang@aspeedtech.com; receiver=) Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4HwKYq6JBjz2xr3; Fri, 19 Nov 2021 12:57:49 +1100 (AEDT) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1AJ1Vfjj078015; Fri, 19 Nov 2021 09:31:41 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from [192.168.2.115] (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 19 Nov 2021 09:55:28 +0800 Message-ID: <2c0cc308-16d4-69e4-f81f-597ceb9824f5@aspeedtech.com> Date: Fri, 19 Nov 2021 09:55:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v5 03/10] media: aspeed: add more debug log messages Content-Language: en-US To: Sakari Ailus References: <20211118074030.685-1-jammy_huang@aspeedtech.com> <20211118074030.685-4-jammy_huang@aspeedtech.com> From: Jammy Huang In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1AJ1Vfjj078015 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-aspeed@lists.ozlabs.org" , "andrew@aj.id.au" , "gregkh@linuxfoundation.org" , "openbmc@lists.ozlabs.org" , "eajames@linux.ibm.com" , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "hverkuil-cisco@xs4all.nl" , "mchehab@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "laurent.pinchart@ideasonboard.com" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hi Sakari, On 2021/11/18 下午 07:57, Sakari Ailus wrote: > Hi Jammy, > > On Thu, Nov 18, 2021 at 03:40:24PM +0800, Jammy Huang wrote: >> The new messages are listed as below: >> 1. jpeg header and capture buffer information >> 2. information for each irq >> 3. current capture mode, sync or direct-fetch >> 4. time consumed for each frame >> 5. input timing changed information >> >> Signed-off-by: Jammy Huang >> --- >> v5: >> - no update >> v4: >> - modify log level >> v3: >> - update commit message >> v2: >> - new >> --- >> drivers/media/platform/aspeed-video.c | 24 ++++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c >> index 6af57467b6d4..e8dd0a7ebfc7 100644 >> --- a/drivers/media/platform/aspeed-video.c >> +++ b/drivers/media/platform/aspeed-video.c >> @@ -461,12 +461,17 @@ static void aspeed_video_write(struct aspeed_video *video, u32 reg, u32 val) >> >> static void update_perf(struct aspeed_video_perf *p) >> { >> + struct aspeed_video *v = container_of(p, struct aspeed_video, >> + perf); >> + >> p->duration = >> ktime_to_ms(ktime_sub(ktime_get(), p->last_sample)); >> p->totaltime += p->duration; >> >> p->duration_max = max(p->duration, p->duration_max); >> p->duration_min = min(p->duration, p->duration_min); >> + v4l2_dbg(2, debug, &v->v4l2_dev, "time consumed: %d ms\n", >> + p->duration); >> } >> >> static int aspeed_video_start_frame(struct aspeed_video *video) >> @@ -597,6 +602,12 @@ static irqreturn_t aspeed_video_irq(int irq, void *arg) >> struct aspeed_video *video = arg; >> u32 sts = aspeed_video_read(video, VE_INTERRUPT_STATUS); >> >> + v4l2_dbg(2, debug, &video->v4l2_dev, "irq sts=%#x %s%s%s%s\n", sts, >> + sts & VE_INTERRUPT_MODE_DETECT_WD ? ", unlock" : "", >> + sts & VE_INTERRUPT_MODE_DETECT ? ", lock" : "", >> + sts & VE_INTERRUPT_CAPTURE_COMPLETE ? ", capture-done" : "", >> + sts & VE_INTERRUPT_COMP_COMPLETE ? ", comp-done" : ""); >> + >> /* >> * Resolution changed or signal was lost; reset the engine and >> * re-initialize >> @@ -910,6 +921,7 @@ static void aspeed_video_set_resolution(struct aspeed_video *video) >> >> /* Don't use direct mode below 1024 x 768 (irqs don't fire) */ >> if (size < DIRECT_FETCH_THRESHOLD) { >> + v4l2_dbg(1, debug, &video->v4l2_dev, "Capture: Sync Mode\n"); >> aspeed_video_write(video, VE_TGS_0, >> FIELD_PREP(VE_TGS_FIRST, >> video->frame_left - 1) | >> @@ -921,6 +933,7 @@ static void aspeed_video_set_resolution(struct aspeed_video *video) >> video->frame_bottom + 1)); >> aspeed_video_update(video, VE_CTRL, 0, VE_CTRL_INT_DE); >> } else { >> + v4l2_dbg(1, debug, &video->v4l2_dev, "Capture: Direct Mode\n"); >> aspeed_video_update(video, VE_CTRL, 0, VE_CTRL_DIRECT_FETCH); >> } >> >> @@ -937,6 +950,10 @@ static void aspeed_video_set_resolution(struct aspeed_video *video) >> if (!aspeed_video_alloc_buf(video, &video->srcs[1], size)) >> goto err_mem; >> >> + v4l2_dbg(1, debug, &video->v4l2_dev, "src buf0 addr(%#x) size(%d)\n", >> + video->srcs[0].dma, video->srcs[0].size); >> + v4l2_dbg(1, debug, &video->v4l2_dev, "src buf1 addr(%#x) size(%d)\n", >> + video->srcs[1].dma, video->srcs[1].size); >> aspeed_video_write(video, VE_SRC0_ADDR, video->srcs[0].dma); >> aspeed_video_write(video, VE_SRC1_ADDR, video->srcs[1].dma); >> } >> @@ -1201,6 +1218,9 @@ static int aspeed_video_set_dv_timings(struct file *file, void *fh, >> >> timings->type = V4L2_DV_BT_656_1120; >> >> + v4l2_dbg(1, debug, &video->v4l2_dev, "set new timings(%dx%d)\n", >> + timings->bt.width, timings->bt.height); >> + >> return 0; >> } >> >> @@ -1383,6 +1403,7 @@ static void aspeed_video_resolution_work(struct work_struct *work) >> .u.src_change.changes = V4L2_EVENT_SRC_CH_RESOLUTION, >> }; >> >> + v4l2_dbg(1, debug, &video->v4l2_dev, "fire source change event\n"); >> v4l2_event_queue(&video->vdev, &ev); >> } else if (test_bit(VIDEO_STREAMING, &video->flags)) { >> /* No resolution change so just restart streaming */ >> @@ -1715,6 +1736,7 @@ static int aspeed_video_init(struct aspeed_video *video) >> dev_err(dev, "Unable to request IRQ %d\n", irq); >> return rc; >> } >> + dev_info(video->dev, "irq %d\n", irq); >> >> video->eclk = devm_clk_get(dev, "eclk"); >> if (IS_ERR(video->eclk)) { >> @@ -1751,6 +1773,8 @@ static int aspeed_video_init(struct aspeed_video *video) >> rc = -ENOMEM; >> goto err_release_reserved_mem; >> } >> + dev_info(video->dev, "alloc mem size(%d) at %#x for jpeg header\n", >> + VE_JPEG_HEADER_SIZE, video->jpeg.dma); >> >> aspeed_video_init_jpeg_table(video->jpeg.virt, video->yuv420); >> > You're using both v4l2_*() and dev_*() functions for printing messages. > They come with different prefixes, and it'd be better to stick with either, > not both. Sure, I agree with you. Why I still have dev_*() here is v4l2_dev isn't ready yet before v4l2_device_register(). I think it could better to keep dev_*() in dev's probe(). -- Best Regards Jammy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B8E9C433F5 for ; Fri, 19 Nov 2021 01:59:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E0D361AA7 for ; Fri, 19 Nov 2021 01:59:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3E0D361AA7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=aspeedtech.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7+T0uLuaE9+6zCkuFW01gKACFIRo+XOb1WabbS/5UVc=; b=1QMKCeXXSCATPY z/1MX/JdVxb0lcnfS1QS+McjFQF7u8+qQijubj7rFfKb6cqTtiwt6x0ox6ZJsMJlBZXkJMPrvltLc PQVyxD9QNZ8GK4lK0y8C+MlydGcVaia6lHydLzz7OK2Vcncj3ZsCHwI4/RF77F6osNsQTK2zc1szw 1uGc4HGCxjq3xgXGNot+RfN9EPD1gI6aJK6c4G5sMcRZCyH6nTpjChw9YtZ1rR7jhjaQjx3rSg3/2 o2t1j93TKS7dl/n8UZet9xR34p7p0FhmCSdxvccTI08L65JtyaJOINbAvxK7t7/hB+Qe+kgItEycf VZvEHHFzGqr2CzkmytNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnt9v-009CE0-FM; Fri, 19 Nov 2021 01:57:47 +0000 Received: from twspam01.aspeedtech.com ([211.20.114.71]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mnt9q-009CDh-IL for linux-arm-kernel@lists.infradead.org; Fri, 19 Nov 2021 01:57:44 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1AJ1Vfjj078015; Fri, 19 Nov 2021 09:31:41 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from [192.168.2.115] (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 19 Nov 2021 09:55:28 +0800 Message-ID: <2c0cc308-16d4-69e4-f81f-597ceb9824f5@aspeedtech.com> Date: Fri, 19 Nov 2021 09:55:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Subject: Re: [PATCH v5 03/10] media: aspeed: add more debug log messages Content-Language: en-US To: Sakari Ailus CC: "eajames@linux.ibm.com" , "mchehab@kernel.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "hverkuil-cisco@xs4all.nl" , "gregkh@linuxfoundation.org" , "laurent.pinchart@ideasonboard.com" , "linux-media@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" References: <20211118074030.685-1-jammy_huang@aspeedtech.com> <20211118074030.685-4-jammy_huang@aspeedtech.com> From: Jammy Huang In-Reply-To: X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1AJ1Vfjj078015 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211118_175742_885919_1CB01135 X-CRM114-Status: GOOD ( 15.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgU2FrYXJpLAoKT24gMjAyMS8xMS8xOCDkuIvljYggMDc6NTcsIFNha2FyaSBBaWx1cyB3cm90 ZToKPiBIaSBKYW1teSwKPgo+IE9uIFRodSwgTm92IDE4LCAyMDIxIGF0IDAzOjQwOjI0UE0gKzA4 MDAsIEphbW15IEh1YW5nIHdyb3RlOgo+PiBUaGUgbmV3IG1lc3NhZ2VzIGFyZSBsaXN0ZWQgYXMg YmVsb3c6Cj4+IDEuIGpwZWcgaGVhZGVyIGFuZCBjYXB0dXJlIGJ1ZmZlciBpbmZvcm1hdGlvbgo+ PiAyLiBpbmZvcm1hdGlvbiBmb3IgZWFjaCBpcnEKPj4gMy4gY3VycmVudCBjYXB0dXJlIG1vZGUs IHN5bmMgb3IgZGlyZWN0LWZldGNoCj4+IDQuIHRpbWUgY29uc3VtZWQgZm9yIGVhY2ggZnJhbWUK Pj4gNS4gaW5wdXQgdGltaW5nIGNoYW5nZWQgaW5mb3JtYXRpb24KPj4KPj4gU2lnbmVkLW9mZi1i eTogSmFtbXkgSHVhbmcgPGphbW15X2h1YW5nQGFzcGVlZHRlY2guY29tPgo+PiAtLS0KPj4gdjU6 Cj4+ICAgIC0gbm8gdXBkYXRlCj4+IHY0Ogo+PiAgICAtIG1vZGlmeSBsb2cgbGV2ZWwKPj4gdjM6 Cj4+ICAgIC0gdXBkYXRlIGNvbW1pdCBtZXNzYWdlCj4+IHYyOgo+PiAgICAtIG5ldwo+PiAtLS0K Pj4gICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL2FzcGVlZC12aWRlby5jIHwgMjQgKysrKysrKysr KysrKysrKysrKysrKysrCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKykKPj4K Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vYXNwZWVkLXZpZGVvLmMgYi9k cml2ZXJzL21lZGlhL3BsYXRmb3JtL2FzcGVlZC12aWRlby5jCj4+IGluZGV4IDZhZjU3NDY3YjZk NC4uZThkZDBhN2ViZmM3IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL2Fz cGVlZC12aWRlby5jCj4+ICsrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vYXNwZWVkLXZpZGVv LmMKPj4gQEAgLTQ2MSwxMiArNDYxLDE3IEBAIHN0YXRpYyB2b2lkIGFzcGVlZF92aWRlb193cml0 ZShzdHJ1Y3QgYXNwZWVkX3ZpZGVvICp2aWRlbywgdTMyIHJlZywgdTMyIHZhbCkKPj4gICAKPj4g ICBzdGF0aWMgdm9pZCB1cGRhdGVfcGVyZihzdHJ1Y3QgYXNwZWVkX3ZpZGVvX3BlcmYgKnApCj4+ ICAgewo+PiArCXN0cnVjdCBhc3BlZWRfdmlkZW8gKnYgPSBjb250YWluZXJfb2YocCwgc3RydWN0 IGFzcGVlZF92aWRlbywKPj4gKwkJCQkJICAgICAgcGVyZik7Cj4+ICsKPj4gICAJcC0+ZHVyYXRp b24gPQo+PiAgIAkJa3RpbWVfdG9fbXMoa3RpbWVfc3ViKGt0aW1lX2dldCgpLCAgcC0+bGFzdF9z YW1wbGUpKTsKPj4gICAJcC0+dG90YWx0aW1lICs9IHAtPmR1cmF0aW9uOwo+PiAgIAo+PiAgIAlw LT5kdXJhdGlvbl9tYXggPSBtYXgocC0+ZHVyYXRpb24sIHAtPmR1cmF0aW9uX21heCk7Cj4+ICAg CXAtPmR1cmF0aW9uX21pbiA9IG1pbihwLT5kdXJhdGlvbiwgcC0+ZHVyYXRpb25fbWluKTsKPj4g Kwl2NGwyX2RiZygyLCBkZWJ1ZywgJnYtPnY0bDJfZGV2LCAidGltZSBjb25zdW1lZDogJWQgbXNc biIsCj4+ICsJCSBwLT5kdXJhdGlvbik7Cj4+ICAgfQo+PiAgIAo+PiAgIHN0YXRpYyBpbnQgYXNw ZWVkX3ZpZGVvX3N0YXJ0X2ZyYW1lKHN0cnVjdCBhc3BlZWRfdmlkZW8gKnZpZGVvKQo+PiBAQCAt NTk3LDYgKzYwMiwxMiBAQCBzdGF0aWMgaXJxcmV0dXJuX3QgYXNwZWVkX3ZpZGVvX2lycShpbnQg aXJxLCB2b2lkICphcmcpCj4+ICAgCXN0cnVjdCBhc3BlZWRfdmlkZW8gKnZpZGVvID0gYXJnOwo+ PiAgIAl1MzIgc3RzID0gYXNwZWVkX3ZpZGVvX3JlYWQodmlkZW8sIFZFX0lOVEVSUlVQVF9TVEFU VVMpOwo+PiAgIAo+PiArCXY0bDJfZGJnKDIsIGRlYnVnLCAmdmlkZW8tPnY0bDJfZGV2LCAiaXJx IHN0cz0lI3ggJXMlcyVzJXNcbiIsIHN0cywKPj4gKwkJIHN0cyAmIFZFX0lOVEVSUlVQVF9NT0RF X0RFVEVDVF9XRCA/ICIsIHVubG9jayIgOiAiIiwKPj4gKwkJIHN0cyAmIFZFX0lOVEVSUlVQVF9N T0RFX0RFVEVDVCA/ICIsIGxvY2siIDogIiIsCj4+ICsJCSBzdHMgJiBWRV9JTlRFUlJVUFRfQ0FQ VFVSRV9DT01QTEVURSA/ICIsIGNhcHR1cmUtZG9uZSIgOiAiIiwKPj4gKwkJIHN0cyAmIFZFX0lO VEVSUlVQVF9DT01QX0NPTVBMRVRFID8gIiwgY29tcC1kb25lIiA6ICIiKTsKPj4gKwo+PiAgIAkv Kgo+PiAgIAkgKiBSZXNvbHV0aW9uIGNoYW5nZWQgb3Igc2lnbmFsIHdhcyBsb3N0OyByZXNldCB0 aGUgZW5naW5lIGFuZAo+PiAgIAkgKiByZS1pbml0aWFsaXplCj4+IEBAIC05MTAsNiArOTIxLDcg QEAgc3RhdGljIHZvaWQgYXNwZWVkX3ZpZGVvX3NldF9yZXNvbHV0aW9uKHN0cnVjdCBhc3BlZWRf dmlkZW8gKnZpZGVvKQo+PiAgIAo+PiAgIAkvKiBEb24ndCB1c2UgZGlyZWN0IG1vZGUgYmVsb3cg MTAyNCB4IDc2OCAoaXJxcyBkb24ndCBmaXJlKSAqLwo+PiAgIAlpZiAoc2l6ZSA8IERJUkVDVF9G RVRDSF9USFJFU0hPTEQpIHsKPj4gKwkJdjRsMl9kYmcoMSwgZGVidWcsICZ2aWRlby0+djRsMl9k ZXYsICJDYXB0dXJlOiBTeW5jIE1vZGVcbiIpOwo+PiAgIAkJYXNwZWVkX3ZpZGVvX3dyaXRlKHZp ZGVvLCBWRV9UR1NfMCwKPj4gICAJCQkJICAgRklFTERfUFJFUChWRV9UR1NfRklSU1QsCj4+ICAg CQkJCQkgICAgICB2aWRlby0+ZnJhbWVfbGVmdCAtIDEpIHwKPj4gQEAgLTkyMSw2ICs5MzMsNyBA QCBzdGF0aWMgdm9pZCBhc3BlZWRfdmlkZW9fc2V0X3Jlc29sdXRpb24oc3RydWN0IGFzcGVlZF92 aWRlbyAqdmlkZW8pCj4+ICAgCQkJCQkgICAgICB2aWRlby0+ZnJhbWVfYm90dG9tICsgMSkpOwo+ PiAgIAkJYXNwZWVkX3ZpZGVvX3VwZGF0ZSh2aWRlbywgVkVfQ1RSTCwgMCwgVkVfQ1RSTF9JTlRf REUpOwo+PiAgIAl9IGVsc2Ugewo+PiArCQl2NGwyX2RiZygxLCBkZWJ1ZywgJnZpZGVvLT52NGwy X2RldiwgIkNhcHR1cmU6IERpcmVjdCBNb2RlXG4iKTsKPj4gICAJCWFzcGVlZF92aWRlb191cGRh dGUodmlkZW8sIFZFX0NUUkwsIDAsIFZFX0NUUkxfRElSRUNUX0ZFVENIKTsKPj4gICAJfQo+PiAg IAo+PiBAQCAtOTM3LDYgKzk1MCwxMCBAQCBzdGF0aWMgdm9pZCBhc3BlZWRfdmlkZW9fc2V0X3Jl c29sdXRpb24oc3RydWN0IGFzcGVlZF92aWRlbyAqdmlkZW8pCj4+ICAgCQlpZiAoIWFzcGVlZF92 aWRlb19hbGxvY19idWYodmlkZW8sICZ2aWRlby0+c3Jjc1sxXSwgc2l6ZSkpCj4+ICAgCQkJZ290 byBlcnJfbWVtOwo+PiAgIAo+PiArCQl2NGwyX2RiZygxLCBkZWJ1ZywgJnZpZGVvLT52NGwyX2Rl diwgInNyYyBidWYwIGFkZHIoJSN4KSBzaXplKCVkKVxuIiwKPj4gKwkJCSB2aWRlby0+c3Jjc1sw XS5kbWEsIHZpZGVvLT5zcmNzWzBdLnNpemUpOwo+PiArCQl2NGwyX2RiZygxLCBkZWJ1ZywgJnZp ZGVvLT52NGwyX2RldiwgInNyYyBidWYxIGFkZHIoJSN4KSBzaXplKCVkKVxuIiwKPj4gKwkJCSB2 aWRlby0+c3Jjc1sxXS5kbWEsIHZpZGVvLT5zcmNzWzFdLnNpemUpOwo+PiAgIAkJYXNwZWVkX3Zp ZGVvX3dyaXRlKHZpZGVvLCBWRV9TUkMwX0FERFIsIHZpZGVvLT5zcmNzWzBdLmRtYSk7Cj4+ICAg CQlhc3BlZWRfdmlkZW9fd3JpdGUodmlkZW8sIFZFX1NSQzFfQUREUiwgdmlkZW8tPnNyY3NbMV0u ZG1hKTsKPj4gICAJfQo+PiBAQCAtMTIwMSw2ICsxMjE4LDkgQEAgc3RhdGljIGludCBhc3BlZWRf dmlkZW9fc2V0X2R2X3RpbWluZ3Moc3RydWN0IGZpbGUgKmZpbGUsIHZvaWQgKmZoLAo+PiAgIAo+ PiAgIAl0aW1pbmdzLT50eXBlID0gVjRMMl9EVl9CVF82NTZfMTEyMDsKPj4gICAKPj4gKwl2NGwy X2RiZygxLCBkZWJ1ZywgJnZpZGVvLT52NGwyX2RldiwgInNldCBuZXcgdGltaW5ncyglZHglZClc biIsCj4+ICsJCSB0aW1pbmdzLT5idC53aWR0aCwgdGltaW5ncy0+YnQuaGVpZ2h0KTsKPj4gKwo+ PiAgIAlyZXR1cm4gMDsKPj4gICB9Cj4+ICAgCj4+IEBAIC0xMzgzLDYgKzE0MDMsNyBAQCBzdGF0 aWMgdm9pZCBhc3BlZWRfdmlkZW9fcmVzb2x1dGlvbl93b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAq d29yaykKPj4gICAJCQkudS5zcmNfY2hhbmdlLmNoYW5nZXMgPSBWNEwyX0VWRU5UX1NSQ19DSF9S RVNPTFVUSU9OLAo+PiAgIAkJfTsKPj4gICAKPj4gKwkJdjRsMl9kYmcoMSwgZGVidWcsICZ2aWRl by0+djRsMl9kZXYsICJmaXJlIHNvdXJjZSBjaGFuZ2UgZXZlbnRcbiIpOwo+PiAgIAkJdjRsMl9l dmVudF9xdWV1ZSgmdmlkZW8tPnZkZXYsICZldik7Cj4+ICAgCX0gZWxzZSBpZiAodGVzdF9iaXQo VklERU9fU1RSRUFNSU5HLCAmdmlkZW8tPmZsYWdzKSkgewo+PiAgIAkJLyogTm8gcmVzb2x1dGlv biBjaGFuZ2Ugc28ganVzdCByZXN0YXJ0IHN0cmVhbWluZyAqLwo+PiBAQCAtMTcxNSw2ICsxNzM2 LDcgQEAgc3RhdGljIGludCBhc3BlZWRfdmlkZW9faW5pdChzdHJ1Y3QgYXNwZWVkX3ZpZGVvICp2 aWRlbykKPj4gICAJCWRldl9lcnIoZGV2LCAiVW5hYmxlIHRvIHJlcXVlc3QgSVJRICVkXG4iLCBp cnEpOwo+PiAgIAkJcmV0dXJuIHJjOwo+PiAgIAl9Cj4+ICsJZGV2X2luZm8odmlkZW8tPmRldiwg ImlycSAlZFxuIiwgaXJxKTsKPj4gICAKPj4gICAJdmlkZW8tPmVjbGsgPSBkZXZtX2Nsa19nZXQo ZGV2LCAiZWNsayIpOwo+PiAgIAlpZiAoSVNfRVJSKHZpZGVvLT5lY2xrKSkgewo+PiBAQCAtMTc1 MSw2ICsxNzczLDggQEAgc3RhdGljIGludCBhc3BlZWRfdmlkZW9faW5pdChzdHJ1Y3QgYXNwZWVk X3ZpZGVvICp2aWRlbykKPj4gICAJCXJjID0gLUVOT01FTTsKPj4gICAJCWdvdG8gZXJyX3JlbGVh c2VfcmVzZXJ2ZWRfbWVtOwo+PiAgIAl9Cj4+ICsJZGV2X2luZm8odmlkZW8tPmRldiwgImFsbG9j IG1lbSBzaXplKCVkKSBhdCAlI3ggZm9yIGpwZWcgaGVhZGVyXG4iLAo+PiArCQkgVkVfSlBFR19I RUFERVJfU0laRSwgdmlkZW8tPmpwZWcuZG1hKTsKPj4gICAKPj4gICAJYXNwZWVkX3ZpZGVvX2lu aXRfanBlZ190YWJsZSh2aWRlby0+anBlZy52aXJ0LCB2aWRlby0+eXV2NDIwKTsKPj4gICAKPiBZ b3UncmUgdXNpbmcgYm90aCB2NGwyXyooKSBhbmQgZGV2XyooKSBmdW5jdGlvbnMgZm9yIHByaW50 aW5nIG1lc3NhZ2VzLgo+IFRoZXkgY29tZSB3aXRoIGRpZmZlcmVudCBwcmVmaXhlcywgYW5kIGl0 J2QgYmUgYmV0dGVyIHRvIHN0aWNrIHdpdGggZWl0aGVyLAo+IG5vdCBib3RoLgpTdXJlLCBJIGFn cmVlIHdpdGggeW91LiBXaHkgSSBzdGlsbCBoYXZlIGRldl8qKCkgaGVyZSBpcyB2NGwyX2RldiBp c24ndCAKcmVhZHkgeWV0IGJlZm9yZQp2NGwyX2RldmljZV9yZWdpc3RlcigpLiBJIHRoaW5rIGl0 IGNvdWxkIGJldHRlciB0byBrZWVwIGRldl8qKCkgaW4gZGV2J3MgCnByb2JlKCkuCgotLSAKQmVz dCBSZWdhcmRzCkphbW15CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBs aXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtYXJtLWtlcm5lbAo=