From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <kasan-dev@googlegroups.com>,
<linux-mm@kvack.org>
Subject: Re: [PATCH v2 0/3] arm64: support page mapping percpu first chunk allocator
Date: Mon, 26 Jul 2021 09:19:11 +0800 [thread overview]
Message-ID: <2c1254a7-561c-9b99-444b-c2d9aefa7b55@huawei.com> (raw)
In-Reply-To: <20210720025105.103680-1-wangkefeng.wang@huawei.com>
Hi Will and Catalin,any comments,kindly ping, thanks.
On 2021/7/20 10:51, Kefeng Wang wrote:
> Percpu embedded first chunk allocator is the firstly option, but it
> could fails on ARM64, eg,
> "percpu: max_distance=0x5fcfdc640000 too large for vmalloc space 0x781fefff0000"
> "percpu: max_distance=0x600000540000 too large for vmalloc space 0x7dffb7ff0000"
> "percpu: max_distance=0x5fff9adb0000 too large for vmalloc space 0x5dffb7ff0000"
>
> then we could meet "WARNING: CPU: 15 PID: 461 at vmalloc.c:3087 pcpu_get_vm_areas+0x488/0x838",
> even the system could not boot successfully.
>
> Let's implement page mapping percpu first chunk allocator as a fallback
> to the embedding allocator to increase the robustness of the system.
>
> Also fix a crash when both NEED_PER_CPU_PAGE_FIRST_CHUNK and KASAN_VMALLOC enabled.
>
> Tested on ARM64 qemu with cmdline "percpu_alloc=page" based on v5.14-rc2.
>
> V2:
> - fix build error when CONFIG_KASAN disabled, found by lkp@intel.com
> - drop wrong __weak comment from kasan_populate_early_vm_area_shadow(),
> found by Marco Elver <elver@google.com>
>
> Kefeng Wang (3):
> vmalloc: Choose a better start address in vm_area_register_early()
> arm64: Support page mapping percpu first chunk allocator
> kasan: arm64: Fix pcpu_page_first_chunk crash with KASAN_VMALLOC
>
> arch/arm64/Kconfig | 4 ++
> arch/arm64/mm/kasan_init.c | 17 ++++++++
> drivers/base/arch_numa.c | 82 +++++++++++++++++++++++++++++++++-----
> include/linux/kasan.h | 6 +++
> mm/kasan/init.c | 5 +++
> mm/vmalloc.c | 9 +++--
> 6 files changed, 110 insertions(+), 13 deletions(-)
>
WARNING: multiple messages have this Message-ID (diff)
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Dmitry Vyukov <dvyukov@google.com>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <kasan-dev@googlegroups.com>,
<linux-mm@kvack.org>
Subject: Re: [PATCH v2 0/3] arm64: support page mapping percpu first chunk allocator
Date: Mon, 26 Jul 2021 09:19:11 +0800 [thread overview]
Message-ID: <2c1254a7-561c-9b99-444b-c2d9aefa7b55@huawei.com> (raw)
In-Reply-To: <20210720025105.103680-1-wangkefeng.wang@huawei.com>
Hi Will and Catalin,any comments,kindly ping, thanks.
On 2021/7/20 10:51, Kefeng Wang wrote:
> Percpu embedded first chunk allocator is the firstly option, but it
> could fails on ARM64, eg,
> "percpu: max_distance=0x5fcfdc640000 too large for vmalloc space 0x781fefff0000"
> "percpu: max_distance=0x600000540000 too large for vmalloc space 0x7dffb7ff0000"
> "percpu: max_distance=0x5fff9adb0000 too large for vmalloc space 0x5dffb7ff0000"
>
> then we could meet "WARNING: CPU: 15 PID: 461 at vmalloc.c:3087 pcpu_get_vm_areas+0x488/0x838",
> even the system could not boot successfully.
>
> Let's implement page mapping percpu first chunk allocator as a fallback
> to the embedding allocator to increase the robustness of the system.
>
> Also fix a crash when both NEED_PER_CPU_PAGE_FIRST_CHUNK and KASAN_VMALLOC enabled.
>
> Tested on ARM64 qemu with cmdline "percpu_alloc=page" based on v5.14-rc2.
>
> V2:
> - fix build error when CONFIG_KASAN disabled, found by lkp@intel.com
> - drop wrong __weak comment from kasan_populate_early_vm_area_shadow(),
> found by Marco Elver <elver@google.com>
>
> Kefeng Wang (3):
> vmalloc: Choose a better start address in vm_area_register_early()
> arm64: Support page mapping percpu first chunk allocator
> kasan: arm64: Fix pcpu_page_first_chunk crash with KASAN_VMALLOC
>
> arch/arm64/Kconfig | 4 ++
> arch/arm64/mm/kasan_init.c | 17 ++++++++
> drivers/base/arch_numa.c | 82 +++++++++++++++++++++++++++++++++-----
> include/linux/kasan.h | 6 +++
> mm/kasan/init.c | 5 +++
> mm/vmalloc.c | 9 +++--
> 6 files changed, 110 insertions(+), 13 deletions(-)
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-07-26 1:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-20 2:51 [PATCH v2 0/3] arm64: support page mapping percpu first chunk allocator Kefeng Wang
2021-07-20 2:51 ` Kefeng Wang
2021-07-20 2:51 ` [PATCH v2 1/3] vmalloc: Choose a better start address in vm_area_register_early() Kefeng Wang
2021-07-20 2:51 ` Kefeng Wang
2021-08-01 15:23 ` Catalin Marinas
2021-08-01 15:23 ` Catalin Marinas
2021-08-02 2:39 ` Kefeng Wang
2021-08-02 2:39 ` Kefeng Wang
2021-08-04 11:14 ` Catalin Marinas
2021-08-04 11:14 ` Catalin Marinas
2021-08-05 12:46 ` Kefeng Wang
2021-08-05 12:46 ` Kefeng Wang
2021-07-20 2:51 ` [PATCH v2 2/3] arm64: Support page mapping percpu first chunk allocator Kefeng Wang
2021-07-20 2:51 ` Kefeng Wang
2021-08-01 15:53 ` Catalin Marinas
2021-08-01 15:53 ` Catalin Marinas
2021-08-02 2:47 ` Kefeng Wang
2021-08-02 2:47 ` Kefeng Wang
2021-07-20 2:51 ` [PATCH v2 3/3] kasan: arm64: Fix pcpu_page_first_chunk crash with KASAN_VMALLOC Kefeng Wang
2021-07-20 2:51 ` Kefeng Wang
2021-07-22 11:00 ` Marco Elver
2021-07-22 11:00 ` Marco Elver
2021-07-22 12:14 ` Kefeng Wang
2021-07-22 12:14 ` Kefeng Wang
2021-07-26 1:19 ` Kefeng Wang [this message]
2021-07-26 1:19 ` [PATCH v2 0/3] arm64: support page mapping percpu first chunk allocator Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c1254a7-561c-9b99-444b-c2d9aefa7b55@huawei.com \
--to=wangkefeng.wang@huawei.com \
--cc=andreyknvl@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryabinin.a.a@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.