From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [PATCH bpf-next 2/2] samples: bpf: get ifindex from ifname Date: Thu, 18 Oct 2018 14:30:05 -0700 Message-ID: <2c1c8e81-a588-4b57-2218-5050003ac35d@gmail.com> References: <20181018204709.29547-1-mcroce@redhat.com> <20181018204709.29547-2-mcroce@redhat.com> <20181018204709.29547-3-mcroce@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Alexei Starovoitov , Daniel Borkmann To: Matteo Croce , netdev@vger.kernel.org Return-path: Received: from mail-it1-f193.google.com ([209.85.166.193]:55315 "EHLO mail-it1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725735AbeJSFdL (ORCPT ); Fri, 19 Oct 2018 01:33:11 -0400 Received: by mail-it1-f193.google.com with SMTP id c23-v6so2106540itd.5 for ; Thu, 18 Oct 2018 14:30:16 -0700 (PDT) In-Reply-To: <20181018204709.29547-3-mcroce@redhat.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/18/2018 01:47 PM, Matteo Croce wrote: > Find the ifindex via ioctl(SIOCGIFINDEX) instead of requiring the > numeric ifindex. > > Signed-off-by: Matteo Croce > --- I don't think there are any expectation that samples have to be stable as far as inputs over versions. And because I consistently run this with the ifname before realizing its the ifindex not string name I'll Ack it. Acked-by: John Fastabend