From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0840AC433EF for ; Mon, 4 Jul 2022 08:01:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 36CDB844D6; Mon, 4 Jul 2022 10:01:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 13B1A83E70; Mon, 4 Jul 2022 10:01:19 +0200 (CEST) Received: from smtpout4.mo529.mail-out.ovh.net (smtpout4.mo529.mail-out.ovh.net [217.182.185.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 35BD4844D6 for ; Mon, 4 Jul 2022 10:01:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=clg@kaod.org Received: from mxplan5.mail.ovh.net (unknown [10.108.20.173]) by mo529.mail-out.ovh.net (Postfix) with ESMTPS id B3A691140B006; Mon, 4 Jul 2022 10:01:13 +0200 (CEST) Received: from kaod.org (37.59.142.96) by DAG4EX1.mxp5.local (172.16.2.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Mon, 4 Jul 2022 10:01:12 +0200 Authentication-Results: garm.ovh; auth=pass (GARM-96R001645d6d4d-0a4c-47eb-b5ec-8e511c8fae5a, 4A40CDD4EF23B7AB23DB7B782370CFE82F39A47B) smtp.auth=clg@kaod.org X-OVh-ClientIp: 82.64.250.170 Message-ID: <2c1c916d-15f4-2667-2b7b-80fce2118f5e@kaod.org> Date: Mon, 4 Jul 2022 10:01:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [v4 04/12] configs: aspeed: Enable SPI flash features Content-Language: en-US To: Chin-Ting Kuo , ChiaWei Wang , "lukma@denx.de" , "seanga2@gmail.com" , Ryan Chen , BMC-SW , "jagan@amarulasolutions.com" , "vigneshr@ti.com" , "u-boot@lists.denx.de" , "p.yadav@ti.com" , Joel Stanley References: <20220524055650.1115899-1-chin-ting_kuo@aspeedtech.com> <20220524055650.1115899-5-chin-ting_kuo@aspeedtech.com> <4417d3e2-a3e0-3b68-0502-a60de0e6eab5@kaod.org> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [37.59.142.96] X-ClientProxiedBy: DAG5EX2.mxp5.local (172.16.2.42) To DAG4EX1.mxp5.local (172.16.2.31) X-Ovh-Tracer-GUID: 66ee3047-549e-4cad-a4b5-23a9e8cb6228 X-Ovh-Tracer-Id: 11405647534401358837 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudehkedguddviecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfhfhfgjtgfgihesthekredttdefjeenucfhrhhomhepveorughrihgtpgfnvggpifhorghtvghruceotghlgheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeeigedvffekgeeftedutddttdevudeihfegudffkeeitdekkeetkefhffelveelleenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddrleeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehmgihplhgrnhehrdhmrghilhdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheptghlgheskhgrohgurdhorhhgpdhnsggprhgtphhtthhopedupdhrtghpthhtohepjhhovghlsehjmhhsrdhiugdrrghupdfovfetjfhoshhtpehmohehvdel X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean [ Adding Joel ] On 7/3/22 11:00, Chin-Ting Kuo wrote: > Hi Cédric, > >> -----Original Message----- >> From: Cédric Le Goater >> Sent: Friday, July 1, 2022 7:51 PM >> Subject: Re: [v4 04/12] configs: aspeed: Enable SPI flash features >> >> On 7/1/22 11:28, Cédric Le Goater wrote: >>> On 5/24/22 07:56, Chin-Ting Kuo wrote: >>>> - Enable ASPEED SPI controller driver. >>>> - Enable SPI flash memory configurations. >>>> - Enable configurations for SPI flash manufacturers >>>>    supported on both ASPEED AST2500 and AST2600 AVL. >>>> >>>> Signed-off-by: Chin-Ting Kuo >>>> --- >>>>   configs/evb-ast2500_defconfig | 13 +++++++++++++ >>>>   configs/evb-ast2600_defconfig | 13 +++++++++++++ >>>>   2 files changed, 26 insertions(+) >>>> >>>> diff --git a/configs/evb-ast2500_defconfig >>>> b/configs/evb-ast2500_defconfig index 2371cc2742..fd04fe5a60 100644 >>>> --- a/configs/evb-ast2500_defconfig >>>> +++ b/configs/evb-ast2500_defconfig >>>> @@ -35,6 +35,16 @@ CONFIG_DM_I2C=y >>>>   CONFIG_SYS_I2C_ASPEED=y >>>>   CONFIG_MMC_SDHCI=y >>>>   CONFIG_MMC_SDHCI_ASPEED=y >>>> +CONFIG_DM_SPI_FLASH=y >>>> +CONFIG_SPI_FLASH_SFDP_SUPPORT=y >>>> +CONFIG_SPI_FLASH_GIGADEVICE=y >>>> +CONFIG_SPI_FLASH_ISSI=y >>>> +CONFIG_SPI_FLASH_MACRONIX=y >>>> +CONFIG_SPI_FLASH_SPANSION=y >>>> +CONFIG_SPI_FLASH_STMICRO=y >>>> +CONFIG_SPI_FLASH_SST=y >>>> +CONFIG_SPI_FLASH_WINBOND=y >>>> +# CONFIG_SPI_FLASH_USE_4K_SECTORS is not set >>>>   CONFIG_PHY_REALTEK=y >>>>   CONFIG_DM_ETH=y >>>>   CONFIG_FTGMAC100=y >>>> @@ -44,6 +54,9 @@ CONFIG_RAM=y >>>>   CONFIG_DM_RESET=y >>>>   CONFIG_DM_SERIAL=y >>>>   CONFIG_SYS_NS16550=y >>>> +CONFIG_SPI=y >>>> +CONFIG_DM_SPI=y >>>> +CONFIG_SPI_ASPEED=y >>>>   CONFIG_SYSRESET=y >>>>   CONFIG_TIMER=y >>>>   CONFIG_WDT=y >>> >>> This is breaking boot on the AST2500 evb (QEMU) . I haven't found why >>> yet. You might want to take a look. >> >> The resulting binary is too big for the flash layout we use on OpenBMC. > > What’s the flash layout used by you? I tested this patch series on AST2500 EVB, and it was okay before. This is the OpenBMC 32M flash layout : [ 1.389291] Creating 5 MTD partitions on "bmc": [ 1.389710] 0x000000000000-0x000000060000 : "u-boot" [ 1.391281] 0x000000060000-0x000000080000 : "u-boot-env" [ 1.392391] 0x000000080000-0x0000004c0000 : "kernel" [ 1.393434] 0x0000004c0000-0x000001c00000 : "rofs" [ 1.394467] 0x000001c00000-0x000002000000 : "rwfs" When using mainline u-boot, these extra configs are needed to boot the OpenBMC image : CONFIG_FIT=y CONFIG_BOOTCOMMAND="bootm 20080000" The SPI driver is adding quite a lot of .text so I removed MMC support to keep uboot.bin below 384KB Thanks, C.