All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: Michal Hocko <mhocko@kernel.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Johannes Weiner <hannes@cmpxchg.org>,
	cgroups@vger.kernel.org,
	Raghavendra K T <raghavendra.kt@linux.vnet.ibm.com>
Subject: Re: [PATCH] memcg: make it work on sparse non-0-node systems
Date: Fri, 17 May 2019 10:16:23 +0200	[thread overview]
Message-ID: <2c3fab03-99fb-9313-140b-04a245065dd7@suse.cz> (raw)
In-Reply-To: <20190517080044.tnwhbeyxcccsymgf@esperanza>

On 17. 05. 19, 10:00, Vladimir Davydov wrote:
> On Fri, May 17, 2019 at 06:48:37AM +0200, Jiri Slaby wrote:
>> On 16. 05. 19, 15:59, Michal Hocko wrote:
>>>> However, I tend to agree with Michal that (ab)using node[0].memcg_lrus
>>>> to check if a list_lru is memcg aware looks confusing. I guess we could
>>>> simply add a bool flag to list_lru instead. Something like this, may be:
>>>
>>> Yes, this makes much more sense to me!
>>
>> I am not sure if I should send a patch with this solution or Vladimir
>> will (given he is an author and has a diff already)?
> 
> I didn't even try to compile it, let alone test it. I'd appreciate if
> you could wrap it up and send it out using your authorship. Feel free
> to add my acked-by.

OK, NP.

thanks,
-- 
js
suse labs

  reply	other threads:[~2019-05-17  8:16 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-29  8:16 memcg causes crashes in list_lru_add Jiri Slaby
2019-04-29  9:25 ` Jiri Slaby
2019-04-29 10:09   ` Jiri Slaby
2019-04-29 10:40     ` Michal Hocko
2019-04-29 10:43       ` Michal Hocko
2019-04-29 10:59     ` [PATCH] memcg: make it work on sparse non-0-node systems Jiri Slaby
2019-04-29 11:30       ` Michal Hocko
2019-04-29 11:55         ` Jiri Slaby
2019-04-29 12:11           ` Jiri Slaby
2019-04-29 13:15           ` Michal Hocko
2019-05-09  7:21       ` Jiri Slaby
2019-05-09 12:25       ` Vladimir Davydov
2019-05-09 16:05         ` Shakeel Butt
2019-05-09 16:05           ` Shakeel Butt
2019-05-16 13:59         ` Michal Hocko
2019-05-17  4:48           ` Jiri Slaby
2019-05-17  8:00             ` Vladimir Davydov
2019-05-17  8:16               ` Jiri Slaby [this message]
2019-05-17 11:42               ` [PATCH v2] " Jiri Slaby
2019-05-17 12:13                 ` Shakeel Butt
2019-05-17 12:13                   ` Shakeel Butt
2019-05-17 12:27                 ` Michal Hocko
2019-05-22  9:19                 ` [PATCH -resend " Jiri Slaby
2019-05-29 13:14                   ` Sasha Levin
2019-04-29 10:17   ` memcg causes crashes in list_lru_add Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c3fab03-99fb-9313-140b-04a245065dd7@suse.cz \
    --to=jslaby@suse.cz \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=raghavendra.kt@linux.vnet.ibm.com \
    --cc=vdavydov.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.