From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08973C433ED for ; Mon, 12 Apr 2021 18:52:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C007F61357 for ; Mon, 12 Apr 2021 18:52:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244132AbhDLSwn (ORCPT ); Mon, 12 Apr 2021 14:52:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236725AbhDLSwm (ORCPT ); Mon, 12 Apr 2021 14:52:42 -0400 X-Greylist: delayed 481 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 12 Apr 2021 11:52:24 PDT Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D594C061574 for ; Mon, 12 Apr 2021 11:52:24 -0700 (PDT) Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 7CB5B804E7; Mon, 12 Apr 2021 20:44:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1618253059; bh=xMG6BTUE5ZgzzqLZvUnx6xiOQaciyho/Imrz9gX7Bk8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=r37IU84yI5jkSJ+xCmUJimctQUJzDrTgi5g2Y2qLI42bd+PU8XIvCTaQ6nXr0elCz Ii5U8zH9qDZWRyfPGuy3dwWqMDa5jV82lIu0VDY5SiIGWOL/LYnGf3DPFONrOFLBng 7Vd+8oPmbPlqavDxTDCnsW4MoO8mLHdouTlDl++HNd+dlUMmR/X7hM5xjdi1hKK3VI szDzgXfAAa3PJ+4hTOOlCg4oLBoSamaYc5wGRAv0NL7gv5O90eFmUHUwouczU7xuCT 6y1jO+FdwLgsHIYmdSnYrpU5G61blUJ0fl5D5AryaxkSPzCmzeY/gIswlAHwvjf6sn AQNgekXEek82g== Subject: Re: [PATCH 0/7] ARM: dts: stm32: clk: Switch ETHRX clock parent from ETHCK_K to MCO2 on DHCOM SoM To: Alexandre TORGUE , linux-arm-kernel@lists.infradead.org Cc: Christophe Roullier , Gabriel Fernandez , Patrice Chotard , Patrick Delaunay , Stephen Boyd , linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Stephen Boyd References: <20210408185731.135511-1-marex@denx.de> From: Marek Vasut Message-ID: <2c410c1b-2a1d-b291-a128-c5d5979be1ef@denx.de> Date: Mon, 12 Apr 2021 20:44:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 4/12/21 10:09 AM, Alexandre TORGUE wrote: > Hi Marek Hello Alex, [...] >> All the above still only discusses the clock part of the problem. Even if >> the clock cyclic dependencies could be solved, it would be necessary to >> resolve legacy dwmac st,eth-clk-sel and st,eth-ref-clk-sel DT properties >> and avoid DT ABI break. > > Thanks for those clear explanations and for this series. As discussed, > this approach looks good to me as it doesn't break our current strategy > for dwmac clock integration. I don't know if those cyclic redundancies > will be fixed one day but we can have a look on dwmac DT properties (the > gain to change them, the effort to keep the backward compatibility, code > readability, ...). > > Your DT patches looks good. I'll merge them soon. +CC Stephen ; the DT patches depend on the clock driver changes. Would it make sense to pick the clock patches through the same tree or how should that be handled ? [...] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_NONE,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E29B9C433ED for ; Mon, 12 Apr 2021 18:46:04 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77BB361246 for ; Mon, 12 Apr 2021 18:46:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77BB361246 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F8nl0tMovB4eG1VJOGGxnncz8hfnwcUIxS4wy/zgQSE=; b=QVzQlR+kpN3LN/htmD84ODizg KJWbSygW+9Aw781n3OdM/X7PaT1Jn3e1N/O5c35QvCaPcK9IkY2twe/ufoUF0qhBq1iEcbJWNs0JF 9zG2CJiA3eQthlqF0wG7lFpVa6A2Cf01x9//pYWOGyPm34fH2utTbZQF/dRAqmuQJx9UFKN5Auege xhkI4RT9Fz/P6BHuStwlGp5nP4mC6BVi24XQ/yBwGwaKvQoX5BZY8dr7oD8HJWjX6RoS/v+bECE1P l7H+d1y7cQIZo4mFZcJFokokB7rHBXGJ2y2UF6PHHPwxz/OPUE1+bbHVqwA4Ad0alSsSCK+5ntdXU PqbHRB1Wg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lW1Xw-007Tmb-NT; Mon, 12 Apr 2021 18:44:28 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lW1Xt-007TmS-G2 for linux-arm-kernel@desiato.infradead.org; Mon, 12 Apr 2021 18:44:25 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=xMG6BTUE5ZgzzqLZvUnx6xiOQaciyho/Imrz9gX7Bk8=; b=yJ1jO+ZQmqPkTH2QSjFTfNcAUe 90Qpvi3trBZzPGeoBgh3+SygXFASG6TTCUJvpBpWuOSkFhgU+gg2VhP4RjHl8THyKzRIPsXc9ygOz q11aV2a0NQlW3/Z2432Yhl62EDbO0gVw91pQOM0phqas4uDVPnpfflVYzTEdWy1pA85qX4KHQKd5m 916aPI8OBdqMA/rRsO6xo9ZisXnumHdaPgBuC+B6d4Q+CE0+mL4sJa8pgytN0PkYMBNEetJmIj0Pu NJbuvxQ5d+N+Oj9kYBSz2NmaDIPruaLE+sXC/cubm2FpkeBw1d/FolvVVeJL+pXtBoWLGy51YHwCs MZiQ1Zxg==; Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lW1Xq-006UUh-G4 for linux-arm-kernel@lists.infradead.org; Mon, 12 Apr 2021 18:44:24 +0000 Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 7CB5B804E7; Mon, 12 Apr 2021 20:44:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1618253059; bh=xMG6BTUE5ZgzzqLZvUnx6xiOQaciyho/Imrz9gX7Bk8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=r37IU84yI5jkSJ+xCmUJimctQUJzDrTgi5g2Y2qLI42bd+PU8XIvCTaQ6nXr0elCz Ii5U8zH9qDZWRyfPGuy3dwWqMDa5jV82lIu0VDY5SiIGWOL/LYnGf3DPFONrOFLBng 7Vd+8oPmbPlqavDxTDCnsW4MoO8mLHdouTlDl++HNd+dlUMmR/X7hM5xjdi1hKK3VI szDzgXfAAa3PJ+4hTOOlCg4oLBoSamaYc5wGRAv0NL7gv5O90eFmUHUwouczU7xuCT 6y1jO+FdwLgsHIYmdSnYrpU5G61blUJ0fl5D5AryaxkSPzCmzeY/gIswlAHwvjf6sn AQNgekXEek82g== Subject: Re: [PATCH 0/7] ARM: dts: stm32: clk: Switch ETHRX clock parent from ETHCK_K to MCO2 on DHCOM SoM To: Alexandre TORGUE , linux-arm-kernel@lists.infradead.org Cc: Christophe Roullier , Gabriel Fernandez , Patrice Chotard , Patrick Delaunay , Stephen Boyd , linux-clk@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Stephen Boyd References: <20210408185731.135511-1-marex@denx.de> From: Marek Vasut Message-ID: <2c410c1b-2a1d-b291-a128-c5d5979be1ef@denx.de> Date: Mon, 12 Apr 2021 20:44:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Virus-Scanned: clamav-milter 0.102.4 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210412_114422_893778_99CF76BA X-CRM114-Status: GOOD ( 16.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/12/21 10:09 AM, Alexandre TORGUE wrote: > Hi Marek Hello Alex, [...] >> All the above still only discusses the clock part of the problem. Even if >> the clock cyclic dependencies could be solved, it would be necessary to >> resolve legacy dwmac st,eth-clk-sel and st,eth-ref-clk-sel DT properties >> and avoid DT ABI break. > > Thanks for those clear explanations and for this series. As discussed, > this approach looks good to me as it doesn't break our current strategy > for dwmac clock integration. I don't know if those cyclic redundancies > will be fixed one day but we can have a look on dwmac DT properties (the > gain to change them, the effort to keep the backward compatibility, code > readability, ...). > > Your DT patches looks good. I'll merge them soon. +CC Stephen ; the DT patches depend on the clock driver changes. Would it make sense to pick the clock patches through the same tree or how should that be handled ? [...] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel