From: Richard Henderson <richard.henderson@linaro.org>
To: Idan Horowitz <idan.horowitz@gmail.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com
Subject: Re: [PATCH 1/2] softmmu/cpus: Check if the cpu work list is empty atomically
Date: Thu, 27 Jan 2022 08:40:44 +1100 [thread overview]
Message-ID: <2c467b27-2471-2f54-b9ce-3282190378e9@linaro.org> (raw)
In-Reply-To: <20220114004358.299534-1-idan.horowitz@gmail.com>
On 1/14/22 11:43 AM, Idan Horowitz wrote:
> Instead of taking the lock of the cpu work list in order to check if it's
> empty, we can just read the head pointer atomically. This decreases
> cpu_work_list_empty's share from 5% to 1.3% in a profile of icount-enabled
> aarch64-softmmu.
>
> Signed-off-by: Idan Horowitz<idan.horowitz@gmail.com>
> ---
> softmmu/cpus.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Queued to tcg-next.
r~
prev parent reply other threads:[~2022-01-26 21:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 0:43 [PATCH 1/2] softmmu/cpus: Check if the cpu work list is empty atomically Idan Horowitz
2022-01-14 0:43 ` [PATCH 2/2] qemu-timer: Skip empty timer lists before locking in qemu_clock_deadline_ns_all Idan Horowitz
2022-01-26 21:43 ` Richard Henderson
2022-06-19 8:54 ` Idan Horowitz
2022-06-21 16:25 ` Richard Henderson
2022-01-26 21:40 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c467b27-2471-2f54-b9ce-3282190378e9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=idan.horowitz@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.