From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from matoro.tk (matoro.tk [104.188.251.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C1E73232 for ; Fri, 5 Aug 2022 23:54:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=J8J6PPB5B9eM7a3M73is6IRjHMAiGebZrLZRQe+1Ff0=; c=relaxed/relaxed; d=matoro.tk; h=Subject:Subject:Sender:To:To:Cc:Cc:From:From:Date:Date:MIME-Version:MIME-Version:Content-Type:Content-Type:Content-Transfer-Encoding:Content-Transfer-Encoding:Reply-To:In-Reply-To:In-Reply-To:Message-Id:Message-Id:References:References:Autocrypt:Openpgp; i=@matoro.tk; s=20220801; t=1659741627; v=1; x=1660173627; b=g5XrCDNUzsVAjAjZFsZjYZ24S9aLRq7h/3KSaEGcnBcDDqaRK+RSYwnaAY90FpzwxVaQF1NF 3MNa0IT70NknLcM1JlhzVaAvQ+T5FBHftTYXNPo4hgTx0R4UhKsKuCKHtlDfIrMx0qroqwzkrIt 5lYn0OTCxgw9jmpERilnPHUEtyNv+qrNEGNGMyeI6gJ70td5TRT9RGCTDtcQ2E2ynutTu8f+QZy 325oIMukW3iVu4swvQWbAfnHhPDMXBfw0p4VEurlJcPV4c+kgK6s2DXoCoGjYhXQ2oQEEzqG2dn +ewxJ9nfIXrleZivMz1tTsf4ESkGszpDSOmZwrlReRj5erU0nycGsjb+Uz+iGJG+1XyjtYiwYzG Oi3DGEclNrMEVTK+9LVsmZCrlDpLHxM9hxB0z+5YormW9a6TcAm6aQJbUiSNSBmVNio7UbtJ8NM vVvqS/VxfeR7kEzvghlzoRsApdAt4BUZqLt9sdJLg/uoQ1gGs9W+/Ve9qO5bXt15gGdLqS6t8Iz TezdH1KfzS7jZkbq+1+HLY1ujy8PLBYPz+mWB1zX6OpS2OfY0IU7uLdqojRK5CIO9IMaJ8saIUx HdIKZ+wnH/t556N4AH1FiEvdcRzzRzBLJM4dFqYf6bicPLvHbuIZ4LZWDTEyHA/eE1ESVmLp+mX ywkEoUfpnsE= Received: by matoro.tk (envelope-sender ) with ESMTPS id 8629941e; Fri, 05 Aug 2022 19:20:27 -0400 Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Fri, 05 Aug 2022 19:20:27 -0400 From: matoro To: Masahiro Yamada Cc: Linux Kbuild mailing list , Linux Kernel Mailing List , Nathan Chancellor , Nick Desaulniers , Nicolas Schier , Peter Zijlstra , linux-modules , clang-built-linux , Ard Biesheuvel , Sami Tolvanen Subject: Re: [PATCH v6 00/10] kbuild: yet another series of cleanups (modpost, LTO, MODULE_REL_CRCS, export.h) In-Reply-To: References: <20220513113930.10488-1-masahiroy@kernel.org> Message-ID: <2c496d24174e63b27ec047f383df6700@matoro.tk> X-Sender: matoro_mailinglist_kernel@matoro.tk Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Hi Masahiro, I'm sorry to raise this after release but this seems to be broken on SOME architectures. So far I have tested: Affected - sparc, alpha Unaffected - riscv, ia64 The affected systems are unable to load modules, similar to the previously reported issue. All module loading fails with "disagrees about version of symbol module_layout". Bisect blames 7b4537199a4a8480b8c3ba37a2d44765ce76cd9b, but this does not revert cleanly. Presumably CONFIG_MODVERSIONS=n would fix, but this is a pretty core feature. Unlike the issue Sedat reported, this is on a GNU toolchain, no clang involved. Here are the configs I am using (with make olddefconfig on upgrade to 5.19): Broken - sparc - https://dpaste.com/5A8F2JD6U Broken - alpha - https://dpaste.com/FYKK23L9X Working - riscv - https://dpaste.com/HV6Y4V6NT Working - ia64 - https://dpaste.com/HDLDNEAK4 Please let me know if there's anything I can do to help track down this regression. -------- Original Message -------- Subject: Re: [PATCH v6 00/10] kbuild: yet another series of cleanups (modpost, LTO, MODULE_REL_CRCS, export.h) Date: 2022-05-13 08:20 From: Masahiro Yamada To: Linux Kbuild mailing list On Fri, May 13, 2022 at 8:42 PM Masahiro Yamada wrote: > > > This is the third batch of cleanups in this development cycle. > This series is available at git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git lto-cleanup-v6 > > Changes in v6: > - Fix false-positive warnings when CONFIG_TRIM_UNUSED_KSYMS=y > > Changes in v5: > - Fix the build error when CONFIG_DEBUG_INFO_BTF=y (reported by > Nathan) > - Clean up arch/m68k/include/asm/export.h (Nick) > - Keep gen_symversions (and will be removed by a later patch) > - Add more comments in the script > > Changes in v4: > - Rename .vmlinux-symver.c to .vmlinux.export.c > because I notice this approach is useful for further cleanups, > not only for modversioning but also for overall EXPORT_SYMBOL. > - New patch > - New. > Resent of my previous submission. > > https://lore.kernel.org/all/20210831074004.3195284-10-masahiroy@kernel.org/ > - New > Resent of my previous submission > > https://lore.kernel.org/linux-kbuild/20210831074004.3195284-11-masahiroy@kernel.org/ > > Changes in v3: > - New patch > > Changes in v2: > - Simplify the implementation (parse .cmd files after ELF) > - New patch > - replace the chain of $(if ...) with $(and ) > - New patch > - New patch > > Masahiro Yamada (10): > modpost: extract symbol versions from *.cmd files > kbuild: link symbol CRCs at final link, removing > CONFIG_MODULE_REL_CRCS > kbuild: stop merging *.symversions > genksyms: adjust the output format to modpost > kbuild: do not create *.prelink.o for Clang LTO or IBT > kbuild: check static EXPORT_SYMBOL* by script instead of modpost > kbuild: make built-in.a rule robust against too long argument error > kbuild: make *.mod rule robust against too long argument error > kbuild: add cmd_and_savecmd macro > kbuild: rebuild multi-object modules when objtool is updated > > arch/m68k/include/asm/Kbuild | 1 + > arch/m68k/include/asm/export.h | 2 - > arch/powerpc/Kconfig | 1 - > arch/s390/Kconfig | 1 - > arch/um/Kconfig | 1 - > include/asm-generic/export.h | 22 ++- > include/linux/export-internal.h | 16 +++ > include/linux/export.h | 30 ++-- > init/Kconfig | 4 - > kernel/module.c | 10 +- > scripts/Kbuild.include | 10 +- > scripts/Makefile.build | 134 ++++++------------ > scripts/Makefile.lib | 7 - > scripts/Makefile.modfinal | 5 +- > scripts/Makefile.modpost | 9 +- > scripts/check-local-export | 64 +++++++++ > scripts/genksyms/genksyms.c | 18 +-- > scripts/link-vmlinux.sh | 33 ++--- > scripts/mod/modpost.c | 236 +++++++++++++++++++++----------- > 19 files changed, 320 insertions(+), 284 deletions(-) > delete mode 100644 arch/m68k/include/asm/export.h > create mode 100644 include/linux/export-internal.h > create mode 100755 scripts/check-local-export > > -- > 2.32.0 >