From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3D74C433EF for ; Thu, 2 Dec 2021 05:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oDyYFaFNr7g0j9fQnWgIr84Jen7AbN8r0UEPO8wLDpc=; b=Aavpu3YSub7pco2mFI6pTpc9lD a2EUTGSajVNFkJ5CZp5b8XaphobgiOBqi4rQxPE8r6JwZUJ7PBDTG0hHU0teKT0aXZNUgWLzZoaQ2 c2FPA6+YNO6gun+7cPhwaEgRLGwqgxZMl7mzMsi/YX6f3VkfoeQrQrHuV85AE5dROcBsk3dLa7piT bVyL9FpqrU1OpCkwl8CUO4rDk74HLfjl6sFQ0LBBu/we4cwZYV1NJUqxiphiKWXtxTZZTYEbYJsNN wg2zuc//7MTvXtiCtG2asXq2VrrR8Ucew+XnTFBaA0daHWzVwUcELsxNKi+MAc42YMZzxIP0jhIeo pn6TF5GA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mseZN-00Axe8-Pg; Thu, 02 Dec 2021 05:23:45 +0000 Received: from marcansoft.com ([2a01:298:fe:f::2] helo=mail.marcansoft.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mseZJ-00Axdh-JB for linux-arm-kernel@lists.infradead.org; Thu, 02 Dec 2021 05:23:43 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id DD8B741F28; Thu, 2 Dec 2021 05:23:38 +0000 (UTC) Subject: Re: [PATCH] irqchip/apple-aic: Fix annotation To: Donghyeok Kim Cc: linux-arm-kernel@lists.infradead.org References: <20211123161655.2943-1-dthex5d@gmail.com> From: Hector Martin Message-ID: <2c583fc9-e16c-6223-0a4a-f4f7e4954776@marcan.st> Date: Thu, 2 Dec 2021 14:23:36 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211123161655.2943-1-dthex5d@gmail.com> Content-Language: es-ES X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_212341_839614_470BA9C4 X-CRM114-Status: GOOD ( 17.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 24/11/2021 01.16, Donghyeok Kim wrote: > Annotate aic_init_smp() as __init > > Signed-off-by: Donghyeok Kim > --- > drivers/irqchip/irq-apple-aic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-apple-aic.c b/drivers/irqchip/irq-apple-aic.c > index 3759dc36cc8f..2543ef65825b 100644 > --- a/drivers/irqchip/irq-apple-aic.c > +++ b/drivers/irqchip/irq-apple-aic.c > @@ -707,7 +707,7 @@ static const struct irq_domain_ops aic_ipi_domain_ops = { > .free = aic_ipi_free, > }; > > -static int aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node) > +static int __init aic_init_smp(struct aic_irq_chip *irqc, struct device_node *node) > { > struct irq_domain *ipi_domain; > int base_ipi; > This looks fine, but can you use a more descriptive commit message? Something like: == irqchip/apple-aic: Mark aic_init_smp() as __init This function is only called from the driver init code. == Thanks, -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel