From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47E6B46A1 for ; Fri, 25 Mar 2022 07:16:44 +0000 (UTC) Received: by mail-ej1-f50.google.com with SMTP id bg10so13592305ejb.4 for ; Fri, 25 Mar 2022 00:16:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=6YHRcsHOFCm3E4C9FykKyoJxe7PYRENyIsb3tXOaP5I=; b=MJ7AY+PpZLP6wcI+djrFmEcl7GcnaK1295f3AIjMtxbte2BZiOGkbTYaqo760Cbnus pnBRVWqvYZr59Fukw5G6s9b1de0UQ7sX3zg1fhojr4LecvGoOx3cD+ujKJ54g2DwnQaz fgV7Ey9+PEz05xoflx5mJl9BAQ+eFa3OJSIY2/ZmIPQi09QT3Hca88/R1a83MNULETeV ykuelv7v4tCR2Czq0ZC5YCsXyHOQTtTq+ssWViUp3Sc72kscqK3QhDfzvblqW+j5miUj Z7GNSes/8QYnnGyaRg0eBbTZI+4kJV1n+HldD9GenkQqv8bKi503QCStw6u7G9hT+jBD cQ9Q== X-Gm-Message-State: AOAM533vJgzbrYBAxHG7uUH7BmYtBYgzgCbFxSFUOdtel75IxjX2oqYx 2bPaJ9d2l5jZk/xPbKR1Law= X-Google-Smtp-Source: ABdhPJzPzXLNwxYfju2wh9vwGi8cPlhGKuDBZCqBi7gSMRDLYWMBkqfgbdWQbnsDEtFpPc5+JuVk0A== X-Received: by 2002:a17:907:1b20:b0:6da:649b:d99e with SMTP id mp32-20020a1709071b2000b006da649bd99emr9906155ejc.712.1648192602385; Fri, 25 Mar 2022 00:16:42 -0700 (PDT) Received: from [192.168.0.158] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.googlemail.com with ESMTPSA id ga5-20020a1709070c0500b006de43e9605asm2015052ejc.181.2022.03.25.00.16.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Mar 2022 00:16:41 -0700 (PDT) Message-ID: <2c6b873f-a971-e79a-6a32-f101bda46e93@kernel.org> Date: Fri, 25 Mar 2022 08:16:40 +0100 Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 1/2] dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711 Content-Language: en-US From: Krzysztof Kozlowski To: Adrien Thierry , linux-kernel@vger.kernel.org Cc: Rob Herring , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Stefan Wahren , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Gaston Gonzalez , Ojaswin Mujoo , linux-staging@lists.linux.dev References: <20220324172647.167617-1-athierry@redhat.com> <20220324172647.167617-2-athierry@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 24/03/2022 19:47, Krzysztof Kozlowski wrote: > On 24/03/2022 18:26, Adrien Thierry wrote: >> Add a new compatible string for BCM2711. This is the chip used on the >> Raspberry Pi 4. >> >> Signed-off-by: Adrien Thierry >> --- >> Changes since v1: >> - Removed duplicate compatible string for bcm2711 >> >> .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml >> index e04439b3355b..9cb957facae0 100644 >> --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml >> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml >> @@ -27,6 +27,11 @@ properties: >> - brcm,bcm2836-vchiq >> - const: brcm,bcm2835-vchiq >> >> + - description: BCM2711 based boards >> + items: >> + - enum: >> + - brcm,bcm2711-vchiq > > This oneOf here - just to add description which is copy-paste of > compatible - does not make sense. It should be just enum with > compatibles. At least for 2711 and 2835 (and put them in alphabetical > order). Actually, judging by your driver and DTS, it seems that this should be list of items bcm2711 followed by bcm2836. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65349C433EF for ; Fri, 25 Mar 2022 07:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:References:Cc:To:From: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cHQ93f/2pQqfF4qQgzC2SGBi3/VngRme13GSj5O+1yY=; b=3kKr5l7Wetvw/Z 1Kx9DedMmHCNxi39u7sYSL5WZGjkWLsNh7lxTjmkWX1CYhLn5LbYwho1uA4uZE8LzfQljLAb1hLFX wIg2+LHOPX6mwAmxf5cWG1TPTagq9zV8W2CeNhtsI3unrk+2GXvFk4Z/gUZRkVni5yYmFk/nC8O7g 4YwgWKbcjEzl2mpo1ii2PbAIJN/2N3EOxQWBUSemQvmhrL4sZUMB4IEXokUuxiYXiBeCxajqsEiSO zlFiZJLVk0t6Xyg6RaZVGhA1noDRbfI4HPAQKP/IxG5bxyqm5zyy/kDA1vInCDfKxydEbeO2EuQyD NT2F4x5+KjQLbDzYN6+w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXeBj-001K47-Qu; Fri, 25 Mar 2022 07:16:47 +0000 Received: from mail-ej1-f52.google.com ([209.85.218.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXeBg-001K3R-0V; Fri, 25 Mar 2022 07:16:45 +0000 Received: by mail-ej1-f52.google.com with SMTP id pv16so13652298ejb.0; Fri, 25 Mar 2022 00:16:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=6YHRcsHOFCm3E4C9FykKyoJxe7PYRENyIsb3tXOaP5I=; b=oq4fjUQGZOQz55GoA8x7JgWUYMNkYn2XUkvHfsZHo6htHceTPx/CZdsjXuHo+isIFL Ic+MqDmRGyRcZ3VWzzg4t9PIkRH0bWHXCQUapOpUSju2KOGRFjEzCaS+E2D2C32gDeTj c2VyWn2pXJQgLUCcvapFjDWgNTPRVVeCwsgUryP2fziPNqZS50YtQt0uBzqSMo/FlmLB 5i5kUKuUcgvBGNkaFA9I60HjiJDKPUwi1sTo6rrUgADE+xkW6Y+7biHh9epdlCxbKWav 1HeJHiEMPHalK4Lstn4//18hSIfH0yvC9wVFSSKh5DYHilvothxjioFhJvRcvmV+Flfh hcmA== X-Gm-Message-State: AOAM530E2p/jCVd6LvOi5Y+ecCejtmuHLsoTBNBJpP25o4U0jXSJNaDo ToihtGA68fn+BdfnXuseljXhknJ0qsQ= X-Google-Smtp-Source: ABdhPJzPzXLNwxYfju2wh9vwGi8cPlhGKuDBZCqBi7gSMRDLYWMBkqfgbdWQbnsDEtFpPc5+JuVk0A== X-Received: by 2002:a17:907:1b20:b0:6da:649b:d99e with SMTP id mp32-20020a1709071b2000b006da649bd99emr9906155ejc.712.1648192602385; Fri, 25 Mar 2022 00:16:42 -0700 (PDT) Received: from [192.168.0.158] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.googlemail.com with ESMTPSA id ga5-20020a1709070c0500b006de43e9605asm2015052ejc.181.2022.03.25.00.16.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Mar 2022 00:16:41 -0700 (PDT) Message-ID: <2c6b873f-a971-e79a-6a32-f101bda46e93@kernel.org> Date: Fri, 25 Mar 2022 08:16:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 1/2] dt-bindings: soc: bcm: bcm2835-vchiq: Add support for bcm2711 Content-Language: en-US From: Krzysztof Kozlowski To: Adrien Thierry , linux-kernel@vger.kernel.org Cc: Rob Herring , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Stefan Wahren , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Gaston Gonzalez , Ojaswin Mujoo , linux-staging@lists.linux.dev References: <20220324172647.167617-1-athierry@redhat.com> <20220324172647.167617-2-athierry@redhat.com> In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220325_001644_085796_03495482 X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/03/2022 19:47, Krzysztof Kozlowski wrote: > On 24/03/2022 18:26, Adrien Thierry wrote: >> Add a new compatible string for BCM2711. This is the chip used on the >> Raspberry Pi 4. >> >> Signed-off-by: Adrien Thierry >> --- >> Changes since v1: >> - Removed duplicate compatible string for bcm2711 >> >> .../devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml >> index e04439b3355b..9cb957facae0 100644 >> --- a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml >> +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm2835-vchiq.yaml >> @@ -27,6 +27,11 @@ properties: >> - brcm,bcm2836-vchiq >> - const: brcm,bcm2835-vchiq >> >> + - description: BCM2711 based boards >> + items: >> + - enum: >> + - brcm,bcm2711-vchiq > > This oneOf here - just to add description which is copy-paste of > compatible - does not make sense. It should be just enum with > compatibles. At least for 2711 and 2835 (and put them in alphabetical > order). Actually, judging by your driver and DTS, it seems that this should be list of items bcm2711 followed by bcm2836. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel