From: Larry Finger <Larry.Finger@lwfinger.net>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Jiri Kosina <trivial@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Chaoming Li <chaoming_li@realsil.com.cn>,
netdev@vger.kernel.org
Subject: Re: [PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling s/wrtie_addr/write_addr/
Date: Fri, 17 Feb 2017 10:14:44 -0600 [thread overview]
Message-ID: <2c7a3011-3418-35a5-ca2e-88c0188baccf@lwfinger.net> (raw)
In-Reply-To: <1487345799-1638-2-git-send-email-geert+renesas@glider.be>
On 02/17/2017 09:36 AM, Geert Uytterhoeven wrote:
> As per symmetry with _rtl8821ae_dbi_read(), "wrtie" is not a funky
> register acronym, but a simple misspelling of "write".
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Cc: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Chaoming Li <chaoming_li@realsil.com.cn>
> Cc: netdev@vger.kernel.org
I'm not sure that it is possible to have a typo in a variable name. That seems
to be within an author's prerogative. Nonetheless, the patch is OK other than it
was sent to the wrong destination. Patches for this driver should go through
linux-wireless@vger.kernel.org. Kalle Valo is the wireless maintainer, but it is
not necessary to send to him directly as he usually picks up the patches from
Patchwork.
Larry
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> index 4f83eee1ff75bc81..546f085afb8f42fa 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c
> @@ -1135,13 +1135,13 @@ static u8 _rtl8821ae_dbi_read(struct rtl_priv *rtlpriv, u16 addr)
> static void _rtl8821ae_dbi_write(struct rtl_priv *rtlpriv, u16 addr, u8 data)
> {
> u8 tmp = 0, count = 0;
> - u16 wrtie_addr, remainder = addr % 4;
> + u16 write_addr, remainder = addr % 4;
>
> - wrtie_addr = REG_DBI_WDATA + remainder;
> - rtl_write_byte(rtlpriv, wrtie_addr, data);
> + write_addr = REG_DBI_WDATA + remainder;
> + rtl_write_byte(rtlpriv, write_addr, data);
>
> - wrtie_addr = (addr & 0xfffc) | (BIT(0) << (remainder + 12));
> - rtl_write_word(rtlpriv, REG_DBI_ADDR, wrtie_addr);
> + write_addr = (addr & 0xfffc) | (BIT(0) << (remainder + 12));
> + rtl_write_word(rtlpriv, REG_DBI_ADDR, write_addr);
>
> rtl_write_byte(rtlpriv, REG_DBI_FLAG, 0x1);
>
>
next prev parent reply other threads:[~2017-02-17 16:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 15:36 [PATCH trivial 1/4] HID: picoLCD: Spelling s/REPORT_WRTIE_MEMORY/REPORT_WRITE_MEMORY/ Geert Uytterhoeven
2017-02-17 15:36 ` [PATCH trivial 2/4] rtlwifi: rtl8821ae: Spelling s/wrtie_addr/write_addr/ Geert Uytterhoeven
2017-02-17 16:14 ` Larry Finger [this message]
2017-02-17 16:19 ` Geert Uytterhoeven
2017-02-17 16:42 ` Larry Finger
2017-02-17 15:36 ` [PATCH trivial 3/4] drm/amd: Spelling s/SDMA_WRTIE_SUB_OPCODE_TILED/SDMA_WRITE_SUB_OPCODE_TILED/ Geert Uytterhoeven
2017-02-18 9:17 ` Christian König
2017-02-18 9:17 ` Christian König
2017-02-23 14:36 ` Alex Deucher
2017-02-23 14:36 ` Alex Deucher
2017-02-17 15:36 ` [PATCH trivial 4/4] PM / Documentation: Spelling s/wrtie/write/ Geert Uytterhoeven
2017-02-18 1:19 ` Rafael J. Wysocki
2017-02-18 9:24 ` [PATCH trivial 1/4] HID: picoLCD: Spelling s/REPORT_WRTIE_MEMORY/REPORT_WRITE_MEMORY/ Bruno Prémont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c7a3011-3418-35a5-ca2e-88c0188baccf@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=chaoming_li@realsil.com.cn \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.