From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: Re: [PATCH 3/4] net: macb: Support specifying PHYs in a mdio
 container dts node
Date: Mon, 20 Aug 2018 15:45:30 +0200
Message-ID: <2c7d7e81-322d-c995-7de6-64a25906d280@pengutronix.de>
References: <20180820121238.7779-1-a.fatoum@pengutronix.de>
 <20180820121238.7779-3-a.fatoum@pengutronix.de>
 <20180820134234.GC6583@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "David S. Miller" <davem@davemloft.net>,
        Nicolas Ferre <nicolas.ferre@microchip.com>,
        kernel@pengutronix.de, netdev@vger.kernel.org, mdf@kernel.org,
        Brad Mouring <brad.mouring@ni.com>,
        Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Return-path: <netdev-owner@vger.kernel.org>
Received: from metis.ext.pengutronix.de ([85.220.165.71]:50641 "EHLO
        metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726683AbeHTRBT (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 20 Aug 2018 13:01:19 -0400
In-Reply-To: <20180820134234.GC6583@lunn.ch>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 08/20/2018 03:42 PM, Andrew Lunn wrote:
> On Mon, Aug 20, 2018 at 02:12:37PM +0200, Ahmad Fatoum wrote:
> This is correct. But i would prefer the more readable
> 
> 		struct device_node *node = of_get_child_by_name(np, "mdio");
> 
> 		if (!node)
>    			/* Allow for the deprecated PHYs in the MAC node. */
>    			node = np;
> 
>>  		if (pdata)
>>  			bp->mii_bus->phy_mask = pdata->phy_mask;
>> -
>> -		err = of_mdiobus_register(bp->mii_bus, np);
>> +		err = of_mdiobus_register(bp->mii_bus, node);
>>  	}

Ok.

> Also, the device tree binding documentation needs updating.

I've done so in part 4/4.