From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A135C4338F for ; Tue, 24 Aug 2021 16:51:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6509F610F7 for ; Tue, 24 Aug 2021 16:51:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6509F610F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NyoNFDsIcOybbvv5935rKO54u5XYDv0F2oWBiZc+Dy0=; b=ROSIHNFToDMD/LzzWG3/wBAvB9 yP8RO6C1uYBJQORwh8yB93VOZveL3lZITCiIusTT8JWhVVOecfu79xRSct1/mTA8+gT6i9BqSIr9S oZjla8HpP2PH9HC3RM7rByMzWBVK73RTMABJtgR9vtq9/eGyNmwwlxhyeTCA3rYmiHCP8dnTtpkPd MOC0kx2egk0iaNeUXSPlS6IngJU0ujJEc0fNQ1TfK+j/kRVbsq1ZavB51HE01Q/WegLkQRaJPPobU wCGxThFuMd9L2BZ21RSl2TZE6OysDcqK7MbN/UK0WLtdM2z5Csr8aFkJ8zqEa8gHnu3E/Kk8UwA3M SPpV5Vvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIZcm-00402p-Jv; Tue, 24 Aug 2021 16:50:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIZci-00401V-IC for linux-arm-kernel@lists.infradead.org; Tue, 24 Aug 2021 16:50:06 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0633331B; Tue, 24 Aug 2021 09:50:02 -0700 (PDT) Received: from [10.1.30.13] (e110479.cambridge.arm.com [10.1.30.13]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0D4703F766; Tue, 24 Aug 2021 09:50:00 -0700 (PDT) Subject: Re: [boot-wrapper PATCH 1/5] Remove unused Set/Way cache helpers To: Mark Rutland , linux-arm-kernel@lists.infradead.org Cc: alexandru.elisei@arm.com, maz@kernel.org References: <20210824134900.34849-1-mark.rutland@arm.com> <20210824134900.34849-2-mark.rutland@arm.com> From: Andre Przywara Message-ID: <2c7e6afe-e54c-c716-61c2-08facf4190ab@arm.com> Date: Tue, 24 Aug 2021 17:49:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210824134900.34849-2-mark.rutland@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210824_095004_710297_B3F227A7 X-CRM114-Status: GOOD ( 15.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/24/21 2:48 PM, Mark Rutland wrote: > We removed the Set/Way cache maintenance in commit: > > 864182b26c20a39d ("Remove cache maintenance") > > ... but forgot to remove the arch helpers which are now unused. > > Remove the unused helpers. Indeed, no users in the tree. > Signed-off-by: Mark Rutland Reviewed-by: Andre Przywara Thanks, Andre > --- > arch/aarch32/include/asm/cpu.h | 26 -------------------------- > arch/aarch64/include/asm/cpu.h | 26 -------------------------- > 2 files changed, 52 deletions(-) > > diff --git a/arch/aarch32/include/asm/cpu.h b/arch/aarch32/include/asm/cpu.h > index 878be67..a7993f0 100644 > --- a/arch/aarch32/include/asm/cpu.h > +++ b/arch/aarch32/include/asm/cpu.h > @@ -56,32 +56,6 @@ static inline uint32_t read_id_pfr1(void) > return val; > } > > -static inline uint32_t read_clidr(void) > -{ > - uint32_t val; > - > - asm volatile ("mrc p15, 1, %0, c0, c0, 1" : "=r" (val)); > - return val; > -} > - > -static inline uint32_t read_ccsidr(void) > -{ > - uint32_t val; > - > - asm volatile ("mrc p15, 1, %0, c0, c0, 0" : "=r" (val)); > - return val; > -} > - > -static inline void write_csselr(uint32_t val) > -{ > - asm volatile ("mcr p15, 2, %0, c0, c0, 0" : : "r" (val)); > -} > - > -static inline void dccisw(uint32_t val) > -{ > - asm volatile ("mcr p15, 0, %0, c7, c14, 2" : : "r" (val)); > -} > - > static inline void iciallu(void) > { > uint32_t val = 0; > diff --git a/arch/aarch64/include/asm/cpu.h b/arch/aarch64/include/asm/cpu.h > index ccb5397..1cddbb8 100644 > --- a/arch/aarch64/include/asm/cpu.h > +++ b/arch/aarch64/include/asm/cpu.h > @@ -66,32 +66,6 @@ static inline uint64_t read_id_aa64pfr0(void) > return val; > } > > -static inline uint32_t read_clidr(void) > -{ > - uint32_t val; > - > - asm volatile ("mrs %0, clidr_el1" : "=r" (val)); > - return val; > -} > - > -static inline uint32_t read_ccsidr(void) > -{ > - uint32_t val; > - > - asm volatile ("mrs %0, ccsidr_el1" : "=r" (val)); > - return val; > -} > - > -static inline void write_csselr(uint32_t val) > -{ > - asm volatile ("msr csselr_el1, %0" : : "r" (val)); > -} > - > -static inline void dccisw(uint32_t val) > -{ > - asm volatile ("dc cisw, %0" : : "r" (val)); > -} > - > static inline void iciallu(void) > { > asm volatile ("ic iallu"); > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel