From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [PATCH] target/arm: Remove obsolete TODO note from get_phys_addr_lpae()
Date: Tue, 31 Mar 2020 09:06:18 -0700 [thread overview]
Message-ID: <2c8317b5-68ca-c8b9-c6d7-917dc9bca526@linaro.org> (raw)
In-Reply-To: <20200331143407.3186-1-peter.maydell@linaro.org>
On 3/31/20 7:34 AM, Peter Maydell wrote:
> An old comment in get_phys_addr_lpae() claims that the code does not
> support the different format TCR for VTCR_EL2. This used to be true
> but it is not true now (in particular the aa64_va_parameters() and
> aa32_va_parameters() functions correctly handle the different
> register format by checking whether the mmu_idx is Stage2).
> Remove the out of date parts of the comment.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Randomly noticed this out of date comment while I was stepping
> through the code this afternoon...
>
> target/arm/helper.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2020-03-31 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 14:34 [PATCH] target/arm: Remove obsolete TODO note from get_phys_addr_lpae() Peter Maydell
2020-03-31 16:06 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c8317b5-68ca-c8b9-c6d7-917dc9bca526@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.