From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8913671 for ; Mon, 10 May 2021 01:54:41 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id E874C148D; Sun, 9 May 2021 21:54:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 09 May 2021 21:54:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= to:cc:references:from:subject:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm2; bh=V Y3By0hTVrgL1Wi0xkBOrRleVr54f/DNNwnd5BZJjaA=; b=pGpd2a3hEYPtw8aqQ +i2ffsCP9ymghOwUlqzfuRZInSsCJm9tu5CYVaWjUlrxVe9ZQnUxvxqtqgcMlFQN oJdfIFm6CmQboalb/TqRz3SL1fBYVTkPN9QvSmjybknry88Uc+J/UPMIb5UP8PzG BAC7wcM4bS25TFfWQtyeVJVYUKAbiIilVvmYBb0M/xY079eVjHR6zh78n875PcMc CNYPRex/cGNRYN5NPDj1ZIQfaznZPJumM/8wa8VQw9b4d6l+p+rF95hC8FyQfAIB e+7e3YLOPdRILQsv2qJmBV4zaK99z/Z+tOvAfqB9jbmLW8ZMORhvQB+LrGpsGGi0 4mvmg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=VY3By0hTVrgL1Wi0xkBOrRleVr54f/DNNwnd5BZJj aA=; b=sarEq2CBOzSjNs8a2vzbddBSpeaQolx6LtSuQQE7kjn5LiDCI4WE4o76M RS0CiTXyj91I5RNM+EGkQ7/1xTLeNNVBuXim3/zMPPKoD7ojStn09AxNq2keQPwn zRtPUgC4PEYG6pyO8oEPHn8O9NSDK2gCrOQuozBAHJTQfoLzOmRYoO3XuTNQNu73 HHGfexPIC+9KSizd/IrmrOh5Wsz32ellipZNUAeXHIwbLZcpBRv10a4yqEtKJdOs uEOHmJgNifJED9Sm5BtkFaUx5OdfEpOjBGgJhQkY1Sat6WHHeWy/Kfbvheo1ZdBd rNCM1VhDUlsrrMiLtZxo4VyvRkX5Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdegjedggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepvfhfhffukffffgggjggtgfesthekredttdefheenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepheejgefhudeffeetleeigefgheetveeiteeuffehhfffkeeuvdff veffveetudefnecukfhppeejtddrudefhedrudegkedrudehudenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmuhgvlhesshhhohhllhgr nhgurdhorhhg X-ME-Proxy: Received: from [70.135.148.151] (70-135-148-151.lightspeed.stlsmo.sbcglobal.net [70.135.148.151]) by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 9 May 2021 21:54:37 -0400 (EDT) To: Maxime Ripard Cc: Chen-Yu Tsai , Jernej Skrabec , Liam Girdwood , Mark Brown , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Arnaud Ferraris References: <20210430035859.3487-1-samuel@sholland.org> <20210430035859.3487-8-samuel@sholland.org> <20210507080942.lxysxdbrviv3ys7m@gilmour> From: Samuel Holland Subject: Re: [PATCH v3 7/7] arm64: dts: allwinner: pinephone: Set audio card name Message-ID: <2c8e512c-59f4-8869-be2e-0bf4c3cc2415@sholland.org> Date: Sun, 9 May 2021 20:54:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux ppc64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20210507080942.lxysxdbrviv3ys7m@gilmour> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/7/21 3:09 AM, Maxime Ripard wrote: > Hi, > > On Thu, Apr 29, 2021 at 10:58:59PM -0500, Samuel Holland wrote: >> From: Arnaud Ferraris >> >> Add the "PinePhone" name to the sound card: this will make >> upstreaming an ALSA UCM config easier as we can use a unique name. >> >> It also avoids an issue where the default card name is truncated. >> >> Signed-off-by: Arnaud Ferraris >> [Samuel: Split out change, updated commit message] >> Signed-off-by: Samuel Holland >> --- >> arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi >> index 51cbfdc12936..02712f85f6bd 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi >> @@ -433,6 +433,7 @@ ®_rtc_ldo { >> >> &sound { >> status = "okay"; >> + simple-audio-card,name = "PinePhone"; >> simple-audio-card,aux-devs = <&codec_analog>, <&speaker_amp>; >> simple-audio-card,widgets = "Microphone", "Headset Microphone", >> "Microphone", "Internal Microphone", > > Isn't that reported to the userspace? I'm not sure we can just change it > without breaking it. Yes, this is seen by userspace. Ideally, we would add this property with a unique value when enabling audio for any board, but as you mention, it would be a breaking change to add those properties now. In practice, all distributions supporting the PinePhone are already carrying this patch, because the ALSA setup needed for the PinePhone is very different from most other boards. So it would be similarly breaking for them (and their users) to drop this patch. Regards, Samuel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 913C9C433ED for ; Mon, 10 May 2021 01:55:43 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F200461132 for ; Mon, 10 May 2021 01:55:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F200461132 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sholland.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 8DC6416A8; Mon, 10 May 2021 03:54:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 8DC6416A8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1620611741; bh=spD0iAI+uyTmHlQqlUZ5F/0FNQmMsEDDMMDdGkNWGXs=; h=To:References:From:Subject:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=q1poHrzOULj2z6RIqdAKnmf185AFz2AhGU8zfz1YGDe5B74dVm0WKLscwqTZecap5 pFTWJHM3hi4YrpJm4zcKB26Az6UsEERqlVaLshNqyJDiB2Qi8szduA/ff45t4HMm/v Ms3a4DQyIldEhYB5xh8R/rma2IfRKeC8r5rXZeiw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 32459F8020C; Mon, 10 May 2021 03:54:51 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6F842F8026B; Mon, 10 May 2021 03:54:50 +0200 (CEST) Received: from wnew3-smtp.messagingengine.com (wnew3-smtp.messagingengine.com [64.147.123.17]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7C09AF800E9 for ; Mon, 10 May 2021 03:54:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7C09AF800E9 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=sholland.org header.i=@sholland.org header.b="pGpd2a3h"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="sarEq2CB" Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id E874C148D; Sun, 9 May 2021 21:54:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 09 May 2021 21:54:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= to:cc:references:from:subject:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm2; bh=V Y3By0hTVrgL1Wi0xkBOrRleVr54f/DNNwnd5BZJjaA=; b=pGpd2a3hEYPtw8aqQ +i2ffsCP9ymghOwUlqzfuRZInSsCJm9tu5CYVaWjUlrxVe9ZQnUxvxqtqgcMlFQN oJdfIFm6CmQboalb/TqRz3SL1fBYVTkPN9QvSmjybknry88Uc+J/UPMIb5UP8PzG BAC7wcM4bS25TFfWQtyeVJVYUKAbiIilVvmYBb0M/xY079eVjHR6zh78n875PcMc CNYPRex/cGNRYN5NPDj1ZIQfaznZPJumM/8wa8VQw9b4d6l+p+rF95hC8FyQfAIB e+7e3YLOPdRILQsv2qJmBV4zaK99z/Z+tOvAfqB9jbmLW8ZMORhvQB+LrGpsGGi0 4mvmg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=VY3By0hTVrgL1Wi0xkBOrRleVr54f/DNNwnd5BZJj aA=; b=sarEq2CBOzSjNs8a2vzbddBSpeaQolx6LtSuQQE7kjn5LiDCI4WE4o76M RS0CiTXyj91I5RNM+EGkQ7/1xTLeNNVBuXim3/zMPPKoD7ojStn09AxNq2keQPwn zRtPUgC4PEYG6pyO8oEPHn8O9NSDK2gCrOQuozBAHJTQfoLzOmRYoO3XuTNQNu73 HHGfexPIC+9KSizd/IrmrOh5Wsz32ellipZNUAeXHIwbLZcpBRv10a4yqEtKJdOs uEOHmJgNifJED9Sm5BtkFaUx5OdfEpOjBGgJhQkY1Sat6WHHeWy/Kfbvheo1ZdBd rNCM1VhDUlsrrMiLtZxo4VyvRkX5Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdegjedggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepvfhfhffukffffgggjggtgfesthekredttdefheenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepheejgefhudeffeetleeigefgheetveeiteeuffehhfffkeeuvdff veffveetudefnecukfhppeejtddrudefhedrudegkedrudehudenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmuhgvlhesshhhohhllhgr nhgurdhorhhg X-ME-Proxy: Received: from [70.135.148.151] (70-135-148-151.lightspeed.stlsmo.sbcglobal.net [70.135.148.151]) by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 9 May 2021 21:54:37 -0400 (EDT) To: Maxime Ripard References: <20210430035859.3487-1-samuel@sholland.org> <20210430035859.3487-8-samuel@sholland.org> <20210507080942.lxysxdbrviv3ys7m@gilmour> From: Samuel Holland Subject: Re: [PATCH v3 7/7] arm64: dts: allwinner: pinephone: Set audio card name Message-ID: <2c8e512c-59f4-8869-be2e-0bf4c3cc2415@sholland.org> Date: Sun, 9 May 2021 20:54:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux ppc64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210507080942.lxysxdbrviv3ys7m@gilmour> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jernej Skrabec , Rob Herring , Liam Girdwood , Chen-Yu Tsai , Mark Brown , Arnaud Ferraris , linux-sunxi@lists.linux.dev, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 5/7/21 3:09 AM, Maxime Ripard wrote: > Hi, > > On Thu, Apr 29, 2021 at 10:58:59PM -0500, Samuel Holland wrote: >> From: Arnaud Ferraris >> >> Add the "PinePhone" name to the sound card: this will make >> upstreaming an ALSA UCM config easier as we can use a unique name. >> >> It also avoids an issue where the default card name is truncated. >> >> Signed-off-by: Arnaud Ferraris >> [Samuel: Split out change, updated commit message] >> Signed-off-by: Samuel Holland >> --- >> arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi >> index 51cbfdc12936..02712f85f6bd 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi >> @@ -433,6 +433,7 @@ ®_rtc_ldo { >> >> &sound { >> status = "okay"; >> + simple-audio-card,name = "PinePhone"; >> simple-audio-card,aux-devs = <&codec_analog>, <&speaker_amp>; >> simple-audio-card,widgets = "Microphone", "Headset Microphone", >> "Microphone", "Internal Microphone", > > Isn't that reported to the userspace? I'm not sure we can just change it > without breaking it. Yes, this is seen by userspace. Ideally, we would add this property with a unique value when enabling audio for any board, but as you mention, it would be a breaking change to add those properties now. In practice, all distributions supporting the PinePhone are already carrying this patch, because the ALSA setup needed for the PinePhone is very different from most other boards. So it would be similarly breaking for them (and their users) to drop this patch. Regards, Samuel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DB7CC433ED for ; Mon, 10 May 2021 01:56:40 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 129A7610A2 for ; Mon, 10 May 2021 01:56:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 129A7610A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sholland.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:Subject: From:References:Cc:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A0BR8WuQv45bf6V5nfLVsAVm7nIcz5n/vlXHYvPiv+Y=; b=IhZf+pMP1Z4kZLyf8id/D+0l1 OH4FAvUJWZPLhxNtkEn+8i3l8kW/BnnVSvulIl96VARVs4Nd2iFhU5YsMYy3DwhiLcBrDL76h5n7c u2OHW8cCjyo3+xWDSXHdj/fExl+fQUw12cwt14NJ1zolUFqNRZCUgj8YLEpJaVah7KVMr9ZBMP6X+ 5VhtozMp34cX3GYilFUkWDNjkVT2b+6mmgZlE3TLcG7Od9u8lJMzIAOo1PIAkqk2TyeRJGikCu1W+ +LcK0wtHi2MvT0wAK0ZraQ1BoUTyUiGDRKft5ZjgvVFn1Svg8ZOtHxCWWcTyZb955xtOaxCibVgPt DbPDz5BFA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lfv8N-00CofP-KQ; Mon, 10 May 2021 01:55:00 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfv8G-00Coeu-OF for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 01:54:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:Subject:From:References :Cc:To:Sender:Reply-To:Content-ID:Content-Description; bh=VY3By0hTVrgL1Wi0xkBOrRleVr54f/DNNwnd5BZJjaA=; b=UEE8hA5edp6IEifLAHACDmDiEI WrmFxpk+Fo7F9pjB5eG3XHE+gWDWUmSLKQLfgkbN6m6FWk9bA5J52eW+dLaEW22RXZwO5Nntw1ECV 1z0oODlygHhkSKzEnWsNeQIckO+RXYyPZxfyFQXG3nmWX63S27J3INuSqMN+RmL5LhAQe56m3cnQA vlschRDchLjPwJfOpexCXJIB8//AZGvj5QOSKFelhIiTkPdGEkZKGHvf35c1CkwAQMDS4IhIdfF+8 29XVaOk4g7HqRG3WgW3AzGDL5YBzH2o+Ub8QAtJ1LrdEJmcJHfrnqTvVTwteBOnUdCO6bRx990xmo MI2tS21w==; Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lfv8D-008ChJ-8m for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 01:54:50 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id E874C148D; Sun, 9 May 2021 21:54:39 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 09 May 2021 21:54:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= to:cc:references:from:subject:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm2; bh=V Y3By0hTVrgL1Wi0xkBOrRleVr54f/DNNwnd5BZJjaA=; b=pGpd2a3hEYPtw8aqQ +i2ffsCP9ymghOwUlqzfuRZInSsCJm9tu5CYVaWjUlrxVe9ZQnUxvxqtqgcMlFQN oJdfIFm6CmQboalb/TqRz3SL1fBYVTkPN9QvSmjybknry88Uc+J/UPMIb5UP8PzG BAC7wcM4bS25TFfWQtyeVJVYUKAbiIilVvmYBb0M/xY079eVjHR6zh78n875PcMc CNYPRex/cGNRYN5NPDj1ZIQfaznZPJumM/8wa8VQw9b4d6l+p+rF95hC8FyQfAIB e+7e3YLOPdRILQsv2qJmBV4zaK99z/Z+tOvAfqB9jbmLW8ZMORhvQB+LrGpsGGi0 4mvmg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=VY3By0hTVrgL1Wi0xkBOrRleVr54f/DNNwnd5BZJj aA=; b=sarEq2CBOzSjNs8a2vzbddBSpeaQolx6LtSuQQE7kjn5LiDCI4WE4o76M RS0CiTXyj91I5RNM+EGkQ7/1xTLeNNVBuXim3/zMPPKoD7ojStn09AxNq2keQPwn zRtPUgC4PEYG6pyO8oEPHn8O9NSDK2gCrOQuozBAHJTQfoLzOmRYoO3XuTNQNu73 HHGfexPIC+9KSizd/IrmrOh5Wsz32ellipZNUAeXHIwbLZcpBRv10a4yqEtKJdOs uEOHmJgNifJED9Sm5BtkFaUx5OdfEpOjBGgJhQkY1Sat6WHHeWy/Kfbvheo1ZdBd rNCM1VhDUlsrrMiLtZxo4VyvRkX5Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdegjedggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepvfhfhffukffffgggjggtgfesthekredttdefheenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepheejgefhudeffeetleeigefgheetveeiteeuffehhfffkeeuvdff veffveetudefnecukfhppeejtddrudefhedrudegkedrudehudenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmuhgvlhesshhhohhllhgr nhgurdhorhhg X-ME-Proxy: Received: from [70.135.148.151] (70-135-148-151.lightspeed.stlsmo.sbcglobal.net [70.135.148.151]) by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 9 May 2021 21:54:37 -0400 (EDT) To: Maxime Ripard Cc: Chen-Yu Tsai , Jernej Skrabec , Liam Girdwood , Mark Brown , Rob Herring , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Arnaud Ferraris References: <20210430035859.3487-1-samuel@sholland.org> <20210430035859.3487-8-samuel@sholland.org> <20210507080942.lxysxdbrviv3ys7m@gilmour> From: Samuel Holland Subject: Re: [PATCH v3 7/7] arm64: dts: allwinner: pinephone: Set audio card name Message-ID: <2c8e512c-59f4-8869-be2e-0bf4c3cc2415@sholland.org> Date: Sun, 9 May 2021 20:54:36 -0500 User-Agent: Mozilla/5.0 (X11; Linux ppc64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210507080942.lxysxdbrviv3ys7m@gilmour> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210509_185449_350351_30BDEBD7 X-CRM114-Status: GOOD ( 20.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/7/21 3:09 AM, Maxime Ripard wrote: > Hi, > > On Thu, Apr 29, 2021 at 10:58:59PM -0500, Samuel Holland wrote: >> From: Arnaud Ferraris >> >> Add the "PinePhone" name to the sound card: this will make >> upstreaming an ALSA UCM config easier as we can use a unique name. >> >> It also avoids an issue where the default card name is truncated. >> >> Signed-off-by: Arnaud Ferraris >> [Samuel: Split out change, updated commit message] >> Signed-off-by: Samuel Holland >> --- >> arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi >> index 51cbfdc12936..02712f85f6bd 100644 >> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi >> @@ -433,6 +433,7 @@ ®_rtc_ldo { >> >> &sound { >> status = "okay"; >> + simple-audio-card,name = "PinePhone"; >> simple-audio-card,aux-devs = <&codec_analog>, <&speaker_amp>; >> simple-audio-card,widgets = "Microphone", "Headset Microphone", >> "Microphone", "Internal Microphone", > > Isn't that reported to the userspace? I'm not sure we can just change it > without breaking it. Yes, this is seen by userspace. Ideally, we would add this property with a unique value when enabling audio for any board, but as you mention, it would be a breaking change to add those properties now. In practice, all distributions supporting the PinePhone are already carrying this patch, because the ALSA setup needed for the PinePhone is very different from most other boards. So it would be similarly breaking for them (and their users) to drop this patch. Regards, Samuel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel