From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23DC5C47094 for ; Mon, 14 Jun 2021 18:16:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EDE7C61059 for ; Mon, 14 Jun 2021 18:16:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235246AbhFNSS2 (ORCPT ); Mon, 14 Jun 2021 14:18:28 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:46774 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233424AbhFNSS0 (ORCPT ); Mon, 14 Jun 2021 14:18:26 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 15EIGJoa120778; Mon, 14 Jun 2021 13:16:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1623694579; bh=NxVCEcZrZwDO257WFQvJlJiBOGxX0k/7J+zSkCOgniQ=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=tWgqGeYPjAxhzhMlz+fAsN3+eajQipSEvlWU0BZaJ7wIU4go/p0QFuF3ETM1NzVqR pEav75iLaL8Hyzf4p9xiiPDAMRB9tap09WNcVyBtkLHEY2oXEMPrcHlYGN4Lf1nT9q lMoBI6gW5OtOc2HiFGPzQT4w8WgtpvjR6AQnOg8g= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 15EIGJsM091771 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Jun 2021 13:16:19 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 14 Jun 2021 13:16:18 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Mon, 14 Jun 2021 13:16:18 -0500 Received: from [10.250.35.153] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 15EIGIrH075089; Mon, 14 Jun 2021 13:16:18 -0500 Subject: Re: [PATCH v2] arm64: dts: ti: k3-am64-main: Update the location of ATF in SRAM and increase its max size To: Lokesh Vutla , Aswath Govindraju CC: Vignesh Raghavendra , Kishon Vijay Abraham I , Nishanth Menon , Tero Kristo , Rob Herring , , , References: <20210607133806.18158-1-a-govindraju@ti.com> <50bb1f20-ccca-fe94-eac1-70ac83bc004d@ti.com> From: Suman Anna Message-ID: <2c99ab11-96da-a74c-62d1-f14c686d0a0b@ti.com> Date: Mon, 14 Jun 2021 13:16:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <50bb1f20-ccca-fe94-eac1-70ac83bc004d@ti.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Aswath, On 6/9/21 10:24 AM, Lokesh Vutla wrote: > > > On 09/06/21 8:52 pm, Aswath Govindraju wrote: >> Hi Lokesh, >> >> On 09/06/21 7:59 pm, Lokesh Vutla wrote: >>> >>> >>> On 07/06/21 7:08 pm, Aswath Govindraju wrote: >>>> Due to a limitation for USB DFU boot mode, SPL load address has to be less >>>> than or equal to 0x70001000. So, load address of SPL and ATF have been >>>> moved to 0x70000000 and 0x701a0000 respectively. >>>> >>>> Also, the maximum size of ATF has been increased to 0x1c000 [1]. >>>> >>>> Therefore, update ATF's location and maximum size accordingly in the device >>>> tree file. >>>> >>>> [1] - https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=2fb5312f61a7de8b7a70e1639199c4f14a10b6f9 >>>> >>>> Signed-off-by: Aswath Govindraju >>>> --- >>>> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi >>>> index ca59d1f711f8..fcd12b6f10f6 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi >>>> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi >>>> @@ -13,8 +13,8 @@ >>>> #size-cells = <1>; >>>> ranges = <0x0 0x00 0x70000000 0x200000>; >>>> >>>> - atf-sram@0 { >>>> - reg = <0x0 0x1a000>; >>>> + atf-sram@1a0000 { >>>> + reg = <0x1a0000 0x1c000>; >>> >>> After thinking a bot more, isn't size be 0x20000? >>> ATF is allocated with 125KB no? no point keeping the ~3 as hole IMO. >>> >> >> The max size of ATF as defined above in [1] is 0x1c000 and as the >> argument has to reflect it I have modified it to the same. > I personally prefer that the size increase and address relocation are split up into two separate patches for appropriate version compatibility. TFA 2.5 has updated the size to 0x1c000, so I would like to see that as the first patch. We should be able to merge that change right away. I see there is some on-going discussion around the relocated address, so it can fall in line with the corresponding SYSFW reservation patch. regards Suman > ahh..Got it. Ignore my comment. > > Thanks and regards, > Lokesh > >> >> Thanks, >> Aswath >> >> >>> Thanks and regards, >>> Lokesh >>> >>>> }; >>>> }; >>>> >>>> >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6544BC2B9F4 for ; Mon, 14 Jun 2021 18:18:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17E69610A1 for ; Mon, 14 Jun 2021 18:18:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17E69610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:CC:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=GWxnrGUw+wRPBZQKhAVQYaagZH9beE/sjc0vwTyNscs=; b=BqbSjp4oBEwi2Y9wt7O/g79fr7 4z1+YygMOnF6klfsh8o8SmDVFAfgBvg3FWC0nKF0efKXiaeFCU/4LTQZSu35bfoSF2wkdVuaRN1rK Y99aRBkEwR+scjmDm3BFlGGw+8+t3aCnQHnnwUiQ1hgTcggwd+6R/Zb2Rzd7TTv9Rnay71JH0+n12 Z2Qmk5EFjg8bbeVaVCdK9ncFpon7Bbsy6QvUgFgeuQwbDn/TiulHQerZJ1uxC0gd82r7M74AfSxlf j0RPGe29Aqcf/tHnuXuiwMadn3RUb50iJO+FMv9T0X+3SmWr0d9KqoBiClhn+FWpv6rG7q7eGnUJo txPPktzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsr8Q-00FfMF-J9; Mon, 14 Jun 2021 18:16:31 +0000 Received: from fllv0015.ext.ti.com ([198.47.19.141]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lsr8H-00FfKe-BP for linux-arm-kernel@lists.infradead.org; Mon, 14 Jun 2021 18:16:23 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 15EIGJoa120778; Mon, 14 Jun 2021 13:16:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1623694579; bh=NxVCEcZrZwDO257WFQvJlJiBOGxX0k/7J+zSkCOgniQ=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=tWgqGeYPjAxhzhMlz+fAsN3+eajQipSEvlWU0BZaJ7wIU4go/p0QFuF3ETM1NzVqR pEav75iLaL8Hyzf4p9xiiPDAMRB9tap09WNcVyBtkLHEY2oXEMPrcHlYGN4Lf1nT9q lMoBI6gW5OtOc2HiFGPzQT4w8WgtpvjR6AQnOg8g= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 15EIGJsM091771 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 14 Jun 2021 13:16:19 -0500 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 14 Jun 2021 13:16:18 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Mon, 14 Jun 2021 13:16:18 -0500 Received: from [10.250.35.153] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 15EIGIrH075089; Mon, 14 Jun 2021 13:16:18 -0500 Subject: Re: [PATCH v2] arm64: dts: ti: k3-am64-main: Update the location of ATF in SRAM and increase its max size To: Lokesh Vutla , Aswath Govindraju CC: Vignesh Raghavendra , Kishon Vijay Abraham I , Nishanth Menon , Tero Kristo , Rob Herring , , , References: <20210607133806.18158-1-a-govindraju@ti.com> <50bb1f20-ccca-fe94-eac1-70ac83bc004d@ti.com> From: Suman Anna Message-ID: <2c99ab11-96da-a74c-62d1-f14c686d0a0b@ti.com> Date: Mon, 14 Jun 2021 13:16:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <50bb1f20-ccca-fe94-eac1-70ac83bc004d@ti.com> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210614_111621_520502_94D84761 X-CRM114-Status: GOOD ( 22.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Aswath, On 6/9/21 10:24 AM, Lokesh Vutla wrote: > > > On 09/06/21 8:52 pm, Aswath Govindraju wrote: >> Hi Lokesh, >> >> On 09/06/21 7:59 pm, Lokesh Vutla wrote: >>> >>> >>> On 07/06/21 7:08 pm, Aswath Govindraju wrote: >>>> Due to a limitation for USB DFU boot mode, SPL load address has to be less >>>> than or equal to 0x70001000. So, load address of SPL and ATF have been >>>> moved to 0x70000000 and 0x701a0000 respectively. >>>> >>>> Also, the maximum size of ATF has been increased to 0x1c000 [1]. >>>> >>>> Therefore, update ATF's location and maximum size accordingly in the device >>>> tree file. >>>> >>>> [1] - https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/commit/?id=2fb5312f61a7de8b7a70e1639199c4f14a10b6f9 >>>> >>>> Signed-off-by: Aswath Govindraju >>>> --- >>>> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi >>>> index ca59d1f711f8..fcd12b6f10f6 100644 >>>> --- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi >>>> +++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi >>>> @@ -13,8 +13,8 @@ >>>> #size-cells = <1>; >>>> ranges = <0x0 0x00 0x70000000 0x200000>; >>>> >>>> - atf-sram@0 { >>>> - reg = <0x0 0x1a000>; >>>> + atf-sram@1a0000 { >>>> + reg = <0x1a0000 0x1c000>; >>> >>> After thinking a bot more, isn't size be 0x20000? >>> ATF is allocated with 125KB no? no point keeping the ~3 as hole IMO. >>> >> >> The max size of ATF as defined above in [1] is 0x1c000 and as the >> argument has to reflect it I have modified it to the same. > I personally prefer that the size increase and address relocation are split up into two separate patches for appropriate version compatibility. TFA 2.5 has updated the size to 0x1c000, so I would like to see that as the first patch. We should be able to merge that change right away. I see there is some on-going discussion around the relocated address, so it can fall in line with the corresponding SYSFW reservation patch. regards Suman > ahh..Got it. Ignore my comment. > > Thanks and regards, > Lokesh > >> >> Thanks, >> Aswath >> >> >>> Thanks and regards, >>> Lokesh >>> >>>> }; >>>> }; >>>> >>>> >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel