From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59391C47082 for ; Thu, 27 May 2021 02:55:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2413060E08 for ; Thu, 27 May 2021 02:55:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232088AbhE0C4t (ORCPT ); Wed, 26 May 2021 22:56:49 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:54638 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229939AbhE0C4s (ORCPT ); Wed, 26 May 2021 22:56:48 -0400 Received: from imap.suse.de (imap-alt.suse-dmz.suse.de [192.168.254.47]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 606F5218E1; Thu, 27 May 2021 02:55:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1622084115; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=69Q2fUXLBqf8vNF74HnM/hoHoUEhYgwv+9sIEJxxfwY=; b=yJ9QV0SxrTAbPG0VM0fOqEU+p7IzYwJSIf0whJGZMrDhOt7/dshYHyZziVahvrWpbYVRnL NaZAuoubPzXzTeuR//gHzaZ+fjjiuoLsXzAy3V5PCw9Q9bbsPhQW1coSZNmzhDBJ/NYiSE j8rryvhEIw7ABbL4DLGPmAhUEi99gnU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1622084115; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=69Q2fUXLBqf8vNF74HnM/hoHoUEhYgwv+9sIEJxxfwY=; b=cjzbLsi8plJWQeu9ROtixPP70NJQeGr/eroAFnXGIdyIlNQO3LQ7gEWl0S6wTscdfNAOJ2 DWa3D/55egzRS0Cw== Received: from director2.suse.de (director2.suse-dmz.suse.de [192.168.254.72]) by imap.suse.de (Postfix) with ESMTPSA id B28E811A98; Thu, 27 May 2021 02:55:14 +0000 (UTC) To: Nix Cc: linux-bcache@vger.kernel.org References: <20210526151450.45211-1-colyli@suse.de> <87tumpiiyz.fsf@esperi.org.uk> From: Coly Li Subject: Re: [PATCH v4] bcache: avoid oversized read request in cache missing code path Message-ID: <2ca4d125-c1d0-0ed0-f654-1b816432ed2e@suse.de> Date: Thu, 27 May 2021 10:55:12 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <87tumpiiyz.fsf@esperi.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On 5/26/21 11:59 PM, Nix wrote: > On 26 May 2021, Coly Li said: >> Current problmatic code can be partially found since Linux v5.13-rc1, >> therefore all maintained stable kernels should try to apply this fix. > > I thought this crash was observed with 5.12 originally? (I know that's > why I'm still on 5.11 :) ) > My typo, sigh.... The problematic code was in such form since Linux v3.13-rc1, - the bio related panic was explicitly triggered due to bio changes since v5.12. - the overflowed bkey size issue exists for long time too, just no one reports it before. Maybe the issue can be found in pre-v3.13 code, but I don't check because the code logic was not in current form. Thank you for figure out the typo, I will fix it in next version. Coly Li