From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E790C433F5 for ; Fri, 28 Jan 2022 06:57:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id EF6BD84E28; Fri, 28 Jan 2022 06:57:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qjKeW6CC6vnk; Fri, 28 Jan 2022 06:57:21 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 629F984DEF; Fri, 28 Jan 2022 06:57:20 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 1B28DC0011; Fri, 28 Jan 2022 06:57:20 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138]) by lists.linuxfoundation.org (Postfix) with ESMTP id F1277C000B for ; Fri, 28 Jan 2022 06:57:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id D8C4484DFB for ; Fri, 28 Jan 2022 06:57:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1P65uxsxdufF for ; Fri, 28 Jan 2022 06:57:18 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp1.osuosl.org (Postfix) with ESMTPS id DCB3184DEF for ; Fri, 28 Jan 2022 06:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643353036; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hoR9Y1f2jHonl69jIVjtfl1NZy3bn027LYcSouPHOCA=; b=A+caUFQuuLnXAy0ILZkQ2yc0X2T8haG8luoYN6ETCgjZQp2WggcZRUfpoYl/zkqhAIXD/U a8sWzU1a041I8h43JOfi41tigoTidm1LXj7VlTPxljqtqEIcyJEi3I8NKnq09EWzSH02u7 TYlC+ct89FRMR/rIRMWtDfP+lAfV6BI= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-632-aUhxmzHYMTmt8M7Yo8OwZQ-1; Fri, 28 Jan 2022 01:57:13 -0500 X-MC-Unique: aUhxmzHYMTmt8M7Yo8OwZQ-1 Received: by mail-pl1-f199.google.com with SMTP id y17-20020a170902d65100b0014a17faf0bdso2756752plh.12 for ; Thu, 27 Jan 2022 22:57:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hoR9Y1f2jHonl69jIVjtfl1NZy3bn027LYcSouPHOCA=; b=OqAeNVn1bLGAMijs//W8LuSXCiW8cempDE3XTXMmHuQfIM/+v9QrGuMPoU2H2EZDob l6OWIhTDbqfRKy+GSMFxUD/aXJrHIDaeaTGouzHMe8z8uyyE3ootyGidpKp5wxbYowQS tBk68mtkXMQWh7PhlxDWV0X+tkJ8U97Ujr+WeZB1dYre3iw+PDtKYElHdsbhEVAQ+qoN xvkk7dSY8mE2thm7WbpKPwH6bHgd0qEDeZvLiCgR6I5089Y7r0r+Krtj4r9Mn2gK745n +zNa+yH++d+EIDGPykgGJ6epotNB2DnSMAxfI22UEL+/8tFnclkH5SruGHhidw9ZSWcI eedg== X-Gm-Message-State: AOAM5337ilfWnZpTIJNn+tO7yzSFwroGUfsPRJ8Quwvs6U3qN4Y1f2Cq HNDy+Uw0ISg/1vto+GIQZQ2qt/AIot20vyQUHcQuCt9FADRnxlKyEEj9kHVvSiKz0J8nlv/6WJA VYJ0L9LdY64CrYW0MJRNVmmH6ltSi7+AnEPzDRIf/5w== X-Received: by 2002:a17:90b:4a4c:: with SMTP id lb12mr8201271pjb.211.1643353031858; Thu, 27 Jan 2022 22:57:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJzWBbXSw4EH+rGgOI68sTw2G4dwbKWA9R9aZIkj+kSxOGwh1zp8Fv6sWqFo7rwALZOYIqg1aQ== X-Received: by 2002:a17:90b:4a4c:: with SMTP id lb12mr8201250pjb.211.1643353031546; Thu, 27 Jan 2022 22:57:11 -0800 (PST) Received: from [10.72.13.185] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id mi18sm1282013pjb.35.2022.01.27.22.57.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jan 2022 22:57:10 -0800 (PST) Message-ID: <2cb2415b-7d8b-6187-c202-27e8f26410a4@redhat.com> Date: Fri, 28 Jan 2022 14:56:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 06/31] vhost: Route guest->host notification through shadow virtqueue To: =?UTF-8?Q?Eugenio_P=c3=a9rez?= , qemu-devel@nongnu.org References: <20220121202733.404989-1-eperezma@redhat.com> <20220121202733.404989-7-eperezma@redhat.com> From: Jason Wang In-Reply-To: <20220121202733.404989-7-eperezma@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Laurent Vivier , Parav Pandit , Cindy Lu , "Michael S. Tsirkin" , Richard Henderson , Markus Armbruster , Gautam Dawar , virtualization@lists.linux-foundation.org, Eduardo Habkost , Harpreet Singh Anand , Xiao W Wang , Stefan Hajnoczi , Eli Cohen , Paolo Bonzini , Zhu Lingshan , Eric Blake X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" CuWcqCAyMDIyLzEvMjIg5LiK5Y2INDoyNywgRXVnZW5pbyBQw6lyZXog5YaZ6YGTOgo+IEF0IHRo aXMgbW9tZW50IG5vIGJ1ZmZlciBmb3J3YXJkaW5nIHdpbGwgYmUgcGVyZm9ybWVkIGluIFNWUSBt b2RlOiBRZW11Cj4ganVzdCBmb3J3YXJkIHRoZSBndWVzdCdzIGtpY2tzIHRvIHRoZSBkZXZpY2Uu IFRoaXMgY29tbWl0IGFsc28gc2V0IHVwCj4gU1ZRcyBpbiB0aGUgdmhvc3QgZGV2aWNlLgo+Cj4g SG9zdCBtZW1vcnkgbm90aWZpZXJzIHJlZ2lvbnMgYXJlIGxlZnQgb3V0IGZvciBzaW1wbGljaXR5 LCBhbmQgdGhleSB3aWxsCj4gbm90IGJlIGFkZHJlc3NlZCBpbiB0aGlzIHNlcmllcy4KCgpJIHdv bmRlciBpZiBpdCdzIGJldHRlciB0byBzcXVhc2ggdGhpcyBpbnRvIHBhdGNoIDUgc2luY2UgaXQg Z2l2ZXMgdXMgYSAKZnVsbCBndWVzdC0+aG9zdCBmb3J3YXJkaW5nLgoKCj4KPiBTaWduZWQtb2Zm LWJ5OiBFdWdlbmlvIFDDqXJleiA8ZXBlcmV6bWFAcmVkaGF0LmNvbT4KPiAtLS0KPiAgIGluY2x1 ZGUvaHcvdmlydGlvL3Zob3N0LXZkcGEuaCB8ICAgNCArKwo+ICAgaHcvdmlydGlvL3Zob3N0LXZk cGEuYyAgICAgICAgIHwgMTIyICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLQo+ICAg MiBmaWxlcyBjaGFuZ2VkLCAxMjQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPgo+IGRp ZmYgLS1naXQgYS9pbmNsdWRlL2h3L3ZpcnRpby92aG9zdC12ZHBhLmggYi9pbmNsdWRlL2h3L3Zp cnRpby92aG9zdC12ZHBhLmgKPiBpbmRleCAzY2U3OWE2NDZkLi4wMDlhOWYzYjZiIDEwMDY0NAo+ IC0tLSBhL2luY2x1ZGUvaHcvdmlydGlvL3Zob3N0LXZkcGEuaAo+ICsrKyBiL2luY2x1ZGUvaHcv dmlydGlvL3Zob3N0LXZkcGEuaAo+IEBAIC0xMiw2ICsxMiw4IEBACj4gICAjaWZuZGVmIEhXX1ZJ UlRJT19WSE9TVF9WRFBBX0gKPiAgICNkZWZpbmUgSFdfVklSVElPX1ZIT1NUX1ZEUEFfSAo+ICAg Cj4gKyNpbmNsdWRlIDxnbW9kdWxlLmg+Cj4gKwo+ICAgI2luY2x1ZGUgImh3L3ZpcnRpby92aXJ0 aW8uaCIKPiAgICNpbmNsdWRlICJzdGFuZGFyZC1oZWFkZXJzL2xpbnV4L3Zob3N0X3R5cGVzLmgi Cj4gICAKPiBAQCAtMjcsNiArMjksOCBAQCB0eXBlZGVmIHN0cnVjdCB2aG9zdF92ZHBhIHsKPiAg ICAgICBib29sIGlvdGxiX2JhdGNoX2JlZ2luX3NlbnQ7Cj4gICAgICAgTWVtb3J5TGlzdGVuZXIg bGlzdGVuZXI7Cj4gICAgICAgc3RydWN0IHZob3N0X3ZkcGFfaW92YV9yYW5nZSBpb3ZhX3Jhbmdl Owo+ICsgICAgYm9vbCBzaGFkb3dfdnFzX2VuYWJsZWQ7Cj4gKyAgICBHUHRyQXJyYXkgKnNoYWRv d192cXM7Cj4gICAgICAgc3RydWN0IHZob3N0X2RldiAqZGV2Owo+ICAgICAgIFZob3N0VkRQQUhv c3ROb3RpZmllciBub3RpZmllcltWSVJUSU9fUVVFVUVfTUFYXTsKPiAgIH0gVmhvc3RWRFBBOwo+ IGRpZmYgLS1naXQgYS9ody92aXJ0aW8vdmhvc3QtdmRwYS5jIGIvaHcvdmlydGlvL3Zob3N0LXZk cGEuYwo+IGluZGV4IDZjMTBhN2YwNWYuLjE4ZGUxNGYwZmIgMTAwNjQ0Cj4gLS0tIGEvaHcvdmly dGlvL3Zob3N0LXZkcGEuYwo+ICsrKyBiL2h3L3ZpcnRpby92aG9zdC12ZHBhLmMKPiBAQCAtMTcs MTIgKzE3LDE0IEBACj4gICAjaW5jbHVkZSAiaHcvdmlydGlvL3Zob3N0LmgiCj4gICAjaW5jbHVk ZSAiaHcvdmlydGlvL3Zob3N0LWJhY2tlbmQuaCIKPiAgICNpbmNsdWRlICJody92aXJ0aW8vdmly dGlvLW5ldC5oIgo+ICsjaW5jbHVkZSAiaHcvdmlydGlvL3Zob3N0LXNoYWRvdy12aXJ0cXVldWUu aCIKPiAgICNpbmNsdWRlICJody92aXJ0aW8vdmhvc3QtdmRwYS5oIgo+ICAgI2luY2x1ZGUgImV4 ZWMvYWRkcmVzcy1zcGFjZXMuaCIKPiAgICNpbmNsdWRlICJxZW11L21haW4tbG9vcC5oIgo+ICAg I2luY2x1ZGUgImNwdS5oIgo+ICAgI2luY2x1ZGUgInRyYWNlLmgiCj4gICAjaW5jbHVkZSAicWVt dS1jb21tb24uaCIKPiArI2luY2x1ZGUgInFhcGkvZXJyb3IuaCIKPiAgIAo+ICAgLyoKPiAgICAq IFJldHVybiBvbmUgcGFzdCB0aGUgZW5kIG9mIHRoZSBlbmQgb2Ygc2VjdGlvbi4gQmUgY2FyZWZ1 bCB3aXRoIHVpbnQ2NF90Cj4gQEAgLTQwOSw4ICs0MTEsMTQgQEAgZXJyOgo+ICAgCj4gICBzdGF0 aWMgdm9pZCB2aG9zdF92ZHBhX2hvc3Rfbm90aWZpZXJzX2luaXQoc3RydWN0IHZob3N0X2RldiAq ZGV2KQo+ICAgewo+ICsgICAgc3RydWN0IHZob3N0X3ZkcGEgKnYgPSBkZXYtPm9wYXF1ZTsKPiAg ICAgICBpbnQgaTsKPiAgIAo+ICsgICAgaWYgKHYtPnNoYWRvd192cXNfZW5hYmxlZCkgewo+ICsg ICAgICAgIC8qIFNWUSBpcyBub3QgY29tcGF0aWJsZSB3aXRoIGhvc3Qgbm90aWZpZXJzIG1yICov CgoKSSBndWVzcyB0aGVyZSBzaG91bGQgYmUgYSBUT0RPIG9yIEZJWE1FIGhlcmUuCgoKPiArICAg ICAgICByZXR1cm47Cj4gKyAgICB9Cj4gKwo+ICAgICAgIGZvciAoaSA9IGRldi0+dnFfaW5kZXg7 IGkgPCBkZXYtPnZxX2luZGV4ICsgZGV2LT5udnFzOyBpKyspIHsKPiAgICAgICAgICAgaWYgKHZo b3N0X3ZkcGFfaG9zdF9ub3RpZmllcl9pbml0KGRldiwgaSkpIHsKPiAgICAgICAgICAgICAgIGdv dG8gZXJyOwo+IEBAIC00MjQsNiArNDMyLDE3IEBAIGVycjoKPiAgICAgICByZXR1cm47Cj4gICB9 Cj4gICAKPiArc3RhdGljIHZvaWQgdmhvc3RfdmRwYV9zdnFfY2xlYW51cChzdHJ1Y3Qgdmhvc3Rf ZGV2ICpkZXYpCj4gK3sKPiArICAgIHN0cnVjdCB2aG9zdF92ZHBhICp2ID0gZGV2LT5vcGFxdWU7 Cj4gKyAgICBzaXplX3QgaWR4Owo+ICsKPiArICAgIGZvciAoaWR4ID0gMDsgaWR4IDwgdi0+c2hh ZG93X3Zxcy0+bGVuOyArK2lkeCkgewo+ICsgICAgICAgIHZob3N0X3N2cV9zdG9wKGdfcHRyX2Fy cmF5X2luZGV4KHYtPnNoYWRvd192cXMsIGlkeCkpOwo+ICsgICAgfQo+ICsgICAgZ19wdHJfYXJy YXlfZnJlZSh2LT5zaGFkb3dfdnFzLCB0cnVlKTsKPiArfQo+ICsKPiAgIHN0YXRpYyBpbnQgdmhv c3RfdmRwYV9jbGVhbnVwKHN0cnVjdCB2aG9zdF9kZXYgKmRldikKPiAgIHsKPiAgICAgICBzdHJ1 Y3Qgdmhvc3RfdmRwYSAqdjsKPiBAQCAtNDMyLDYgKzQ1MSw3IEBAIHN0YXRpYyBpbnQgdmhvc3Rf dmRwYV9jbGVhbnVwKHN0cnVjdCB2aG9zdF9kZXYgKmRldikKPiAgICAgICB0cmFjZV92aG9zdF92 ZHBhX2NsZWFudXAoZGV2LCB2KTsKPiAgICAgICB2aG9zdF92ZHBhX2hvc3Rfbm90aWZpZXJzX3Vu aW5pdChkZXYsIGRldi0+bnZxcyk7Cj4gICAgICAgbWVtb3J5X2xpc3RlbmVyX3VucmVnaXN0ZXIo JnYtPmxpc3RlbmVyKTsKPiArICAgIHZob3N0X3ZkcGFfc3ZxX2NsZWFudXAoZGV2KTsKPiAgIAo+ ICAgICAgIGRldi0+b3BhcXVlID0gTlVMTDsKPiAgICAgICByYW1fYmxvY2tfZGlzY2FyZF9kaXNh YmxlKGZhbHNlKTsKPiBAQCAtNTA3LDkgKzUyNywxNSBAQCBzdGF0aWMgaW50IHZob3N0X3ZkcGFf Z2V0X2RldmljZV9pZChzdHJ1Y3Qgdmhvc3RfZGV2ICpkZXYsCj4gICAKPiAgIHN0YXRpYyBpbnQg dmhvc3RfdmRwYV9yZXNldF9kZXZpY2Uoc3RydWN0IHZob3N0X2RldiAqZGV2KQo+ICAgewo+ICsg ICAgc3RydWN0IHZob3N0X3ZkcGEgKnYgPSBkZXYtPm9wYXF1ZTsKPiAgICAgICBpbnQgcmV0Owo+ ICAgICAgIHVpbnQ4X3Qgc3RhdHVzID0gMDsKPiAgIAo+ICsgICAgZm9yICh1bnNpZ25lZCBpID0g MDsgaSA8IHYtPnNoYWRvd192cXMtPmxlbjsgKytpKSB7Cj4gKyAgICAgICAgVmhvc3RTaGFkb3dW aXJ0cXVldWUgKnN2cSA9IGdfcHRyX2FycmF5X2luZGV4KHYtPnNoYWRvd192cXMsIGkpOwo+ICsg ICAgICAgIHZob3N0X3N2cV9zdG9wKHN2cSk7Cj4gKyAgICB9Cj4gKwo+ICAgICAgIHJldCA9IHZo b3N0X3ZkcGFfY2FsbChkZXYsIFZIT1NUX1ZEUEFfU0VUX1NUQVRVUywgJnN0YXR1cyk7Cj4gICAg ICAgdHJhY2Vfdmhvc3RfdmRwYV9yZXNldF9kZXZpY2UoZGV2LCBzdGF0dXMpOwo+ICAgICAgIHJl dHVybiByZXQ7Cj4gQEAgLTYzOSwxMyArNjY1LDI4IEBAIHN0YXRpYyBpbnQgdmhvc3RfdmRwYV9n ZXRfdnJpbmdfYmFzZShzdHJ1Y3Qgdmhvc3RfZGV2ICpkZXYsCj4gICAgICAgcmV0dXJuIHJldDsK PiAgIH0KPiAgIAo+IC1zdGF0aWMgaW50IHZob3N0X3ZkcGFfc2V0X3ZyaW5nX2tpY2soc3RydWN0 IHZob3N0X2RldiAqZGV2LAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBzdHJ1Y3Qgdmhvc3RfdnJpbmdfZmlsZSAqZmlsZSkKPiArc3RhdGljIGludCB2aG9zdF92ZHBh X3NldF92cmluZ19kZXZfa2ljayhzdHJ1Y3Qgdmhvc3RfZGV2ICpkZXYsCj4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0IHZob3N0X3ZyaW5nX2ZpbGUgKmZp bGUpCj4gICB7Cj4gICAgICAgdHJhY2Vfdmhvc3RfdmRwYV9zZXRfdnJpbmdfa2ljayhkZXYsIGZp bGUtPmluZGV4LCBmaWxlLT5mZCk7Cj4gICAgICAgcmV0dXJuIHZob3N0X3ZkcGFfY2FsbChkZXYs IFZIT1NUX1NFVF9WUklOR19LSUNLLCBmaWxlKTsKPiAgIH0KPiAgIAo+ICtzdGF0aWMgaW50IHZo b3N0X3ZkcGFfc2V0X3ZyaW5nX2tpY2soc3RydWN0IHZob3N0X2RldiAqZGV2LAo+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdHJ1Y3Qgdmhvc3RfdnJpbmdfZmlsZSAq ZmlsZSkKPiArewo+ICsgICAgc3RydWN0IHZob3N0X3ZkcGEgKnYgPSBkZXYtPm9wYXF1ZTsKPiAr ICAgIGludCB2ZHBhX2lkeCA9IHZob3N0X3ZkcGFfZ2V0X3ZxX2luZGV4KGRldiwgZmlsZS0+aW5k ZXgpOwo+ICsKPiArICAgIGlmICh2LT5zaGFkb3dfdnFzX2VuYWJsZWQpIHsKPiArICAgICAgICBW aG9zdFNoYWRvd1ZpcnRxdWV1ZSAqc3ZxID0gZ19wdHJfYXJyYXlfaW5kZXgodi0+c2hhZG93X3Zx cywgdmRwYV9pZHgpOwo+ICsgICAgICAgIHZob3N0X3N2cV9zZXRfc3ZxX2tpY2tfZmQoc3ZxLCBm aWxlLT5mZCk7Cj4gKyAgICAgICAgcmV0dXJuIDA7Cj4gKyAgICB9IGVsc2Ugewo+ICsgICAgICAg IHJldHVybiB2aG9zdF92ZHBhX3NldF92cmluZ19kZXZfa2ljayhkZXYsIGZpbGUpOwo+ICsgICAg fQo+ICt9Cj4gKwo+ICAgc3RhdGljIGludCB2aG9zdF92ZHBhX3NldF92cmluZ19jYWxsKHN0cnVj dCB2aG9zdF9kZXYgKmRldiwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHN0cnVjdCB2aG9zdF92cmluZ19maWxlICpmaWxlKQo+ICAgewo+IEBAIC02NTMsNiArNjk0 LDMzIEBAIHN0YXRpYyBpbnQgdmhvc3RfdmRwYV9zZXRfdnJpbmdfY2FsbChzdHJ1Y3Qgdmhvc3Rf ZGV2ICpkZXYsCj4gICAgICAgcmV0dXJuIHZob3N0X3ZkcGFfY2FsbChkZXYsIFZIT1NUX1NFVF9W UklOR19DQUxMLCBmaWxlKTsKPiAgIH0KPiAgIAo+ICsvKioKPiArICogU2V0IHNoYWRvdyB2aXJ0 cXVldWUgZGVzY3JpcHRvcnMgdG8gdGhlIGRldmljZQo+ICsgKgo+ICsgKiBAZGV2ICAgVGhlIHZo b3N0IGRldmljZSBtb2RlbAo+ICsgKiBAc3ZxICAgVGhlIHNoYWRvdyB2aXJ0cXVldWUKPiArICog QGlkeCAgIFRoZSBpbmRleCBvZiB0aGUgdmlydHF1ZXVlIGluIHRoZSB2aG9zdCBkZXZpY2UKPiAr ICovCj4gK3N0YXRpYyBib29sIHZob3N0X3ZkcGFfc3ZxX3NldHVwKHN0cnVjdCB2aG9zdF9kZXYg KmRldiwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBWaG9zdFNoYWRvd1ZpcnRx dWV1ZSAqc3ZxLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGlk eCkKPiArewo+ICsgICAgc3RydWN0IHZob3N0X3ZyaW5nX2ZpbGUgZmlsZSA9IHsKPiArICAgICAg ICAuaW5kZXggPSBkZXYtPnZxX2luZGV4ICsgaWR4LAo+ICsgICAgfTsKPiArICAgIGNvbnN0IEV2 ZW50Tm90aWZpZXIgKmV2ZW50X25vdGlmaWVyOwo+ICsgICAgaW50IHI7Cj4gKwo+ICsgICAgZXZl bnRfbm90aWZpZXIgPSB2aG9zdF9zdnFfZ2V0X2Rldl9raWNrX25vdGlmaWVyKHN2cSk7CgoKQSBx dWVzdGlvbiwgYW55IHJlYXNvbiBmb3IgbWFraW5nIFZob3N0U2hhZG93VmlydHF1ZXVlIHByaXZh dGU/IElmIHdlIApleHBvcnQgaXQgaW4gLmggd2UgZG9uJ3QgbmVlZCBoZWxwZXIgdG8gYWNjZXNz IGl0cyBtZW1iZXIgbGlrZSAKdmhvc3Rfc3ZxX2dldF9kZXZfa2lja19ub3RpZmllcigpLgoKTm90 ZSB0aGF0IHZob3N0X2RldiBpcyBhIHB1YmxpYyBzdHJ1Y3R1cmUuCgoKPiArICAgIGZpbGUuZmQg PSBldmVudF9ub3RpZmllcl9nZXRfZmQoZXZlbnRfbm90aWZpZXIpOwo+ICsgICAgciA9IHZob3N0 X3ZkcGFfc2V0X3ZyaW5nX2Rldl9raWNrKGRldiwgJmZpbGUpOwo+ICsgICAgaWYgKHVubGlrZWx5 KHIgIT0gMCkpIHsKPiArICAgICAgICBlcnJvcl9yZXBvcnQoIkNhbid0IHNldCBkZXZpY2Uga2lj ayBmZCAoJWQpIiwgLXIpOwo+ICsgICAgfQoKCkkgd29uZGVyIHdoZXRoZXIgb3Igbm90IHdlIGNh biBnZW5lcmFsaXplIHRoZSBsb2dpYyBoZXJlIGFuZCAKdmhvc3RfdmRwYV9zZXRfdnJpbmdfa2lj aygpLiBUaGVyZSdzIG5vdGhpbmcgdmRwYSBzcGVjaWZpYyB1bmxlc3MgdGhlIAp2aG9zdF9vcHMt PnNldF92cmluZ19raWNrKCkuCgoKPiArCj4gKyAgICByZXR1cm4gciA9PSAwOwo+ICt9Cj4gKwo+ ICAgc3RhdGljIGludCB2aG9zdF92ZHBhX2Rldl9zdGFydChzdHJ1Y3Qgdmhvc3RfZGV2ICpkZXYs IGJvb2wgc3RhcnRlZCkKPiAgIHsKPiAgICAgICBzdHJ1Y3Qgdmhvc3RfdmRwYSAqdiA9IGRldi0+ b3BhcXVlOwo+IEBAIC02NjAsNiArNzI4LDEzIEBAIHN0YXRpYyBpbnQgdmhvc3RfdmRwYV9kZXZf c3RhcnQoc3RydWN0IHZob3N0X2RldiAqZGV2LCBib29sIHN0YXJ0ZWQpCj4gICAKPiAgICAgICBp ZiAoc3RhcnRlZCkgewo+ICAgICAgICAgICB2aG9zdF92ZHBhX2hvc3Rfbm90aWZpZXJzX2luaXQo ZGV2KTsKPiArICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgdi0+c2hhZG93X3Zxcy0+ bGVuOyArK2kpIHsKPiArICAgICAgICAgICAgVmhvc3RTaGFkb3dWaXJ0cXVldWUgKnN2cSA9IGdf cHRyX2FycmF5X2luZGV4KHYtPnNoYWRvd192cXMsIGkpOwo+ICsgICAgICAgICAgICBib29sIG9r ID0gdmhvc3RfdmRwYV9zdnFfc2V0dXAoZGV2LCBzdnEsIGkpOwo+ICsgICAgICAgICAgICBpZiAo dW5saWtlbHkoIW9rKSkgewo+ICsgICAgICAgICAgICAgICAgcmV0dXJuIC0xOwo+ICsgICAgICAg ICAgICB9Cj4gKyAgICAgICAgfQo+ICAgICAgICAgICB2aG9zdF92ZHBhX3NldF92cmluZ19yZWFk eShkZXYpOwo+ICAgICAgIH0gZWxzZSB7Cj4gICAgICAgICAgIHZob3N0X3ZkcGFfaG9zdF9ub3Rp ZmllcnNfdW5pbml0KGRldiwgZGV2LT5udnFzKTsKPiBAQCAtNzM3LDYgKzgxMiw0MSBAQCBzdGF0 aWMgYm9vbCAgdmhvc3RfdmRwYV9mb3JjZV9pb21tdShzdHJ1Y3Qgdmhvc3RfZGV2ICpkZXYpCj4g ICAgICAgcmV0dXJuIHRydWU7Cj4gICB9Cj4gICAKPiArLyoqCj4gKyAqIEFkYXB0b3IgZnVuY3Rp b24gdG8gZnJlZSBzaGFkb3cgdmlydHF1ZXVlIHRocm91Z2ggZ3BvaW50ZXIKPiArICoKPiArICog QHN2cSAgIFRoZSBTaGFkb3cgVmlydHF1ZXVlCj4gKyAqLwo+ICtzdGF0aWMgdm9pZCB2aG9zdF9w c3ZxX2ZyZWUoZ3BvaW50ZXIgc3ZxKQo+ICt7Cj4gKyAgICB2aG9zdF9zdnFfZnJlZShzdnEpOwo+ ICt9CgoKQW55IHJlYXNvbiBmb3Igc3VjaCBpbmRpcmVjdGlvbj8gQ2FuIHdlIHNpbXBseSB1c2Ug dmhvc3Rfc3ZxX2ZyZWUoKT8KClRoYW5rcwoKCj4gKwo+ICtzdGF0aWMgaW50IHZob3N0X3ZkcGFf aW5pdF9zdnEoc3RydWN0IHZob3N0X2RldiAqaGRldiwgc3RydWN0IHZob3N0X3ZkcGEgKnYsCj4g KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBFcnJvciAqKmVycnApCj4gK3sKPiArICAg IHNpemVfdCBuX3N2cXMgPSB2LT5zaGFkb3dfdnFzX2VuYWJsZWQgPyBoZGV2LT5udnFzIDogMDsK PiArICAgIGdfYXV0b3B0cihHUHRyQXJyYXkpIHNoYWRvd192cXMgPSBnX3B0cl9hcnJheV9uZXdf ZnVsbChuX3N2cXMsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgdmhvc3RfcHN2cV9mcmVlKTsKPiArICAgIGlmICghdi0+c2hhZG93 X3Zxc19lbmFibGVkKSB7Cj4gKyAgICAgICAgZ290byBvdXQ7Cj4gKyAgICB9Cj4gKwo+ICsgICAg Zm9yICh1bnNpZ25lZCBuID0gMDsgbiA8IGhkZXYtPm52cXM7ICsrbikgewo+ICsgICAgICAgIFZo b3N0U2hhZG93VmlydHF1ZXVlICpzdnEgPSB2aG9zdF9zdnFfbmV3KCk7Cj4gKwo+ICsgICAgICAg IGlmICh1bmxpa2VseSghc3ZxKSkgewo+ICsgICAgICAgICAgICBlcnJvcl9zZXRnKGVycnAsICJD YW5ub3QgY3JlYXRlIHN2cSAldSIsIG4pOwo+ICsgICAgICAgICAgICByZXR1cm4gLTE7Cj4gKyAg ICAgICAgfQo+ICsgICAgICAgIGdfcHRyX2FycmF5X2FkZCh2LT5zaGFkb3dfdnFzLCBzdnEpOwo+ ICsgICAgfQo+ICsKPiArb3V0Ogo+ICsgICAgdi0+c2hhZG93X3ZxcyA9IGdfc3RlYWxfcG9pbnRl cigmc2hhZG93X3Zxcyk7Cj4gKyAgICByZXR1cm4gMDsKPiArfQo+ICsKPiAgIHN0YXRpYyBpbnQg dmhvc3RfdmRwYV9pbml0KHN0cnVjdCB2aG9zdF9kZXYgKmRldiwgdm9pZCAqb3BhcXVlLCBFcnJv ciAqKmVycnApCj4gICB7Cj4gICAgICAgc3RydWN0IHZob3N0X3ZkcGEgKnY7Cj4gQEAgLTc1OSw2 ICs4NjksMTAgQEAgc3RhdGljIGludCB2aG9zdF92ZHBhX2luaXQoc3RydWN0IHZob3N0X2RldiAq ZGV2LCB2b2lkICpvcGFxdWUsIEVycm9yICoqZXJycCkKPiAgICAgICBkZXYtPm9wYXF1ZSA9ICBv cGFxdWUgOwo+ICAgICAgIHYtPmxpc3RlbmVyID0gdmhvc3RfdmRwYV9tZW1vcnlfbGlzdGVuZXI7 Cj4gICAgICAgdi0+bXNnX3R5cGUgPSBWSE9TVF9JT1RMQl9NU0dfVjI7Cj4gKyAgICByZXQgPSB2 aG9zdF92ZHBhX2luaXRfc3ZxKGRldiwgdiwgZXJycCk7Cj4gKyAgICBpZiAocmV0KSB7Cj4gKyAg ICAgICAgZ290byBlcnI7Cj4gKyAgICB9Cj4gICAKPiAgICAgICB2aG9zdF92ZHBhX2dldF9pb3Zh X3JhbmdlKHYpOwo+ICAgCj4gQEAgLTc3MCw2ICs4ODQsMTAgQEAgc3RhdGljIGludCB2aG9zdF92 ZHBhX2luaXQoc3RydWN0IHZob3N0X2RldiAqZGV2LCB2b2lkICpvcGFxdWUsIEVycm9yICoqZXJy cCkKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBWSVJUSU9fQ09ORklHX1NfRFJJ VkVSKTsKPiAgIAo+ICAgICAgIHJldHVybiAwOwo+ICsKPiArZXJyOgo+ICsgICAgcmFtX2Jsb2Nr X2Rpc2NhcmRfZGlzYWJsZShmYWxzZSk7Cj4gKyAgICByZXR1cm4gcmV0Owo+ICAgfQo+ICAgCj4g ICBjb25zdCBWaG9zdE9wcyB2ZHBhX29wcyA9IHsKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFs aXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91 bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1F08C433F5 for ; Fri, 28 Jan 2022 06:59:55 +0000 (UTC) Received: from localhost ([::1]:41106 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nDLEg-0000z6-M9 for qemu-devel@archiver.kernel.org; Fri, 28 Jan 2022 01:59:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36484) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDLCJ-0007wy-Lm for qemu-devel@nongnu.org; Fri, 28 Jan 2022 01:57:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:57194) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nDLCF-0002V3-RS for qemu-devel@nongnu.org; Fri, 28 Jan 2022 01:57:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643353034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hoR9Y1f2jHonl69jIVjtfl1NZy3bn027LYcSouPHOCA=; b=fseR18MDF3Js2CRRhVCEm/irZ4EgTOO0bTwCWwp8+yVT2MH6FLygvTjgWq0wetK7WEOvO/ dSKtI8+o6srqwMSfTIEBdrV5lUNW41uHTEPch5nvXwNmW0fUg6jv9d2flauUD2SzBDbSaQ JpAOPh/5JKJgHuqJmSnlbvWqq1LUI0E= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-632-vLsXKSQjMS6gisSbm1iKQg-1; Fri, 28 Jan 2022 01:57:13 -0500 X-MC-Unique: vLsXKSQjMS6gisSbm1iKQg-1 Received: by mail-pj1-f72.google.com with SMTP id x4-20020a17090ab00400b001b58c484826so5772809pjq.0 for ; Thu, 27 Jan 2022 22:57:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=hoR9Y1f2jHonl69jIVjtfl1NZy3bn027LYcSouPHOCA=; b=3NZgUJSQplcWUNXj0l4Uo9bxABfYOqlK9hVXilfDebS7LKwsxAKJDztOE69S8MZ4A5 RMSb3ofaJECYGfK/C+phgHmX/wVHqwY80gs+eDFUW0mJBaGtNR+64M2GBQOFsJV26U22 bBuNUpwm6XWwqZaf4AQYp2JXPqRwTYLdvh/0c9jUJywhL841sEcpGbtlGWqr7FCI5Pmc eTh3cBZodOcXyPWQJAmb1T+VpKAI2G8IkLI7u74dXuWli9G8Gc7M1/7FQ7M4IvCnueok 13vNUiFxpN4CJvhEz35HB98f8kYrp9n9g7t9Wnc2wQ2A3aBD4SayUVTYYg3wHE4pa+xO CwOg== X-Gm-Message-State: AOAM533hPPgPba/7SMcwq4QOtyXimyHEjfh32IKug761nvsl2Hu9RKqz Le/wyEdtdfePpIRsMeAmlXMuAORUYl9UWfmL4qdbLsdS39mv3IPcyazS3ai7M3Ngd9OoBSTtteD EnG6sMryPw8E6/Ds= X-Received: by 2002:a17:90b:4a4c:: with SMTP id lb12mr8201281pjb.211.1643353031903; Thu, 27 Jan 2022 22:57:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJzWBbXSw4EH+rGgOI68sTw2G4dwbKWA9R9aZIkj+kSxOGwh1zp8Fv6sWqFo7rwALZOYIqg1aQ== X-Received: by 2002:a17:90b:4a4c:: with SMTP id lb12mr8201250pjb.211.1643353031546; Thu, 27 Jan 2022 22:57:11 -0800 (PST) Received: from [10.72.13.185] ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id mi18sm1282013pjb.35.2022.01.27.22.57.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jan 2022 22:57:10 -0800 (PST) Message-ID: <2cb2415b-7d8b-6187-c202-27e8f26410a4@redhat.com> Date: Fri, 28 Jan 2022 14:56:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 06/31] vhost: Route guest->host notification through shadow virtqueue To: =?UTF-8?Q?Eugenio_P=c3=a9rez?= , qemu-devel@nongnu.org References: <20220121202733.404989-1-eperezma@redhat.com> <20220121202733.404989-7-eperezma@redhat.com> From: Jason Wang In-Reply-To: <20220121202733.404989-7-eperezma@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.167, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Parav Pandit , Cindy Lu , "Michael S. Tsirkin" , Juan Quintela , Richard Henderson , Markus Armbruster , Gautam Dawar , virtualization@lists.linux-foundation.org, Eduardo Habkost , Harpreet Singh Anand , Xiao W Wang , Peter Xu , Stefan Hajnoczi , Eli Cohen , Paolo Bonzini , Zhu Lingshan , Eric Blake , Stefano Garzarella Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 在 2022/1/22 上午4:27, Eugenio Pérez 写道: > At this moment no buffer forwarding will be performed in SVQ mode: Qemu > just forward the guest's kicks to the device. This commit also set up > SVQs in the vhost device. > > Host memory notifiers regions are left out for simplicity, and they will > not be addressed in this series. I wonder if it's better to squash this into patch 5 since it gives us a full guest->host forwarding. > > Signed-off-by: Eugenio Pérez > --- > include/hw/virtio/vhost-vdpa.h | 4 ++ > hw/virtio/vhost-vdpa.c | 122 ++++++++++++++++++++++++++++++++- > 2 files changed, 124 insertions(+), 2 deletions(-) > > diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h > index 3ce79a646d..009a9f3b6b 100644 > --- a/include/hw/virtio/vhost-vdpa.h > +++ b/include/hw/virtio/vhost-vdpa.h > @@ -12,6 +12,8 @@ > #ifndef HW_VIRTIO_VHOST_VDPA_H > #define HW_VIRTIO_VHOST_VDPA_H > > +#include > + > #include "hw/virtio/virtio.h" > #include "standard-headers/linux/vhost_types.h" > > @@ -27,6 +29,8 @@ typedef struct vhost_vdpa { > bool iotlb_batch_begin_sent; > MemoryListener listener; > struct vhost_vdpa_iova_range iova_range; > + bool shadow_vqs_enabled; > + GPtrArray *shadow_vqs; > struct vhost_dev *dev; > VhostVDPAHostNotifier notifier[VIRTIO_QUEUE_MAX]; > } VhostVDPA; > diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c > index 6c10a7f05f..18de14f0fb 100644 > --- a/hw/virtio/vhost-vdpa.c > +++ b/hw/virtio/vhost-vdpa.c > @@ -17,12 +17,14 @@ > #include "hw/virtio/vhost.h" > #include "hw/virtio/vhost-backend.h" > #include "hw/virtio/virtio-net.h" > +#include "hw/virtio/vhost-shadow-virtqueue.h" > #include "hw/virtio/vhost-vdpa.h" > #include "exec/address-spaces.h" > #include "qemu/main-loop.h" > #include "cpu.h" > #include "trace.h" > #include "qemu-common.h" > +#include "qapi/error.h" > > /* > * Return one past the end of the end of section. Be careful with uint64_t > @@ -409,8 +411,14 @@ err: > > static void vhost_vdpa_host_notifiers_init(struct vhost_dev *dev) > { > + struct vhost_vdpa *v = dev->opaque; > int i; > > + if (v->shadow_vqs_enabled) { > + /* SVQ is not compatible with host notifiers mr */ I guess there should be a TODO or FIXME here. > + return; > + } > + > for (i = dev->vq_index; i < dev->vq_index + dev->nvqs; i++) { > if (vhost_vdpa_host_notifier_init(dev, i)) { > goto err; > @@ -424,6 +432,17 @@ err: > return; > } > > +static void vhost_vdpa_svq_cleanup(struct vhost_dev *dev) > +{ > + struct vhost_vdpa *v = dev->opaque; > + size_t idx; > + > + for (idx = 0; idx < v->shadow_vqs->len; ++idx) { > + vhost_svq_stop(g_ptr_array_index(v->shadow_vqs, idx)); > + } > + g_ptr_array_free(v->shadow_vqs, true); > +} > + > static int vhost_vdpa_cleanup(struct vhost_dev *dev) > { > struct vhost_vdpa *v; > @@ -432,6 +451,7 @@ static int vhost_vdpa_cleanup(struct vhost_dev *dev) > trace_vhost_vdpa_cleanup(dev, v); > vhost_vdpa_host_notifiers_uninit(dev, dev->nvqs); > memory_listener_unregister(&v->listener); > + vhost_vdpa_svq_cleanup(dev); > > dev->opaque = NULL; > ram_block_discard_disable(false); > @@ -507,9 +527,15 @@ static int vhost_vdpa_get_device_id(struct vhost_dev *dev, > > static int vhost_vdpa_reset_device(struct vhost_dev *dev) > { > + struct vhost_vdpa *v = dev->opaque; > int ret; > uint8_t status = 0; > > + for (unsigned i = 0; i < v->shadow_vqs->len; ++i) { > + VhostShadowVirtqueue *svq = g_ptr_array_index(v->shadow_vqs, i); > + vhost_svq_stop(svq); > + } > + > ret = vhost_vdpa_call(dev, VHOST_VDPA_SET_STATUS, &status); > trace_vhost_vdpa_reset_device(dev, status); > return ret; > @@ -639,13 +665,28 @@ static int vhost_vdpa_get_vring_base(struct vhost_dev *dev, > return ret; > } > > -static int vhost_vdpa_set_vring_kick(struct vhost_dev *dev, > - struct vhost_vring_file *file) > +static int vhost_vdpa_set_vring_dev_kick(struct vhost_dev *dev, > + struct vhost_vring_file *file) > { > trace_vhost_vdpa_set_vring_kick(dev, file->index, file->fd); > return vhost_vdpa_call(dev, VHOST_SET_VRING_KICK, file); > } > > +static int vhost_vdpa_set_vring_kick(struct vhost_dev *dev, > + struct vhost_vring_file *file) > +{ > + struct vhost_vdpa *v = dev->opaque; > + int vdpa_idx = vhost_vdpa_get_vq_index(dev, file->index); > + > + if (v->shadow_vqs_enabled) { > + VhostShadowVirtqueue *svq = g_ptr_array_index(v->shadow_vqs, vdpa_idx); > + vhost_svq_set_svq_kick_fd(svq, file->fd); > + return 0; > + } else { > + return vhost_vdpa_set_vring_dev_kick(dev, file); > + } > +} > + > static int vhost_vdpa_set_vring_call(struct vhost_dev *dev, > struct vhost_vring_file *file) > { > @@ -653,6 +694,33 @@ static int vhost_vdpa_set_vring_call(struct vhost_dev *dev, > return vhost_vdpa_call(dev, VHOST_SET_VRING_CALL, file); > } > > +/** > + * Set shadow virtqueue descriptors to the device > + * > + * @dev The vhost device model > + * @svq The shadow virtqueue > + * @idx The index of the virtqueue in the vhost device > + */ > +static bool vhost_vdpa_svq_setup(struct vhost_dev *dev, > + VhostShadowVirtqueue *svq, > + unsigned idx) > +{ > + struct vhost_vring_file file = { > + .index = dev->vq_index + idx, > + }; > + const EventNotifier *event_notifier; > + int r; > + > + event_notifier = vhost_svq_get_dev_kick_notifier(svq); A question, any reason for making VhostShadowVirtqueue private? If we export it in .h we don't need helper to access its member like vhost_svq_get_dev_kick_notifier(). Note that vhost_dev is a public structure. > + file.fd = event_notifier_get_fd(event_notifier); > + r = vhost_vdpa_set_vring_dev_kick(dev, &file); > + if (unlikely(r != 0)) { > + error_report("Can't set device kick fd (%d)", -r); > + } I wonder whether or not we can generalize the logic here and vhost_vdpa_set_vring_kick(). There's nothing vdpa specific unless the vhost_ops->set_vring_kick(). > + > + return r == 0; > +} > + > static int vhost_vdpa_dev_start(struct vhost_dev *dev, bool started) > { > struct vhost_vdpa *v = dev->opaque; > @@ -660,6 +728,13 @@ static int vhost_vdpa_dev_start(struct vhost_dev *dev, bool started) > > if (started) { > vhost_vdpa_host_notifiers_init(dev); > + for (unsigned i = 0; i < v->shadow_vqs->len; ++i) { > + VhostShadowVirtqueue *svq = g_ptr_array_index(v->shadow_vqs, i); > + bool ok = vhost_vdpa_svq_setup(dev, svq, i); > + if (unlikely(!ok)) { > + return -1; > + } > + } > vhost_vdpa_set_vring_ready(dev); > } else { > vhost_vdpa_host_notifiers_uninit(dev, dev->nvqs); > @@ -737,6 +812,41 @@ static bool vhost_vdpa_force_iommu(struct vhost_dev *dev) > return true; > } > > +/** > + * Adaptor function to free shadow virtqueue through gpointer > + * > + * @svq The Shadow Virtqueue > + */ > +static void vhost_psvq_free(gpointer svq) > +{ > + vhost_svq_free(svq); > +} Any reason for such indirection? Can we simply use vhost_svq_free()? Thanks > + > +static int vhost_vdpa_init_svq(struct vhost_dev *hdev, struct vhost_vdpa *v, > + Error **errp) > +{ > + size_t n_svqs = v->shadow_vqs_enabled ? hdev->nvqs : 0; > + g_autoptr(GPtrArray) shadow_vqs = g_ptr_array_new_full(n_svqs, > + vhost_psvq_free); > + if (!v->shadow_vqs_enabled) { > + goto out; > + } > + > + for (unsigned n = 0; n < hdev->nvqs; ++n) { > + VhostShadowVirtqueue *svq = vhost_svq_new(); > + > + if (unlikely(!svq)) { > + error_setg(errp, "Cannot create svq %u", n); > + return -1; > + } > + g_ptr_array_add(v->shadow_vqs, svq); > + } > + > +out: > + v->shadow_vqs = g_steal_pointer(&shadow_vqs); > + return 0; > +} > + > static int vhost_vdpa_init(struct vhost_dev *dev, void *opaque, Error **errp) > { > struct vhost_vdpa *v; > @@ -759,6 +869,10 @@ static int vhost_vdpa_init(struct vhost_dev *dev, void *opaque, Error **errp) > dev->opaque = opaque ; > v->listener = vhost_vdpa_memory_listener; > v->msg_type = VHOST_IOTLB_MSG_V2; > + ret = vhost_vdpa_init_svq(dev, v, errp); > + if (ret) { > + goto err; > + } > > vhost_vdpa_get_iova_range(v); > > @@ -770,6 +884,10 @@ static int vhost_vdpa_init(struct vhost_dev *dev, void *opaque, Error **errp) > VIRTIO_CONFIG_S_DRIVER); > > return 0; > + > +err: > + ram_block_discard_disable(false); > + return ret; > } > > const VhostOps vdpa_ops = {