From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/4] sync_file: add a mutex to protect fence and callback members. Date: Tue, 14 Mar 2017 10:13:37 +0100 Message-ID: <2cba21f6-731b-d112-f882-bef66a9b96c9@vodafone.de> References: <20170314005054.7487-1-airlied@gmail.com> <20170314005054.7487-3-airlied@gmail.com> <20170314084521.njkzr2fotknuafyj@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170314084521.njkzr2fotknuafyj@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter , Dave Airlie Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org QW0gMTQuMDMuMjAxNyB1bSAwOTo0NSBzY2hyaWViIERhbmllbCBWZXR0ZXI6Cj4gT24gVHVlLCBN YXIgMTQsIDIwMTcgYXQgMTA6NTA6NTFBTSArMTAwMCwgRGF2ZSBBaXJsaWUgd3JvdGU6Cj4+IEZy b206IERhdmUgQWlybGllIDxhaXJsaWVkQHJlZGhhdC5jb20+Cj4+Cj4+IFRoaXMgaXNuJ3QgbmVl ZGVkIGN1cnJlbnRseSwgYnV0IHRvIHJldXNlIHN5bmMgZmlsZSBmb3IgVnVsa2FuCj4+IHBlcm1h bmVudCBzaGFyZWQgc2VtYXBob3JlIHNlbWFudGljcywgd2UgbmVlZCB0byBiZSBhYmxlIHRvIHN3 YXAKPj4gdGhlIGZlbmNlIGJhY2tpbmcgYSBzeW5jIGZpbGUuIFRoaXMgcGF0Y2ggYWRkcyBhIG11 dGV4IHRvIHRoZQo+PiBzeW5jIGZpbGUgYW5kIHVzZXMgdG8gcHJvdGVjdCBhY2Nlc3NlcyB0byB0 aGUgZmVuY2UgYW5kIGNiIG1lbWJlcnMuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IERhdmUgQWlybGll IDxhaXJsaWVkQHJlZGhhdC5jb20+Cj4gV2UndmUgZ29uZSB0byBwcmV0dHkgZ3JlYXQgbGVuZ3Ro cyB0byByY3UtcHJvdGVjdCBhbGwgdGhlIGZlbmNlIHN0dWZmLCBzbwo+IHRoYXQgYSBwZWVrLW9u bHkgaXMgZW50aXJlbHkgbG9ja2xlc3MuIENhbiB3ZSBoYXogdGhlIHNhbWUgZm9yIHRoaXMgcGxz PwoKWWVzLCBqdXN0IHdhbnRlZCB0byBzdWdnZXN0IHRoZSBzYW1lIHRoaW5nLgoKQmFzaWNhbGx5 IHlvdSBqdXN0IG5lZWQgdGhlIGZvbGxvd2luZyB0byByZXRyaWV2ZSB0aGUgZmVuY2U6Cgp3aGls ZSAoc3luY19maWxlLT5mZW5jZSAmJiAhKGZlbmNlID0gZmVuY2VfZ2V0X3JjdShzeW5jX2ZpbGUt PmZlbmNlKSk7CgpBbmQgdGhlbiBvbmx5IHRha2luZyBhIGxvb2sgd2hlbiByZXBsYWNpbmcgaXQu Cgo+IFllcyBJIGtub3cgaXQncyBwcm9iYWJseSBnb2luZyB0byBiZSBzbGlnaHRseSBuYXN0eSB3 aGVuIHlvdSBnZXQgYXJvdW5kIHRvCj4gaW1wbGVtZW50aW5nIHRoZSByZXBsYWNlbWVudCBsb2dp Yy4gRm9yIGp1c3Qgbm9ybWFsIGZlbmNlcyB3ZSBjYW4gcHJvYmFibHkKPiBnZXQgYXdheSB3aXRo IG5vdCBkb2luZyBhbiByY3UgZGFuY2Ugd2hlbiBmcmVlaW5nIGl0LCBzaW5jZSB0aGUKPiByZWZj b3VudGluZyBzaG91bGQgcHJvdGVjdCB1cyBhbHJlYWR5LgoKVGhlIG9ubHkgdHJpY2t5IHRoaW5n IEkgY2FuIHNlZSBpcyB0aGUgZmVuY2VfY2FsbGJhY2sgc3RydWN0dXJlIGluIHRoZSAKc3luYyBm aWxlLiBBbmQgdGhhdCBjYW4gYmUgaGFuZGxlZCB3aGlsZSBob2xkaW5nIHRoZSBsb2NrIGluIHRo ZSByZXBsYWNlIApmdW5jdGlvbi4KCj4gQnV0IGZvciB0aGUgcmVwbGFjZW1lbnQgeW91IG5lZWQg dG8gaGF2ZSBhbiByY3UtZGVsYXllZCBmZW5jZV9wdXQgb24gdGhlCj4gb2xkIGZlbmNlcy4KCkZy ZWVpbmcgZmVuY2VzIGlzIFJDVSBzYXZlIGFueXdheSwgc2VlIHRoZSBkZWZhdWx0IGltcGxlbWVu dGF0aW9uIG9mIApmZW5jZV9mcmVlKCkuCgpIYWQgdG8gZml4IHRoYXQgaW4gYW1kZ3B1IGFuZCBy YWRlb24gYmVjYXVzZSBvdXIgcHJpdmF0ZSBpbXBsZW1lbnRhdGlvbiAKd2Fzbid0IFJDVSBzYXZl IGFuZCB3ZSBydW4gaW50byBwcm9ibGVtcyBiZWNhdXNlIG9mIHRoYXQuCgpTbyBhdCBsZWFzdCB0 aGF0IHNob3VsZCBhbHJlYWR5IGJlZW4gdGFrZW4gY2FyZSBvZi4KCkNocmlzdGlhbi4KCj4gLURh bmllbAo+PiAtLS0KPj4gICBkcml2ZXJzL2RtYS1idWYvc3luY19maWxlLmMgfCAyMyArKysrKysr KysrKysrKysrKysrLS0tLQo+PiAgIGluY2x1ZGUvbGludXgvc3luY19maWxlLmggICB8ICAzICsr Kwo+PiAgIDIgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkK Pj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZG1hLWJ1Zi9zeW5jX2ZpbGUuYyBiL2RyaXZlcnMv ZG1hLWJ1Zi9zeW5jX2ZpbGUuYwo+PiBpbmRleCAyMzIxMDM1Li4xMDVmNDhjIDEwMDY0NAo+PiAt LS0gYS9kcml2ZXJzL2RtYS1idWYvc3luY19maWxlLmMKPj4gKysrIGIvZHJpdmVycy9kbWEtYnVm L3N5bmNfZmlsZS5jCj4+IEBAIC00Nyw2ICs0Nyw3IEBAIHN0YXRpYyBzdHJ1Y3Qgc3luY19maWxl ICpzeW5jX2ZpbGVfYWxsb2Modm9pZCkKPj4gICAKPj4gICAJSU5JVF9MSVNUX0hFQUQoJnN5bmNf ZmlsZS0+Y2Iubm9kZSk7Cj4+ICAgCj4+ICsJbXV0ZXhfaW5pdCgmc3luY19maWxlLT5sb2NrKTsK Pj4gICAJcmV0dXJuIHN5bmNfZmlsZTsKPj4gICAKPj4gICBlcnI6Cj4+IEBAIC0yMDQsMTAgKzIw NSwxMyBAQCBzdGF0aWMgc3RydWN0IHN5bmNfZmlsZSAqc3luY19maWxlX21lcmdlKGNvbnN0IGNo YXIgKm5hbWUsIHN0cnVjdCBzeW5jX2ZpbGUgKmEsCj4+ICAgCWlmICghc3luY19maWxlKQo+PiAg IAkJcmV0dXJuIE5VTEw7Cj4+ICAgCj4+ICsJbXV0ZXhfbG9jaygmYS0+bG9jayk7Cj4+ICsJbXV0 ZXhfbG9jaygmYi0+bG9jayk7Cj4+ICAgCWFfZmVuY2VzID0gZ2V0X2ZlbmNlcyhhLCAmYV9udW1f ZmVuY2VzKTsKPj4gICAJYl9mZW5jZXMgPSBnZXRfZmVuY2VzKGIsICZiX251bV9mZW5jZXMpOwo+ PiAtCWlmIChhX251bV9mZW5jZXMgPiBJTlRfTUFYIC0gYl9udW1fZmVuY2VzKQo+PiAtCQlyZXR1 cm4gTlVMTDsKPj4gKwlpZiAoYV9udW1fZmVuY2VzID4gSU5UX01BWCAtIGJfbnVtX2ZlbmNlcykg ewo+PiArCQlnb3RvIHVubG9jazsKPj4gKwl9Cj4+ICAgCj4+ICAgCW51bV9mZW5jZXMgPSBhX251 bV9mZW5jZXMgKyBiX251bV9mZW5jZXM7Cj4+ICAgCj4+IEBAIC0yNjgsMTEgKzI3MiwxNyBAQCBz dGF0aWMgc3RydWN0IHN5bmNfZmlsZSAqc3luY19maWxlX21lcmdlKGNvbnN0IGNoYXIgKm5hbWUs IHN0cnVjdCBzeW5jX2ZpbGUgKmEsCj4+ICAgCQlnb3RvIGVycjsKPj4gICAJfQo+PiAgIAo+PiAr CW11dGV4X3VubG9jaygmYi0+bG9jayk7Cj4+ICsJbXV0ZXhfdW5sb2NrKCZhLT5sb2NrKTsKPj4g Kwo+PiAgIAlzdHJsY3B5KHN5bmNfZmlsZS0+bmFtZSwgbmFtZSwgc2l6ZW9mKHN5bmNfZmlsZS0+ bmFtZSkpOwo+PiAgIAlyZXR1cm4gc3luY19maWxlOwo+PiAgIAo+PiAgIGVycjoKPj4gICAJZnB1 dChzeW5jX2ZpbGUtPmZpbGUpOwo+PiArdW5sb2NrOgo+PiArCW11dGV4X3VubG9jaygmYi0+bG9j ayk7Cj4+ICsJbXV0ZXhfdW5sb2NrKCZhLT5sb2NrKTsKPj4gICAJcmV0dXJuIE5VTEw7Cj4+ICAg Cj4+ICAgfQo+PiBAQCAtMjk5LDE2ICszMDksMjAgQEAgc3RhdGljIGludCBzeW5jX2ZpbGVfcmVs ZWFzZShzdHJ1Y3QgaW5vZGUgKmlub2RlLCBzdHJ1Y3QgZmlsZSAqZmlsZSkKPj4gICBzdGF0aWMg dW5zaWduZWQgaW50IHN5bmNfZmlsZV9wb2xsKHN0cnVjdCBmaWxlICpmaWxlLCBwb2xsX3RhYmxl ICp3YWl0KQo+PiAgIHsKPj4gICAJc3RydWN0IHN5bmNfZmlsZSAqc3luY19maWxlID0gZmlsZS0+ cHJpdmF0ZV9kYXRhOwo+PiArCXVuc2lnbmVkIGludCByZXRfdmFsOwo+PiAgIAo+PiAgIAlwb2xs X3dhaXQoZmlsZSwgJnN5bmNfZmlsZS0+d3EsIHdhaXQpOwo+PiAgIAo+PiArCW11dGV4X2xvY2so JnN5bmNfZmlsZS0+bG9jayk7Cj4+ICAgCWlmICghdGVzdF9hbmRfc2V0X2JpdChQT0xMX0VOQUJM RUQsICZzeW5jX2ZpbGUtPmZlbmNlLT5mbGFncykpIHsKPj4gICAJCWlmIChkbWFfZmVuY2VfYWRk X2NhbGxiYWNrKHN5bmNfZmlsZS0+ZmVuY2UsICZzeW5jX2ZpbGUtPmNiLAo+PiAgIAkJCQkJICAg ZmVuY2VfY2hlY2tfY2JfZnVuYykgPCAwKQo+PiAgIAkJCXdha2VfdXBfYWxsKCZzeW5jX2ZpbGUt PndxKTsKPj4gICAJfQo+PiArCXJldF92YWwgPSBkbWFfZmVuY2VfaXNfc2lnbmFsZWQoc3luY19m aWxlLT5mZW5jZSkgPyBQT0xMSU4gOiAwOwo+PiArCW11dGV4X3VubG9jaygmc3luY19maWxlLT5s b2NrKTsKPj4gICAKPj4gLQlyZXR1cm4gZG1hX2ZlbmNlX2lzX3NpZ25hbGVkKHN5bmNfZmlsZS0+ ZmVuY2UpID8gUE9MTElOIDogMDsKPj4gKwlyZXR1cm4gcmV0X3ZhbDsKPj4gICB9Cj4+ICAgCj4+ ICAgc3RhdGljIGxvbmcgc3luY19maWxlX2lvY3RsX21lcmdlKHN0cnVjdCBzeW5jX2ZpbGUgKnN5 bmNfZmlsZSwKPj4gQEAgLTM5Myw2ICs0MDcsNyBAQCBzdGF0aWMgbG9uZyBzeW5jX2ZpbGVfaW9j dGxfZmVuY2VfaW5mbyhzdHJ1Y3Qgc3luY19maWxlICpzeW5jX2ZpbGUsCj4+ICAgCWlmIChpbmZv LmZsYWdzIHx8IGluZm8ucGFkKQo+PiAgIAkJcmV0dXJuIC1FSU5WQUw7Cj4+ICAgCj4+ICsJbXV0 ZXhfbG9jaygmc3luY19maWxlLT5sb2NrKTsKPj4gICAJZmVuY2VzID0gZ2V0X2ZlbmNlcyhzeW5j X2ZpbGUsICZudW1fZmVuY2VzKTsKPj4gICAKPj4gICAJLyoKPj4gQEAgLTQzMyw3ICs0NDgsNyBA QCBzdGF0aWMgbG9uZyBzeW5jX2ZpbGVfaW9jdGxfZmVuY2VfaW5mbyhzdHJ1Y3Qgc3luY19maWxl ICpzeW5jX2ZpbGUsCj4+ICAgCj4+ICAgb3V0Ogo+PiAgIAlrZnJlZShmZW5jZV9pbmZvKTsKPj4g LQo+PiArCW11dGV4X3VubG9jaygmc3luY19maWxlLT5sb2NrKTsKPj4gICAJcmV0dXJuIHJldDsK Pj4gICB9Cj4+ICAgCj4+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2xpbnV4L3N5bmNfZmlsZS5oIGIv aW5jbHVkZS9saW51eC9zeW5jX2ZpbGUuaAo+PiBpbmRleCAzZTNhYjg0Li41YWVmMTdmIDEwMDY0 NAo+PiAtLS0gYS9pbmNsdWRlL2xpbnV4L3N5bmNfZmlsZS5oCj4+ICsrKyBiL2luY2x1ZGUvbGlu dXgvc3luY19maWxlLmgKPj4gQEAgLTMwLDYgKzMwLDcgQEAKPj4gICAgKiBAd3E6CQkJd2FpdCBx dWV1ZSBmb3IgZmVuY2Ugc2lnbmFsaW5nCj4+ICAgICogQGZlbmNlOgkJZmVuY2Ugd2l0aCB0aGUg ZmVuY2VzIGluIHRoZSBzeW5jX2ZpbGUKPj4gICAgKiBAY2I6CQkJZmVuY2UgY2FsbGJhY2sgaW5m b3JtYXRpb24KPj4gKyAqIEBsb2NrOiAgICAgICAgICAgICAgIG11dGV4IHRvIHByb3RlY3QgZmVu Y2UvY2IgLSB1c2VkIGZvciBzZW1hcGhvcmVzCj4+ICAgICovCj4+ICAgc3RydWN0IHN5bmNfZmls ZSB7Cj4+ICAgCXN0cnVjdCBmaWxlCQkqZmlsZTsKPj4gQEAgLTQzLDYgKzQ0LDggQEAgc3RydWN0 IHN5bmNfZmlsZSB7Cj4+ICAgCj4+ICAgCXN0cnVjdCBkbWFfZmVuY2UJKmZlbmNlOwo+PiAgIAlz dHJ1Y3QgZG1hX2ZlbmNlX2NiIGNiOwo+PiArCS8qIHByb3RlY3RzIHRoZSBmZW5jZSBwb2ludGVy IGFuZCBjYiAqLwo+PiArCXN0cnVjdCBtdXRleCBsb2NrOwo+PiAgIH07Cj4+ICAgCj4+ICAgI2Rl ZmluZSBQT0xMX0VOQUJMRUQgRE1BX0ZFTkNFX0ZMQUdfVVNFUl9CSVRTCj4+IC0tIAo+PiAyLjcu NAo+Pgo+PiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ PiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK