From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759774AbdAJIfO (ORCPT ); Tue, 10 Jan 2017 03:35:14 -0500 Received: from lucky1.263xmail.com ([211.157.147.133]:35104 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756687AbdAJIfM (ORCPT ); Tue, 10 Jan 2017 03:35:12 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: kernel-janitors@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: <07a327c51ad8362efd0497fc6f4f208a> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 5/8] mmc/core/mmc_test: Combine substrings for 5 messages To: SF Markus Elfring , linux-mmc@vger.kernel.org, Adrian Hunter , Harjani Ritesh , Jens Axboe , Linus Walleij , Mike Christie , Ulf Hansson , Wolfram Sang References: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> <2841f26b-325f-bf13-a91c-5bbc125b0f8c@users.sourceforge.net> Cc: shawn.lin@rock-chips.com, LKML , kernel-janitors@vger.kernel.org From: Shawn Lin Message-ID: <2cbc7cac-ac3c-e6ee-7a96-827b4df0adb9@rock-chips.com> Date: Tue, 10 Jan 2017 16:34:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <2841f26b-325f-bf13-a91c-5bbc125b0f8c@users.sourceforge.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/1/9 5:47, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 8 Jan 2017 20:56:48 +0100 > > The script "checkpatch.pl" pointed information out like the following. > > WARNING: quoted string split across lines > yup, the print shouldn't blindly split itself to shut up "WARNING: line over 80 characters" . FWIW, Reviewed-by: Shawn Lin > Thus fix affected source code places. > > Signed-off-by: Markus Elfring > --- > drivers/mmc/core/mmc_test.c | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-) > > diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c > index 42aefd3df09b..bb9f569a5dd5 100644 > --- a/drivers/mmc/core/mmc_test.c > +++ b/drivers/mmc/core/mmc_test.c > @@ -277,8 +277,7 @@ static int mmc_test_wait_busy(struct mmc_test_card *test) > if (!busy && mmc_test_busy(&cmd)) { > busy = 1; > if (test->card->host->caps & MMC_CAP_WAIT_WHILE_BUSY) > - pr_info("%s: Warning: Host did not " > - "wait for busy state to end.\n", > + pr_info("%s: Warning: Host did not wait for busy state to end.\n", > mmc_hostname(test->card->host)); > } > } while (mmc_test_busy(&cmd)); > @@ -2967,8 +2966,7 @@ static void mmc_test_run(struct mmc_test_card *test, int testcase) > if (mmc_test_cases[i].prepare) { > ret = mmc_test_cases[i].prepare(test); > if (ret) { > - pr_info("%s: Result: Prepare " > - "stage failed! (%d)\n", > + pr_info("%s: Result: Prepare stage failed! (%d)\n", > mmc_hostname(test->card->host), > ret); > continue; > @@ -3005,13 +3003,11 @@ static void mmc_test_run(struct mmc_test_card *test, int testcase) > mmc_hostname(test->card->host)); > break; > case RESULT_UNSUP_HOST: > - pr_info("%s: Result: UNSUPPORTED " > - "(by host)\n", > + pr_info("%s: Result: UNSUPPORTED (by host)\n", > mmc_hostname(test->card->host)); > break; > case RESULT_UNSUP_CARD: > - pr_info("%s: Result: UNSUPPORTED " > - "(by card)\n", > + pr_info("%s: Result: UNSUPPORTED (by card)\n", > mmc_hostname(test->card->host)); > break; > default: > @@ -3026,8 +3022,7 @@ static void mmc_test_run(struct mmc_test_card *test, int testcase) > if (mmc_test_cases[i].cleanup) { > ret = mmc_test_cases[i].cleanup(test); > if (ret) { > - pr_info("%s: Warning: Cleanup " > - "stage failed! (%d)\n", > + pr_info("%s: Warning: Cleanup stage failed! (%d)\n", > mmc_hostname(test->card->host), > ret); > } > -- Best Regards Shawn Lin From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Lin Date: Tue, 10 Jan 2017 08:34:17 +0000 Subject: Re: [PATCH 5/8] mmc/core/mmc_test: Combine substrings for 5 messages Message-Id: <2cbc7cac-ac3c-e6ee-7a96-827b4df0adb9@rock-chips.com> List-Id: References: <8e2accf5-90b3-6bd0-2abd-699927bc459b@users.sourceforge.net> <2841f26b-325f-bf13-a91c-5bbc125b0f8c@users.sourceforge.net> In-Reply-To: <2841f26b-325f-bf13-a91c-5bbc125b0f8c@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , linux-mmc@vger.kernel.org, Adrian Hunter , Harjani Ritesh , Jens Axboe , Linus Walleij , Mike Christie , Ulf Hansson , Wolfram Sang Cc: shawn.lin@rock-chips.com, LKML , kernel-janitors@vger.kernel.org On 2017/1/9 5:47, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 8 Jan 2017 20:56:48 +0100 > > The script "checkpatch.pl" pointed information out like the following. > > WARNING: quoted string split across lines > yup, the print shouldn't blindly split itself to shut up "WARNING: line over 80 characters" . FWIW, Reviewed-by: Shawn Lin > Thus fix affected source code places. > > Signed-off-by: Markus Elfring > --- > drivers/mmc/core/mmc_test.c | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-) > > diff --git a/drivers/mmc/core/mmc_test.c b/drivers/mmc/core/mmc_test.c > index 42aefd3df09b..bb9f569a5dd5 100644 > --- a/drivers/mmc/core/mmc_test.c > +++ b/drivers/mmc/core/mmc_test.c > @@ -277,8 +277,7 @@ static int mmc_test_wait_busy(struct mmc_test_card *test) > if (!busy && mmc_test_busy(&cmd)) { > busy = 1; > if (test->card->host->caps & MMC_CAP_WAIT_WHILE_BUSY) > - pr_info("%s: Warning: Host did not " > - "wait for busy state to end.\n", > + pr_info("%s: Warning: Host did not wait for busy state to end.\n", > mmc_hostname(test->card->host)); > } > } while (mmc_test_busy(&cmd)); > @@ -2967,8 +2966,7 @@ static void mmc_test_run(struct mmc_test_card *test, int testcase) > if (mmc_test_cases[i].prepare) { > ret = mmc_test_cases[i].prepare(test); > if (ret) { > - pr_info("%s: Result: Prepare " > - "stage failed! (%d)\n", > + pr_info("%s: Result: Prepare stage failed! (%d)\n", > mmc_hostname(test->card->host), > ret); > continue; > @@ -3005,13 +3003,11 @@ static void mmc_test_run(struct mmc_test_card *test, int testcase) > mmc_hostname(test->card->host)); > break; > case RESULT_UNSUP_HOST: > - pr_info("%s: Result: UNSUPPORTED " > - "(by host)\n", > + pr_info("%s: Result: UNSUPPORTED (by host)\n", > mmc_hostname(test->card->host)); > break; > case RESULT_UNSUP_CARD: > - pr_info("%s: Result: UNSUPPORTED " > - "(by card)\n", > + pr_info("%s: Result: UNSUPPORTED (by card)\n", > mmc_hostname(test->card->host)); > break; > default: > @@ -3026,8 +3022,7 @@ static void mmc_test_run(struct mmc_test_card *test, int testcase) > if (mmc_test_cases[i].cleanup) { > ret = mmc_test_cases[i].cleanup(test); > if (ret) { > - pr_info("%s: Warning: Cleanup " > - "stage failed! (%d)\n", > + pr_info("%s: Warning: Cleanup stage failed! (%d)\n", > mmc_hostname(test->card->host), > ret); > } > -- Best Regards Shawn Lin