From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 830BBC433EF for ; Wed, 22 Sep 2021 14:12:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 638CD60F56 for ; Wed, 22 Sep 2021 14:12:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236045AbhIVONv (ORCPT ); Wed, 22 Sep 2021 10:13:51 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:33814 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233513AbhIVONs (ORCPT ); Wed, 22 Sep 2021 10:13:48 -0400 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 007CB3F302 for ; Wed, 22 Sep 2021 14:12:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632319937; bh=1MyjqmNhxVLX0Wufgh2lr5w4a4DBCWtXfhO1i67wwOg=; h=Subject:To:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=eGKcXmt+UmBN/fiWfI3D01Ya4GFC28k+tp3WzB/b+nV8eSryIdDkaq74yrmNxP/W6 ZL0wz3v3LV0P8c16nWHEnGgQMZwNkBoyXj2lFoFjmUi4ks1RpLZPE5gvbejxBXWLaS c6gSBlCtWse66wiDvrgLvYwRrcq9P/hLfE8RmPRuPuw3p2e84nRZMlIPoweDEp+pyi 0a5aTtyHG96S5vPfrBd0/RhcX5jXuEHsa7XF11wHy7pcKDO5meVilHrJAhrg2x6pfX GyhUJhj1IPmyA4nU57LB23xa6xQhJxFTMjqx3Y6IAVArV13tEZ0cyW2jq/HtLKBp1Y A3aJYtHBlYlBg== Received: by mail-ed1-f71.google.com with SMTP id z6-20020a50cd06000000b003d2c2e38f1fso3267627edi.1 for ; Wed, 22 Sep 2021 07:12:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1MyjqmNhxVLX0Wufgh2lr5w4a4DBCWtXfhO1i67wwOg=; b=0NJQImr7k4tHdIr0rssDCXQvXghzyaMjB54Nojh1sUGVbUfZju+8hUj5lJ4N0L7n0M NkN0Q9eHSBUn/eR+XRCtAUQ986+QfZdDyosGI6SX48hF3rFi6MMiAzhad867Nxa6jCP7 nPu8cyi4f+7QeF5Bd+7WTEE881mEsfVanJqGkox0h1TPFqPQ3mmO0HvkHGWPI/eUpQNl tU4PF2Pqnw5WBoPQhI1IBCs97BKF1KJPmuGOfmhE31I5AaAJ/bttFPa38FC5KaxUdDzw KQMRWcyqx5gvXGJYsPLVcp2eE12OZTqzECL0SvvvOc2hQZTbvHnQ7mMAsjmr0L6m8a0/ tHgA== X-Gm-Message-State: AOAM533FJH97J/fDUMk9rNxHOsynCaAZzZrRN7GzdxjxHC+GeVKhAAUn B+zbOwgHIc3KyIr1GF4C20Ff9MNcHgPy7UMr4drbrXAJiumsul9EPqcctnwe5qOlX88ZJmjFkDk E7ox2JS+KJFyV/o3R2QU1hK2vfl6rWOyRChdIlEU8Yg== X-Received: by 2002:a17:906:9452:: with SMTP id z18mr41241567ejx.25.1632319935033; Wed, 22 Sep 2021 07:12:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLJOGVcmp4cOqCkF2TmMYwWKyogj1WUZOHnXr8vCsNJVqDjhbsu8od+4HSV9f8jRwxTRDePA== X-Received: by 2002:a17:906:9452:: with SMTP id z18mr41241545ejx.25.1632319934825; Wed, 22 Sep 2021 07:12:14 -0700 (PDT) Received: from [192.168.0.134] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id bw25sm1150757ejb.20.2021.09.22.07.12.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Sep 2021 07:12:14 -0700 (PDT) Subject: Re: [RESEND PATCH 2/2] powerpc/powermac: constify device_node in of_irq_parse_oldworld() To: Christophe Leroy , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Rob Herring , Frank Rowand , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20210922084415.18269-1-krzysztof.kozlowski@canonical.com> <20210922084415.18269-2-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski Message-ID: <2ccf5861-257f-42cc-395f-4d1f053f6035@canonical.com> Date: Wed, 22 Sep 2021 16:12:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/09/2021 15:55, Christophe Leroy wrote: > > > Le 22/09/2021 à 10:44, Krzysztof Kozlowski a écrit : >> The of_irq_parse_oldworld() does not modify passed device_node so make >> it a pointer to const for safety. > > AFAIKS this patch is unrelated to previous one so you should send them > out separately instead of sending as a series. The relation it's a series of bugfixes. Although they can be applied independently, having a series is actually very useful - you run "b4 am" on one message ID and get everything. The same with patchwork, if you use that one. > >> >> Signed-off-by: Krzysztof Kozlowski >> --- >> arch/powerpc/platforms/powermac/pic.c | 2 +- >> include/linux/of_irq.h | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/powerpc/platforms/powermac/pic.c b/arch/powerpc/platforms/powermac/pic.c >> index 4921bccf0376..af5ca1f41bb1 100644 >> --- a/arch/powerpc/platforms/powermac/pic.c >> +++ b/arch/powerpc/platforms/powermac/pic.c >> @@ -384,7 +384,7 @@ static void __init pmac_pic_probe_oldstyle(void) >> #endif >> } >> >> -int of_irq_parse_oldworld(struct device_node *device, int index, >> +int of_irq_parse_oldworld(const struct device_node *device, int index, >> struct of_phandle_args *out_irq) >> { >> const u32 *ints = NULL; >> diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h >> index aaf219bd0354..6074fdf51f0c 100644 >> --- a/include/linux/of_irq.h >> +++ b/include/linux/of_irq.h >> @@ -20,12 +20,12 @@ typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *); >> #if defined(CONFIG_PPC32) && defined(CONFIG_PPC_PMAC) >> extern unsigned int of_irq_workarounds; >> extern struct device_node *of_irq_dflt_pic; >> -extern int of_irq_parse_oldworld(struct device_node *device, int index, >> +extern int of_irq_parse_oldworld(const struct device_node *device, int index, >> struct of_phandle_args *out_irq); > > Please remove 'extern' which is useless for prototypes. OK Best regards, Krzysztof