From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 720B2C433EF for ; Mon, 23 May 2022 13:07:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235929AbiEWNHI (ORCPT ); Mon, 23 May 2022 09:07:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236045AbiEWNHA (ORCPT ); Mon, 23 May 2022 09:07:00 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 579A849C87 for ; Mon, 23 May 2022 06:06:57 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id s5so17110743ljd.10 for ; Mon, 23 May 2022 06:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=50wuqx97QXZx2zbLRPpUZaCAf982O497zw+lzOUq1k4=; b=SDuGMgEXCGQ1TJ0fNHdXQPIRrrbTcF5QRnV15Th8wlnm6ALDsCXQkDhSc30CAXl9Kp lUcwwo8YPG+ToK1ghL+xsLwZPbKsU3Xs5fTm4yRb1VvjTdISvp+ik2qXsRARg60MQYWC GzqnvLsPLHQQ9m8qRk3NoJy44Um8tv0iazTe+dReBMGQpIWhXgY7sW+X5Q92sAdYY4Up yPMCEKh8i9Ozg5XgOdN0UxNO4J+QgBEZh3/Z8fVZf4cnzrU5tlx9D2h6JrtHwCIXtkCT BYpUW9KmlugPMvChcIWuNOw5mvQnQfIPUm4rq/I+cIqgIavTpZd0JMU/RlcgqLJUgwvk OYWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=50wuqx97QXZx2zbLRPpUZaCAf982O497zw+lzOUq1k4=; b=RcSQdzOnJri1WMWWbrikuYmAyl7U5skAmkrJ/u4IdsLd3CHlCWBhwH4TL2NiWCmBH1 IC9eq+/OF4FgSuH7fT+gHbAx3MHPh4EGG+FnYK6mGjNyo/Sl7pIjEWunaQ2Xwgwm7+pK 7l6a1l282XlDqx0LpEv0+bblPJd+5DtPm8s5nzdlgwmLPGM4CpFGEabFurI7X93+Qmgs lHQ1HGOzXrOMFC6NOwJ16JExCHpd1no5EjfCoslTFAFS4tMeBS30bhBgE8EEvpASdSLD flThrpPAislRwHMOJbclN5/Y7AGuaLrlqIzjwR0mlKBb0tk58IoGDbBUVpiU3tPAhOhW lAvg== X-Gm-Message-State: AOAM530hTa5aAVA/x3dTe5a1zaFrQR9+tHc3nnKTU2vnQ5D58WOmjja8 IjhU6xE3yCBRf08GRCwoQVKSUQ== X-Google-Smtp-Source: ABdhPJxW/DBrlG7TEnvWEUg0Nipmvi6wS+g8Y+NMEBmjLhpKfeu4xjRK3q520VX+9jaURA7ei9otVw== X-Received: by 2002:a2e:a26d:0:b0:253:d7b4:1d9a with SMTP id k13-20020a2ea26d000000b00253d7b41d9amr11639775ljm.203.1653311215543; Mon, 23 May 2022 06:06:55 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id c6-20020ac24146000000b00477b0cfc990sm1968975lfi.30.2022.05.23.06.06.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 06:06:55 -0700 (PDT) Message-ID: <2ccfbfa8-be11-50ed-66ca-3476cbddb320@linaro.org> Date: Mon, 23 May 2022 15:06:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v1 04/19] tty: serial: 8250: Add NPCM845 UART support Content-Language: en-US To: Tomer Maimon , Arnd Bergmann Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , gregkh , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Olof Johansson , Jiri Slaby , Shawn Guo , Bjorn Andersson , Geert Uytterhoeven , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , robert.hancock@calian.com, nathan=20Neusch=C3=A4fer?= , Lubomir Rintel , SoC Team , DTML , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM References: <20220522155046.260146-1-tmaimon77@gmail.com> <20220522155046.260146-5-tmaimon77@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/05/2022 14:58, Tomer Maimon wrote: > Hi Arnd, > > Thanks for your comment. > > On Mon, 23 May 2022 at 14:48, Arnd Bergmann > wrote: > > On Sun, May 22, 2022 at 5:50 PM Tomer Maimon > wrote: > > +++ b/drivers/tty/serial/8250/8250_of.c > > @@ -333,6 +333,7 @@ static const struct of_device_id > of_platform_serial_table[] = { > >         { .compatible = "ti,da830-uart", .data = (void > *)PORT_DA830, }, > >         { .compatible = "nuvoton,wpcm450-uart", .data = (void > *)PORT_NPCM, }, > >         { .compatible = "nuvoton,npcm750-uart", .data = (void > *)PORT_NPCM, }, > > +       { .compatible = "nuvoton,npcm845-uart", .data = (void > *)PORT_NPCM, }, > >         { /* end of list */ }, > > If these are compatible devices, it's usually easier to claim > compatibility with both the specific chip and the older model > as a fallback, to avoid driver changes. This seems to apply to > the timer and watchdog devices as well. > > Just to make sure, Do you mean claim in the device tree? > like > > compatible = "nuvoton,npcm845-timer", "nuvoton,npcm-timer"; compatible = "nuvoton,npcm845-timer", "nuvoton,npcm750-timer""; Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9EDCC433EF for ; Mon, 23 May 2022 13:08:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3NkWNC52WFlrE4r+ndDqjZH4q6tOSBahH4SJhH+wlTQ=; b=yw/88khHdUu5do jNMPKIQDtrPBgKwxvvxK3H/hU46rdmClxzK6mwQ76aNyYmGn2ANk1vyCpYqSNCSlfIJ1lyShF2OOa 9ODKJ5+AmKT+coqjVVBkv7Msap/rAOV3MSSiTy73pcAMYtKJNId389kSOyDm/lwAVti/70AdokMS5 2CVrb/I0bzI2sfMurzTHpoaE9wlC6SH81TQ+jLRtxjrj98OQwArcSeGec1kvRsuG9i0GkZN1ak9xf im7ZeauCl7bG7EqHeRlDDRaLnCFeQ9LADj652rx9NSy08anh9pH8ppwboEDZ0bG3yHpCvVuNV/W8A 0HTU6mbgomZbqwKOT5Jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt7m2-004JzE-Kw; Mon, 23 May 2022 13:07:02 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt7lz-004Jy3-DE for linux-arm-kernel@lists.infradead.org; Mon, 23 May 2022 13:07:00 +0000 Received: by mail-lj1-x22f.google.com with SMTP id u7so16422758ljd.11 for ; Mon, 23 May 2022 06:06:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=50wuqx97QXZx2zbLRPpUZaCAf982O497zw+lzOUq1k4=; b=SDuGMgEXCGQ1TJ0fNHdXQPIRrrbTcF5QRnV15Th8wlnm6ALDsCXQkDhSc30CAXl9Kp lUcwwo8YPG+ToK1ghL+xsLwZPbKsU3Xs5fTm4yRb1VvjTdISvp+ik2qXsRARg60MQYWC GzqnvLsPLHQQ9m8qRk3NoJy44Um8tv0iazTe+dReBMGQpIWhXgY7sW+X5Q92sAdYY4Up yPMCEKh8i9Ozg5XgOdN0UxNO4J+QgBEZh3/Z8fVZf4cnzrU5tlx9D2h6JrtHwCIXtkCT BYpUW9KmlugPMvChcIWuNOw5mvQnQfIPUm4rq/I+cIqgIavTpZd0JMU/RlcgqLJUgwvk OYWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=50wuqx97QXZx2zbLRPpUZaCAf982O497zw+lzOUq1k4=; b=HaCv1BpGDQSJA9H36nuonubAKdJPrueCiSYcnN1xZydi4XDb93Y2G7ayEWFgknA7il XUFRxrTGHCCZovrpkqTNP12Qmtp+2JFvZxT9dwdC7Qq5oIR1gICNqM09h6fcoDjBg58N MLJwgmt0M6lzSz8WPhq0frbP7LBDzX99XBSdlcwb5feFU8YTNREC4S9YEX0MYyVwT77b OGMA9VOsjnfAbS4A93lHccuCCWSBYE6yh/2LDKbwbjiGSTj1kZ4nSwEz+PB/qrTgXwmD kup5vHudUtj/JTThHubcOqg4Gtc+gRpwavfekLcdY7LJBCEypyVBHOGUSzCPQTAcCEv2 gg0g== X-Gm-Message-State: AOAM531Cdrn0vm/T4TpuJDDy7d9BcZNFrCWgY+lesoTJZNsdWyceUAie iH60YdbE/XJQieX4JP7VD9uCZA== X-Google-Smtp-Source: ABdhPJxW/DBrlG7TEnvWEUg0Nipmvi6wS+g8Y+NMEBmjLhpKfeu4xjRK3q520VX+9jaURA7ei9otVw== X-Received: by 2002:a2e:a26d:0:b0:253:d7b4:1d9a with SMTP id k13-20020a2ea26d000000b00253d7b41d9amr11639775ljm.203.1653311215543; Mon, 23 May 2022 06:06:55 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id c6-20020ac24146000000b00477b0cfc990sm1968975lfi.30.2022.05.23.06.06.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 06:06:55 -0700 (PDT) Message-ID: <2ccfbfa8-be11-50ed-66ca-3476cbddb320@linaro.org> Date: Mon, 23 May 2022 15:06:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v1 04/19] tty: serial: 8250: Add NPCM845 UART support Content-Language: en-US To: Tomer Maimon , Arnd Bergmann Cc: Avi Fishman , Tali Perry , Joel Stanley , Patrick Venture , Nancy Yuen , Benjamin Fair , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Philipp Zabel , gregkh , Daniel Lezcano , Thomas Gleixner , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Olof Johansson , Jiri Slaby , Shawn Guo , Bjorn Andersson , Geert Uytterhoeven , Marcel Ziswiler , Vinod Koul , Biju Das , Nobuhiro Iwamatsu , robert.hancock@calian.com, nathan=20Neusch=C3=A4fer?= , Lubomir Rintel , SoC Team , DTML , Linux Kernel Mailing List , linux-clk , "open list:SERIAL DRIVERS" , LINUXWATCHDOG , Linux ARM References: <20220522155046.260146-1-tmaimon77@gmail.com> <20220522155046.260146-5-tmaimon77@gmail.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220523_060659_490904_65CE9D1E X-CRM114-Status: GOOD ( 19.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjMvMDUvMjAyMiAxNDo1OCwgVG9tZXIgTWFpbW9uIHdyb3RlOgo+IEhpIEFybmQsCj4gCj4g VGhhbmtzIGZvciB5b3VyIGNvbW1lbnQuCj4gCj4gT24gTW9uLCAyMyBNYXkgMjAyMiBhdCAxNDo0 OCwgQXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZQo+IDxtYWlsdG86YXJuZEBhcm5kYi5kZT4+ IHdyb3RlOgo+IAo+ICAgICBPbiBTdW4sIE1heSAyMiwgMjAyMiBhdCA1OjUwIFBNIFRvbWVyIE1h aW1vbiA8dG1haW1vbjc3QGdtYWlsLmNvbQo+ICAgICA8bWFpbHRvOnRtYWltb243N0BnbWFpbC5j b20+PiB3cm90ZToKPiAgICAgPiArKysgYi9kcml2ZXJzL3R0eS9zZXJpYWwvODI1MC84MjUwX29m LmMKPiAgICAgPiBAQCAtMzMzLDYgKzMzMyw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgb2ZfZGV2 aWNlX2lkCj4gICAgIG9mX3BsYXRmb3JtX3NlcmlhbF90YWJsZVtdID0gewo+ICAgICA+wqAgwqAg wqAgwqAgwqB7IC5jb21wYXRpYmxlID0gInRpLGRhODMwLXVhcnQiLCAuZGF0YSA9ICh2b2lkCj4g ICAgICopUE9SVF9EQTgzMCwgfSwKPiAgICAgPsKgIMKgIMKgIMKgIMKgeyAuY29tcGF0aWJsZSA9 ICJudXZvdG9uLHdwY200NTAtdWFydCIsIC5kYXRhID0gKHZvaWQKPiAgICAgKilQT1JUX05QQ00s IH0sCj4gICAgID7CoCDCoCDCoCDCoCDCoHsgLmNvbXBhdGlibGUgPSAibnV2b3RvbixucGNtNzUw LXVhcnQiLCAuZGF0YSA9ICh2b2lkCj4gICAgICopUE9SVF9OUENNLCB9LAo+ICAgICA+ICvCoCDC oCDCoCDCoHsgLmNvbXBhdGlibGUgPSAibnV2b3RvbixucGNtODQ1LXVhcnQiLCAuZGF0YSA9ICh2 b2lkCj4gICAgICopUE9SVF9OUENNLCB9LAo+ICAgICA+wqAgwqAgwqAgwqAgwqB7IC8qIGVuZCBv ZiBsaXN0ICovIH0sCj4gCj4gICAgIElmIHRoZXNlIGFyZSBjb21wYXRpYmxlIGRldmljZXMsIGl0 J3MgdXN1YWxseSBlYXNpZXIgdG8gY2xhaW0KPiAgICAgY29tcGF0aWJpbGl0eSB3aXRoIGJvdGgg dGhlIHNwZWNpZmljIGNoaXAgYW5kIHRoZSBvbGRlciBtb2RlbAo+ICAgICBhcyBhIGZhbGxiYWNr LCB0byBhdm9pZCBkcml2ZXIgY2hhbmdlcy4gVGhpcyBzZWVtcyB0byBhcHBseSB0bwo+ICAgICB0 aGUgdGltZXIgYW5kIHdhdGNoZG9nIGRldmljZXMgYXMgd2VsbC4KPiAKPiBKdXN0IHRvIG1ha2Ug c3VyZSwgRG8geW91IG1lYW4gY2xhaW0gaW4gdGhlIGRldmljZSB0cmVlPwo+IGxpa2UKPiAKPiBj b21wYXRpYmxlID0gIm51dm90b24sbnBjbTg0NS10aW1lciIsICJudXZvdG9uLG5wY20tdGltZXIi OwoKY29tcGF0aWJsZSA9ICJudXZvdG9uLG5wY204NDUtdGltZXIiLCAibnV2b3RvbixucGNtNzUw LXRpbWVyIiI7CgoKQmVzdCByZWdhcmRzLApLcnp5c3p0b2YKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0 CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK