From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20B49C4332F for ; Tue, 8 Nov 2022 08:53:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1osKLW-0004dC-8O; Tue, 08 Nov 2022 03:52:38 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1osKLR-0004d0-P5 for qemu-devel@nongnu.org; Tue, 08 Nov 2022 03:52:33 -0500 Received: from smtp-out2.suse.de ([195.135.220.29]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1osKLP-0003Q9-Oz for qemu-devel@nongnu.org; Tue, 08 Nov 2022 03:52:33 -0500 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2E0C31F88B; Tue, 8 Nov 2022 08:52:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1667897547; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FLVNUYJDQvKZpJLLefh7Vw26PnlpicX3kZXqH5a//mk=; b=awsvXyyEiZENyt0dAMblPWYO5kwFni0j57m2vYXLxVonC+5I42dzV1lz/g3IOQ27tgw+mA 0rU8DauNVgaIbusN30yl3NaPjVzXPdhwFT+0/Ou0VpeG3HtQX3K9uscwDL+SxWzS+2ok+7 OWIRc9uPUk4CmpMl59DQrY7CtCnKmrk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1667897547; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FLVNUYJDQvKZpJLLefh7Vw26PnlpicX3kZXqH5a//mk=; b=dKMWdgStObi76zNSi7obePQhMqIk6ZKBe5YolNP1Th+jqZC6l2CG3Gl31lcs2Qv6y3y+82 zdH1/ykvc8BCqrBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 01E14139F1; Tue, 8 Nov 2022 08:52:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id c7CFOsoYamP2WgAAMHmgww (envelope-from ); Tue, 08 Nov 2022 08:52:26 +0000 Message-ID: <2cdf742a-b756-e586-229b-a27ceea4dfd8@suse.de> Date: Tue, 8 Nov 2022 09:52:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 2/3] net: Restore printing of the help text with "-nic help" Content-Language: en-US To: Thomas Huth , qemu-devel@nongnu.org, Jason Wang Cc: "Michael S. Tsirkin" , pbonzini@redhat.com References: <20221104125705.415923-1-thuth@redhat.com> <20221104125705.415923-3-thuth@redhat.com> <92cea786-0a5d-1ddd-68d5-14ca98143614@suse.de> <6d6d0704-de37-db36-223e-f770311c70fd@redhat.com> From: Claudio Fontana In-Reply-To: <6d6d0704-de37-db36-223e-f770311c70fd@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=195.135.220.29; envelope-from=cfontana@suse.de; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/8/22 09:42, Thomas Huth wrote: > On 07/11/2022 13.27, Claudio Fontana wrote: >> should -net and -netdev be adapted too? > > "-netdev help" already works just fine ... and "-net" should IMHO rather be > removed than improved ;-) > > Thomas > I wonder if it could be done once for all, in net_init_clients, instead of repeating the is_help_option in net_init_netdev and net_param_nic (and that would take care of net_init_client too, so we'd get "net" for free).. Ciao, C