All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
To: Shuotao Xu <shuotaoxu@microsoft.com>,
	"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>
Cc: Ziyue Yang <Ziyue.Yang@microsoft.com>,
	Lei Qu <Lei.Qu@microsoft.com>, Peng Cheng <pengc@microsoft.com>,
	Ran Shu <Ran.Shu@microsoft.com>
Subject: Re: Code Review Request for AMDGPU Hotplug Support
Date: Wed, 6 Apr 2022 10:13:12 -0400	[thread overview]
Message-ID: <2cdfcdee-bf4d-006a-19c1-c806feb4100d@amd.com> (raw)
In-Reply-To: <PSAP153MB051776C60FFB06BB3278EEB4B7E79@PSAP153MB0517.APCP153.PROD.OUTLOOK.COM>

Looks like you are using 5.13 kernel for this work, FYI we added
hot plug support for the graphic stack in 5.14 kernel (see 
https://www.phoronix.com/scan.php?page=news_item&px=Linux-5.14-AMDGPU-Hot-Unplug) 


I am not sure about the code part since it all touches KFD driver (KFD 
team can comment on that) - but I was just wondering if you try 5.14 
kernel would things just work for you out of the box ?

Andrey

On 2022-04-05 22:45, Shuotao Xu wrote:
> Dear AMD Colleagues,
> 
> We are from Microsoft Research, and are working on GPU disaggregation 
> technology.
> 
> We have created a new pull requestAdd PCIe hotplug support for amdgpu by 
> xushuotao · Pull Request #131 · RadeonOpenCompute/ROCK-Kernel-Driver 
> (github.com) 
> <https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRadeonOpenCompute%2FROCK-Kernel-Driver%2Fpull%2F131&data=04%7C01%7Candrey.grodzovsky%40amd.com%7C4e8dc7d4feb84b19edf208da17a54fac%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637848296133682200%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=GE4XHNeLaWfbuoJbM4a1ecH8KKJbKbd2mRCnFinn7eI%3D&reserved=0>in 
> ROCK-Kernel-Driver, which will enable PCIe hot-plug support for amdgpu.
> 
> We believe the support of hot-plug of GPU devices can open doors for 
> many advanced applications in data center in the next few years, and we 
> would like to have some reviewers on this PR so we can continue further 
> technical discussions around this feature.
> 
> Would you please help review this PR?
> 
> Thank you very much!
> 
> Best regards,
> 
> Shuotao Xu
> 

  reply	other threads:[~2022-04-06 14:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06  2:45 Code Review Request for AMDGPU Hotplug Support Shuotao Xu
2022-04-06 14:13 ` Andrey Grodzovsky [this message]
2022-04-06 14:25   ` [EXTERNAL] " Shuotao Xu
2022-04-06 14:36     ` Andrey Grodzovsky
2022-04-06 15:11       ` Shuotao Xu
2022-04-06 15:39         ` Andrey Grodzovsky
2022-04-07  2:55           ` [EXTERNAL] " Shuotao Xu
2022-04-07  2:22         ` [EXTERNAL] " Joshi, Mukul
2022-04-07 15:08           ` Shuotao Xu
2022-04-07 16:22             ` Joshi, Mukul
2022-04-07 16:28               ` Shuotao Xu
2022-04-07 16:33                 ` Joshi, Mukul
2022-04-07 16:37                   ` Shuotao Xu
2022-04-06  8:11 Shuotao Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cdfcdee-bf4d-006a-19c1-c806feb4100d@amd.com \
    --to=andrey.grodzovsky@amd.com \
    --cc=Lei.Qu@microsoft.com \
    --cc=Ran.Shu@microsoft.com \
    --cc=Ziyue.Yang@microsoft.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=pengc@microsoft.com \
    --cc=shuotaoxu@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.