From mboxrd@z Thu Jan 1 00:00:00 1970 From: anshul makkar Subject: Re: [PATCH 1/6] xen: credit1: simplify csched_runq_steal() a little bit. Date: Fri, 3 Mar 2017 09:35:55 +0000 Message-ID: <2ce79bdd-7218-02e3-a015-3e4eb6d469b0@citrix.com> References: <148844531279.23452.17528540110704914171.stgit@Solace.fritz.box> <148845108437.23452.18282287504552403796.stgit@Solace.fritz.box> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cjjd5-0001SG-2O for xen-devel@lists.xenproject.org; Fri, 03 Mar 2017 09:36:03 +0000 In-Reply-To: <148845108437.23452.18282287504552403796.stgit@Solace.fritz.box> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Dario Faggioli , xen-devel@lists.xenproject.org Cc: George Dunlap List-Id: xen-devel@lists.xenproject.org CgpPbiAwMi8wMy8xNyAxMDozOCwgRGFyaW8gRmFnZ2lvbGkgd3JvdGU6Cj4gU2luY2Ugd2UncmUg aG9sZGluZyB0aGUgbG9jayBvbiB0aGUgcENQVSBmcm9tIHdoaWNoIHdlCj4gYXJlIHRyeWluZyB0 byBzdGVhbCwgaXQgY2FuJ3QgaGF2ZSBkaXNhcHBlYXJlZCwgc28gd2UKPiBjYW4gZHJvcCB0aGUg Y2hlY2sgZm9yIHRoYXQgKGFuZCBjb252ZXJ0IGl0IGluIGFuCj4gQVNTRVJUKCkpLgo+Cj4gQW5k IHNpbmNlIHdlIHRyeSB0byBzdGVhbCBvbmx5IGZyb20gYnVzeSBwQ1BVcywgaXQncwo+IHVubGlr ZWx5IGZvciBzdWNoIHBDUFUgdG8gYmUgaWRsZSwgc28gd2UgbWFyayBpdCBhcwo+IHN1Y2ggKGFu ZCBiYWlsIGVhcmx5IGlmIGl0IHVuZm9ydHVuYXRlbHkgaXMpLgo+Cj4gU2lnbmVkLW9mZi1ieTog RGFyaW8gRmFnZ2lvbGkgPGRhcmlvLmZhZ2dpb2xpQGNpdHJpeC5jb20+Cj4gLS0tCj4gQ2M6IEdl b3JnZSBEdW5sYXAgPGdlb3JnZS5kdW5sYXBAZXUuY2l0cml4LmNvbT4KPiAtLS0KPiAgIHhlbi9j b21tb24vc2NoZWRfY3JlZGl0LmMgfCAgIDg3ICsrKysrKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDQ0IGluc2VydGlvbnMoKyksIDQz IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL3hlbi9jb21tb24vc2NoZWRfY3JlZGl0LmMg Yi94ZW4vY29tbW9uL3NjaGVkX2NyZWRpdC5jCj4gaW5kZXggNDY0OWU2NC4uNjNhODY3NSAxMDA2 NDQKPiAtLS0gYS94ZW4vY29tbW9uL3NjaGVkX2NyZWRpdC5jCj4gKysrIGIveGVuL2NvbW1vbi9z Y2hlZF9jcmVkaXQuYwo+IEBAIC0xNTkzLDY0ICsxNTkzLDY1IEBAIHN0YXRpYyBzdHJ1Y3QgY3Nj aGVkX3ZjcHUgKgo+ICAgY3NjaGVkX3J1bnFfc3RlYWwoaW50IHBlZXJfY3B1LCBpbnQgY3B1LCBp bnQgcHJpLCBpbnQgYmFsYW5jZV9zdGVwKQo+ICAgewo+ICAgICAgIGNvbnN0IHN0cnVjdCBjc2No ZWRfcGNwdSAqIGNvbnN0IHBlZXJfcGNwdSA9IENTQ0hFRF9QQ1BVKHBlZXJfY3B1KTsKPiAtICAg IGNvbnN0IHN0cnVjdCB2Y3B1ICogY29uc3QgcGVlcl92Y3B1ID0gY3Vycl9vbl9jcHUocGVlcl9j cHUpOwo+ICAgICAgIHN0cnVjdCBjc2NoZWRfdmNwdSAqc3BlZXI7Cj4gICAgICAgc3RydWN0IGxp c3RfaGVhZCAqaXRlcjsKPiAgICAgICBzdHJ1Y3QgdmNwdSAqdmM7Cj4gICAKPiArICAgIEFTU0VS VChwZWVyX3BjcHUgIT0gTlVMTCk7Cj4gKwo+ICAgICAgIC8qCj4gICAgICAgICogRG9uJ3Qgc3Rl YWwgZnJvbSBhbiBpZGxlIENQVSdzIHJ1bnEgYmVjYXVzZSBpdCdzIGFib3V0IHRvCj4gICAgICAg ICogcGljayB1cCB3b3JrIGZyb20gaXQgaXRzZWxmLgo+ICAgICAgICAqLwo+IC0gICAgaWYgKCBw ZWVyX3BjcHUgIT0gTlVMTCAmJiAhaXNfaWRsZV92Y3B1KHBlZXJfdmNwdSkgKQo+ICsgICAgaWYg KCB1bmxpa2VseShpc19pZGxlX3ZjcHUoY3Vycl9vbl9jcHUocGVlcl9jcHUpKSkgKQo+ICsgICAg ICAgIGdvdG8gb3V0OwpXZSBjYW4ganVzdCB1c2UgaWYgKCFpc19pZGxlX3ZjcHUocGVlcl92Y3B1 KSkuIFdoeSB0byByZXBsYWNlIGl0IHdpdGggCnNvbWUgY29kZSB0aGF0IGludHJvZHVjZXMgYW4g dW5uZWNlc3NhcnkgYnJhbmNoIHN0YXRlbWVudC4KPiArCj4gKyAgICBsaXN0X2Zvcl9lYWNoKCBp dGVyLCAmcGVlcl9wY3B1LT5ydW5xICkKPiAgICAgICB7Cj4gLSAgICAgICAgbGlzdF9mb3JfZWFj aCggaXRlciwgJnBlZXJfcGNwdS0+cnVucSApCj4gLSAgICAgICAgewo+IC0gICAgICAgICAgICBz cGVlciA9IF9fcnVucV9lbGVtKGl0ZXIpOwo+ICsgICAgICAgIHNwZWVyID0gX19ydW5xX2VsZW0o aXRlcik7Cj4gICAKPiAtICAgICAgICAgICAgLyoKPiAtICAgICAgICAgICAgICogSWYgbmV4dCBh dmFpbGFibGUgVkNQVSBoZXJlIGlzIG5vdCBvZiBzdHJpY3RseSBoaWdoZXIKPiAtICAgICAgICAg ICAgICogcHJpb3JpdHkgdGhhbiBvdXJzLCB0aGlzIFBDUFUgaXMgdXNlbGVzcyB0byB1cy4KPiAt ICAgICAgICAgICAgICovCj4gLSAgICAgICAgICAgIGlmICggc3BlZXItPnByaSA8PSBwcmkgKQo+ IC0gICAgICAgICAgICAgICAgYnJlYWs7Cj4gKyAgICAgICAgLyoKPiArICAgICAgICAgKiBJZiBu ZXh0IGF2YWlsYWJsZSBWQ1BVIGhlcmUgaXMgbm90IG9mIHN0cmljdGx5IGhpZ2hlcgo+ICsgICAg ICAgICAqIHByaW9yaXR5IHRoYW4gb3VycywgdGhpcyBQQ1BVIGlzIHVzZWxlc3MgdG8gdXMuCj4g KyAgICAgICAgICovCj4gKyAgICAgICAgaWYgKCBzcGVlci0+cHJpIDw9IHByaSApCj4gKyAgICAg ICAgICAgIGJyZWFrOwo+ICAgCj4gLSAgICAgICAgICAgIC8qIElzIHRoaXMgVkNQVSBydW5uYWJs ZSBvbiBvdXIgUENQVT8gKi8KPiAtICAgICAgICAgICAgdmMgPSBzcGVlci0+dmNwdTsKPiAtICAg ICAgICAgICAgQlVHX09OKCBpc19pZGxlX3ZjcHUodmMpICk7Cj4gKyAgICAgICAgLyogSXMgdGhp cyBWQ1BVIHJ1bm5hYmxlIG9uIG91ciBQQ1BVPyAqLwo+ICsgICAgICAgIHZjID0gc3BlZXItPnZj cHU7Cj4gKyAgICAgICAgQlVHX09OKCBpc19pZGxlX3ZjcHUodmMpICk7Cj4gICAKPiAtICAgICAg ICAgICAgLyoKPiAtICAgICAgICAgICAgICogSWYgdGhlIHZjcHUgaGFzIG5vIHVzZWZ1bCBzb2Z0 IGFmZmluaXR5LCBza2lwIHRoaXMgdmNwdS4KPiAtICAgICAgICAgICAgICogSW4gZmFjdCwgd2hh dCB3ZSB3YW50IGlzIHRvIGNoZWNrIGlmIHdlIGhhdmUgYW55ICJzb2Z0LWFmZmluZQo+IC0gICAg ICAgICAgICAgKiB3b3JrIiB0byBzdGVhbCwgYmVmb3JlIHN0YXJ0aW5nIHRvIGxvb2sgYXQgImhh cmQtYWZmaW5lIHdvcmsiLgo+IC0gICAgICAgICAgICAgKgo+IC0gICAgICAgICAgICAgKiBOb3Rp Y2UgdGhhdCwgaWYgbm90IGV2ZW4gb25lIHZDUFUgb24gdGhpcyBydW5xIGhhcyBhIHVzZWZ1bAo+ IC0gICAgICAgICAgICAgKiBzb2Z0IGFmZmluaXR5LCB3ZSBjb3VsZCBoYXZlIGF2b2lkIGNvbnNp ZGVyaW5nIHRoaXMgcnVucSBmb3IKPiAtICAgICAgICAgICAgICogYSBzb2Z0IGJhbGFuY2luZyBz dGVwIGluIHRoZSBmaXJzdCBwbGFjZS4gVGhpcywgZm9yIGluc3RhbmNlLAo+IC0gICAgICAgICAg ICAgKiBjYW4gYmUgaW1wbGVtZW50ZWQgYnkgdGFraW5nIG5vdGUgb2Ygb24gd2hhdCBydW5xIHRo ZXJlIGFyZQo+IC0gICAgICAgICAgICAgKiB2Q1BVcyB3aXRoIHVzZWZ1bCBzb2Z0IGFmZmluaXRp ZXMgaW4gc29tZSBzb3J0IG9mIGJpdG1hcAo+IC0gICAgICAgICAgICAgKiBvciBjb3VudGVyLgo+ IC0gICAgICAgICAgICAgKi8KPiAtICAgICAgICAgICAgaWYgKCBiYWxhbmNlX3N0ZXAgPT0gQ1ND SEVEX0JBTEFOQ0VfU09GVF9BRkZJTklUWQo+IC0gICAgICAgICAgICAgICAgICYmICFfX3ZjcHVf aGFzX3NvZnRfYWZmaW5pdHkodmMsIHZjLT5jcHVfaGFyZF9hZmZpbml0eSkgKQo+IC0gICAgICAg ICAgICAgICAgY29udGludWU7Cj4gKyAgICAgICAgLyoKPiArICAgICAgICAgKiBJZiB0aGUgdmNw dSBoYXMgbm8gdXNlZnVsIHNvZnQgYWZmaW5pdHksIHNraXAgdGhpcyB2Y3B1Lgo+ICsgICAgICAg ICAqIEluIGZhY3QsIHdoYXQgd2Ugd2FudCBpcyB0byBjaGVjayBpZiB3ZSBoYXZlIGFueSAic29m dC1hZmZpbmUKPiArICAgICAgICAgKiB3b3JrIiB0byBzdGVhbCwgYmVmb3JlIHN0YXJ0aW5nIHRv IGxvb2sgYXQgImhhcmQtYWZmaW5lIHdvcmsiLgo+ICsgICAgICAgICAqCj4gKyAgICAgICAgICog Tm90aWNlIHRoYXQsIGlmIG5vdCBldmVuIG9uZSB2Q1BVIG9uIHRoaXMgcnVucSBoYXMgYSB1c2Vm dWwKPiArICAgICAgICAgKiBzb2Z0IGFmZmluaXR5LCB3ZSBjb3VsZCBoYXZlIGF2b2lkIGNvbnNp ZGVyaW5nIHRoaXMgcnVucSBmb3IKPiArICAgICAgICAgKiBhIHNvZnQgYmFsYW5jaW5nIHN0ZXAg aW4gdGhlIGZpcnN0IHBsYWNlLiBUaGlzLCBmb3IgaW5zdGFuY2UsCj4gKyAgICAgICAgICogY2Fu IGJlIGltcGxlbWVudGVkIGJ5IHRha2luZyBub3RlIG9mIG9uIHdoYXQgcnVucSB0aGVyZSBhcmUK PiArICAgICAgICAgKiB2Q1BVcyB3aXRoIHVzZWZ1bCBzb2Z0IGFmZmluaXRpZXMgaW4gc29tZSBz b3J0IG9mIGJpdG1hcAo+ICsgICAgICAgICAqIG9yIGNvdW50ZXIuCj4gKyAgICAgICAgICovCklz bid0IGl0IGEgYmV0dGVyIGFwcHJvYWNoIHRoYXQgbm93IGFzIHdlIGhhdmUgY2FtZSBhY3Jvc3Mg YSB2Y3B1IHdoaWNoIApkb2Vzbid0IGhhdmUgYSBkZXNpcmVkIHNvZnQgYWZmaW5pdHkgYnV0IGlz IGEgcG90ZW50aWFsIGNhbmRpZGF0ZSBmb3IgCm1pZ3JhdGlvbiwgc28gaW5zdGVhZCBvZiBqdXN0 IGZvcmdldHRpbmcgaXQsICBsZXRzIHNhdmUgdGhlIGluZm9ybWF0aW9uIApmb3Igc3VjaCB2Y3B1 cyBpbiBzb21lIGRhdGEgc3RydWN0dXJlIGluIHNvbWUgb3JkZXIgc28gdGhhdCB3ZSBkb24ndCAK aGF2ZSB0byBzY2FuIHRoZW0gYWdhaW4gaWYgd2UgZG9uJ3QgZmluZCBhbnl0aGluZyB1c2VmdWwg aW4gdGhlIHByZXNlbnQgcnVuLgo+ICsgICAgICAgIGlmICggYmFsYW5jZV9zdGVwID09IENTQ0hF RF9CQUxBTkNFX1NPRlRfQUZGSU5JVFkKPiArICAgICAgICAgICAgICYmICFfX3ZjcHVfaGFzX3Nv ZnRfYWZmaW5pdHkodmMsIHZjLT5jcHVfaGFyZF9hZmZpbml0eSkgKQo+ICsgICAgICAgICAgICBj b250aW51ZTsKPiAgIAo+IC0gICAgICAgICAgICBjc2NoZWRfYmFsYW5jZV9jcHVtYXNrKHZjLCBi YWxhbmNlX3N0ZXAsIGNwdW1hc2tfc2NyYXRjaCk7Cj4gLSAgICAgICAgICAgIGlmICggX19jc2No ZWRfdmNwdV9pc19taWdyYXRlYWJsZSh2YywgY3B1LCBjcHVtYXNrX3NjcmF0Y2gpICkKPiAtICAg ICAgICAgICAgewo+IC0gICAgICAgICAgICAgICAgLyogV2UgZ290IGEgY2FuZGlkYXRlLiBHcmFi IGl0ISAqLwo+IC0gICAgICAgICAgICAgICAgVFJBQ0VfM0QoVFJDX0NTQ0hFRF9TVE9MRU5fVkNQ VSwgcGVlcl9jcHUsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICB2Yy0+ZG9tYWluLT5kb21h aW5faWQsIHZjLT52Y3B1X2lkKTsKPiAtICAgICAgICAgICAgICAgIFNDSEVEX1ZDUFVfU1RBVF9D UkFOSyhzcGVlciwgbWlncmF0ZV9xKTsKPiAtICAgICAgICAgICAgICAgIFNDSEVEX1NUQVRfQ1JB TksobWlncmF0ZV9xdWV1ZWQpOwo+IC0gICAgICAgICAgICAgICAgV0FSTl9PTih2Yy0+aXNfdXJn ZW50KTsKPiAtICAgICAgICAgICAgICAgIF9fcnVucV9yZW1vdmUoc3BlZXIpOwo+IC0gICAgICAg ICAgICAgICAgdmMtPnByb2Nlc3NvciA9IGNwdTsKPiAtICAgICAgICAgICAgICAgIHJldHVybiBz cGVlcjsKPiAtICAgICAgICAgICAgfQo+ICsgICAgICAgIGNzY2hlZF9iYWxhbmNlX2NwdW1hc2so dmMsIGJhbGFuY2Vfc3RlcCwgY3B1bWFza19zY3JhdGNoKTsKPiArICAgICAgICBpZiAoIF9fY3Nj aGVkX3ZjcHVfaXNfbWlncmF0ZWFibGUodmMsIGNwdSwgY3B1bWFza19zY3JhdGNoKSApCj4gKyAg ICAgICAgewo+ICsgICAgICAgICAgICAvKiBXZSBnb3QgYSBjYW5kaWRhdGUuIEdyYWIgaXQhICov Cj4gKyAgICAgICAgICAgIFRSQUNFXzNEKFRSQ19DU0NIRURfU1RPTEVOX1ZDUFUsIHBlZXJfY3B1 LAo+ICsgICAgICAgICAgICAgICAgICAgICB2Yy0+ZG9tYWluLT5kb21haW5faWQsIHZjLT52Y3B1 X2lkKTsKPiArICAgICAgICAgICAgU0NIRURfVkNQVV9TVEFUX0NSQU5LKHNwZWVyLCBtaWdyYXRl X3EpOwo+ICsgICAgICAgICAgICBTQ0hFRF9TVEFUX0NSQU5LKG1pZ3JhdGVfcXVldWVkKTsKPiAr ICAgICAgICAgICAgV0FSTl9PTih2Yy0+aXNfdXJnZW50KTsKPiArICAgICAgICAgICAgX19ydW5x X3JlbW92ZShzcGVlcik7Cj4gKyAgICAgICAgICAgIHZjLT5wcm9jZXNzb3IgPSBjcHU7Cj4gKyAg ICAgICAgICAgIHJldHVybiBzcGVlcjsKPiAgICAgICAgICAgfQo+ICAgICAgIH0KPiAtCj4gKyBv dXQ6Cj4gICAgICAgU0NIRURfU1RBVF9DUkFOSyhzdGVhbF9wZWVyX2lkbGUpOwo+ICAgICAgIHJl dHVybiBOVUxMOwo+ICAgfQo+Cj4KPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+IFhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKPiBYZW4tZGV2ZWxAbGlzdHMu eGVuLm9yZwo+IGh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwKQW5zaHVsCgpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGlu ZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4t ZGV2ZWwK