From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x22742K/tokt6NEiIBDeE7ih+OKsiAP2FxMKfc5QfMjiRv1sdPfFNnRFI/Uy9EUreHFVTR9// ARC-Seal: i=1; a=rsa-sha256; t=1517008488; cv=none; d=google.com; s=arc-20160816; b=xD12RsQKE1i0Q8rbA3J0xlnbydYR2DoZfsdYAMkN5q+w/AHDI1T1FftJwq+Z3mFecI nO4YKLbBxmHCYzQm/8gH744UQRJfKq0vT6XOzvqzgzztGVMiaYG7wXt6/xsP3Z7UUrts Z7H9xB02kIr6/qe3owah8XIc2dlSsAs0JG5vxECYvwhSviElhR+xJSZvPX4jYFd2AOVA IVq5aMsMymXOJ5j9ziz307wojg9sL65dAqboaQ2fgSrmx3Tk1vhnYhMPig9qhBTdkocK fl0RgsmAgIqFpoHKq9NvS/Ls1TAXfi7dR86feClGFhlbXdSJCHifoqj735X2VPcAqwMo f4Lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=spamdiagnosticmetadata:spamdiagnosticoutput :content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :dkim-signature:arc-authentication-results; bh=gB26UwXjDTqUnKJjQERV9eZ3FJQXLFDyz5oDS7ntTSw=; b=dvZLvNVfKmS+/ahBnjq2Y4npUNOeBbzCdcH3jXOM1LZjVUjcNn0kjO3wrP/p3u6Cgc NRFHWhBXk8hwffX4YUTJtGGW+fzNleCDbN+gLq1nj945zHeBSCBRUMyZxzvttrYCNsLw Ijz31CsJ3DEIXclFmV4KBTVSeJt9cTR4XVI3FPnegUph2D2i2Kn9/Py1Ns4wBItZojyz Ar/e0q0xrW7tZIe6WMTOuRdNYmsOVgsdNVUo54YU78eZZuk8+7DO+wXRa3DbVkvSh3lt 2CGXYIbEilnaIi8x99mKciMsymMr3hYY4MA+yC4RG6DI526bi6Hp0QQ/dGpSyu4kAaVd l6NA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector1-amd-com header.b=hYkm9RT9; spf=neutral (google.com: 104.47.34.81 is neither permitted nor denied by best guess record for domain of thomas.lendacky@amd.com) smtp.mailfrom=Thomas.Lendacky@amd.com Authentication-Results: mx.google.com; dkim=pass header.i=@amdcloud.onmicrosoft.com header.s=selector1-amd-com header.b=hYkm9RT9; spf=neutral (google.com: 104.47.34.81 is neither permitted nor denied by best guess record for domain of thomas.lendacky@amd.com) smtp.mailfrom=Thomas.Lendacky@amd.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Thomas.Lendacky@amd.com; Subject: Re: [PATCH] x86/cpufeatures: Cleanup AMD speculation feature bits To: Borislav Petkov , David Woodhouse Cc: x86-ml , linux-tip-commits@vger.kernel.org, hpa@zytor.com, gregkh@linuxfoundation.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@kernel.org References: <1516896855-7642-4-git-send-email-dwmw@amazon.co.uk> <20180126184139.rcfbtk7dvj7kmyfn@pd.tnic> <1516992318.30244.271.camel@infradead.org> <20180126184915.ioqewp56orj2qhrt@pd.tnic> <7094ed9b-40f7-ba2b-55a6-cc5ab0b06bb9@amd.com> <20180126215209.vqdxh5p672tcdst6@pd.tnic> <1517003984.30244.299.camel@infradead.org> <20180126221026.hc2hk23zsqbqhkif@pd.tnic> From: Tom Lendacky Message-ID: <2cea933f-7e06-26d5-95cf-41df8308a0f8@amd.com> Date: Fri, 26 Jan 2018 17:14:42 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180126221026.hc2hk23zsqbqhkif@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.78.1] X-ClientProxiedBy: DM5PR21CA0046.namprd21.prod.outlook.com (10.172.92.160) To CY4PR12MB1144.namprd12.prod.outlook.com (10.168.164.136) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: b0f11745-73a9-41ec-0671-08d56512978c X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020);SRVR:CY4PR12MB1144; X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1144;3:pw70QCzp/6k2b4afHnTP7ZG9nofmID8Gm3edyNWgUHcsUWWn+EqAPmcyW4Obx4/u9QQ2lnR9Q7asAxB28+9bXc+eenBQac+nAaR/fQr1tTvm2pLVd69y9FqzPUyCIL0ufdGbWyChEZQlDsIMupSKVSZhlt2PfFL1bXKPXNhgYm33Ee4DeMDZHA6iPnEYsMtaSsz85dyh+1RUoqTikyeoh51dg9LwDWOrpjspaUNRQyqaVmhnW8/zSjAeW3Qw+f9j;25:kQHpNbdDKf8rVajGiRMtarojOENV1dAU7Gp6q0yVXfLEuxX7ss8ka/sWhZImc+JTREqM5/53ZYVrZ5Q3MKO6/6+YkKyRf3z83I1CtiJxHvqK8Cg93UD7rBjSK9z8xNtPPwp5gtW3KrCdaZzrNCSa4xCOyRDJPyNBSfKguy79Zo3Sywe3wPJNHNhwbFm8pZnBtDpaxsBU01EOANaLOy6owmBePuXV8fegnQ3ETK8VhX+7YD5BTL1RqP8AJl44+hcVeZR4ak/yrMqY5H0loK+koj1hTG6RWOpTObUasv+F43m/zGq4oQJQAjJ48g7JxfjHmvj24JieEcGa7L7Vib0gtA==;31:I+o5kscpTSLFvPXT5KTkWxX6MI+iYen2XD0m7HsUmNjmAWO0LP5R45Bds0T/cypi5CrhYfwjh/af5MXBMLc+Djo+0juzLMlrj20g7FX5URIbenbBShxEBodRstL4oz4UyoxI9wggpUyIRnPoDIrjHqE29IRkvHp5Zdl8Hd8bDwjm5W9DPmBYTT6F+qZ4k+S5DsLmuswKLoC/19JqtyoytovsaJgZ3U7+JiRMRxDf6bo= X-MS-TrafficTypeDiagnostic: CY4PR12MB1144: X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1144;20:ENjXnkelSiVuocNTukxit1/Em/cy98NZ1Z7M71hauO20FBccWQtYofzPTlVZzVBr4eUAi+/gMJhYm2SFGPlhR4JEnNFOMVgsOOJvdD9o8couts7/przBiKjds/HwHJEQlqJnRmt6AaUEz5UiwKOKvtoETZMFOu5RGmtqel3mBYdK5jgfmk8xZ8hTNW9xl5PMVKVVsYlIglaogQIHMBPpT2DX4xbl+KixBt4KiyLJNNgBnfV1bgvvS7DAOWeetDZQ599SKVaY6eZ0I1/BJRNUIXcyF/l8qeJtt4tysERpjNcA99yEs46HXHga/tcr+/+x/rnWXcBz6xpm0RCkqwYsmR8+BYX3qhhWOXF2QXfWzRwTEpUzA1Qe+Mt0X56PiygiTaySVeNookoOnh1BMx+CyBSC4hM2uwWqdKWprFQ9CviYIA/NVHEKjzfx6RqEEr6JxtltYQESjB+nlJ1QQPz62Azo7jU4BVjsMN0mLYXFk5b0tqGV8NhZAdmq1+w+e7U3;4:dCZ6KnG432gH7Y5Ld5+oAXT/H0NlPwHL5GY03o1Dfxtd+dqGgeIls7iv8PblU4GBVzre2n9EEjCrOW8l9pT/rKWLULyBhkcmaPQMJVN9ziflZ7L0idYKTxyGlDLsFJlgBB19mGIAFQapwbsArehlGPa8EPhygeuSKqe6hSGgSRsSa/nW4/pnvUiIEfiHi7aAV3uevyT5V2/GC5uaD46aEB5YPPhjPPL03tEgxrFTyVxBTnGTil2wjVX5E9m/1ZnZDhAIecximbaAzYuKffqkGQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(3231023)(2400081)(944501161)(93006095)(93001095)(3002001)(10201501046)(6055026)(6041288)(20161123558120)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(6072148)(201708071742011);SRVR:CY4PR12MB1144;BCL:0;PCL:0;RULEID:;SRVR:CY4PR12MB1144; X-Forefront-PRVS: 05641FD966 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(39860400002)(396003)(39380400002)(366004)(346002)(376002)(189003)(199004)(53546011)(5660300001)(386003)(3846002)(106356001)(31696002)(6116002)(4326008)(52146003)(81156014)(7736002)(105586002)(478600001)(2906002)(47776003)(31686004)(26005)(2950100002)(16526019)(83506002)(77096007)(86362001)(65826007)(6666003)(81166006)(23676004)(25786009)(97736004)(110136005)(16576012)(3260700006)(58126008)(6246003)(186003)(65806001)(229853002)(66066001)(65956001)(316002)(36756003)(6486002)(8936002)(90366009)(72206003)(230700001)(52116002)(64126003)(305945005)(2486003)(93886005)(76176011)(50466002)(8676002)(68736007)(53936002);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR12MB1144;H:[10.236.65.116];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDWTRQUjEyTUIxMTQ0OzIzOjREVnZpSjVlSXFCTnZBZHVpaWpuaUlyd1dB?= =?utf-8?B?MkthUVl6L3dtcEprOUhTcXk5YUtkNVgrZURjdG10WlVyR3ZOY0pXK1NjMDJ4?= =?utf-8?B?YW9IM1d5VG14dUVjTEtuTUppOEk4SXcrUzhxcmlBN1cxTXJOT0xxMjQyc0s2?= =?utf-8?B?ejZNRUVFZHFHaFk5clVyM3E2Ym1XUENVdm9XQ2hQN1FhcG5ZbmdLMmkrYWlT?= =?utf-8?B?SHVRdHNRQUpsa00zbHByUXRHbEpWZ3VGaUVvSlZBdk9La3c4SXkrcTlXN2My?= =?utf-8?B?aUp1cmZ5TTBlRDMwTmo1VG93Vys5STVOZVZSWmswai9WdVE1eWtPako2K0Fw?= =?utf-8?B?ZlUrbkJuU2FUK0FpZjlDVXR1ckdvVWZmVFdFeEIwSnl4bUtVaWRlMnNRa2FL?= =?utf-8?B?T1E4NzhJNWxpTWhMVzVOaURiM0lPcmJheGp1QjB0NXc4K1pRUmp1SGY0Zkgz?= =?utf-8?B?b3VpT1ZVWE9wRU41TTZvamp0MkpOVzdrRUtZZHJ1OUF4NHVKVExIWjBEcC9z?= =?utf-8?B?SW1MM2J2cVBlTHdkOUNhdXF1WUlBTzNJYm9OdThJTDRaa1BHWTJOc0RJTmJ4?= =?utf-8?B?Qkp2dko5cDZUOXdJRHlBdk1SSHdoN2svV3FhS290VVV5WkNtZFV5NENEekVL?= =?utf-8?B?NTMyd0Nkbkx6RlFoSWhFNHE4bCtYd3pZOGdGc2ZXVXZHUFg1Rys2RjZib3dk?= =?utf-8?B?MjJVVldXOFdGekE5dFVMMzZZSUNvakNMWlZ1SkJTSFdSY1Q2SUttWk5Scmha?= =?utf-8?B?YUVEa1RqR1JNK0lvUXZxd0o2cG1mY1hoN0RHbkZpVlRSNytxM3hCMUlWYmRj?= =?utf-8?B?ck15MXY2SE01bk5nWDh2YjdsRmx3d0s2SEtqeTdOeS9jdTRJLzhSTjhFRjlw?= =?utf-8?B?UFg0SG5GQThlWnMvazJyei9GL0l6MGt6eVVpZE9hYTZiTUpJZjl4OFhoWEJV?= =?utf-8?B?K3RjMU1XZVVmR2JrdkIrMVk1WVVJLy9RL0NzamIzMWdxaWVCNXorQXM4dW9v?= =?utf-8?B?OVhIVWhkdjIxaWpwdXFYTkNwajcrb1BwNHgxL1RKUmJyOXpoWFhnWm8wbStJ?= =?utf-8?B?dlFCZWxKcmwyV0swdVJweTB5RHAzdk5Ydmd4S2FiTFRHUXAyYU1HbG5iNE5h?= =?utf-8?B?eFNFWVZmcTZ6eWVaQlBMT0Rqb3ppa2pmNDJxb2tQMjRzUDJZYlNzbjJwN1kw?= =?utf-8?B?Q3JKWmVsR0k2cUhKM1BLUTlIZFpDNGdtZUZ6R01NUGZPUzcxWk9OYUF2QTV0?= =?utf-8?B?MWdJNVZCR25qZ0lrNmJnRTJQV29EZ20zRnJxaHIraExOWEN5MjlxQ2hwMUVT?= =?utf-8?B?TDNKMG9EQXdlRnczVWZ3V0grdStJSnpqZEdUTVhnY00wbytwenc2NTB1aUlZ?= =?utf-8?B?YkJvbllEcWd4Z2JyYm1HTzAvK2I4d2I0REhrdWo1QWwxTVhtTjJWdy9yOFB0?= =?utf-8?B?akxnMytpUEs3M1pzdFh3YzNjOFMzQWhFajUrQnhvVUxIdm4rZzlMZ2V4ZXov?= =?utf-8?B?VlR2WUNYODZacncvNGtDTEs4eGJpTTZvVDAxbkpBRkcvZUlMbnllMU5vTzJJ?= =?utf-8?B?blJwTXJDUy9OQ3JPYW5HTzlmK2F5cEQ3aHB5aXk3T0VNMHBkM28wVVhuZkpQ?= =?utf-8?B?SHZKWmdBa0VzQUIxSEpXVFhYYmdrSm9mRVlyOWRZb3NBeDVNKys1OGNQdTUy?= =?utf-8?B?MDNhTXZOTFFhbkdwajFvNnNtNmM4eS9Fd2FaeW93S1kwbzdoT1BHQzlVUjNZ?= =?utf-8?B?Y3pUZFFyczVKbUhBQ2FydGhneEJxbWtyd3ltdXc5OXE5V3ZaaWxtbWh6c2dL?= =?utf-8?B?STZ6RTBWemRuZmx0bnd5S3NCZUY5YmR2ck93YW1VeUpXVTZmckFCWE5NNFE2?= =?utf-8?B?ZGVIUWhjQ0V0NS82UlZQWEpibTJjdEwvNE1abVo2YlJSYzBuYkdaVkZLaVV4?= =?utf-8?Q?6MLf/twe8M5tlGWWmHlH3GCCsM0dpQ=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1144;6:E8fHBdHLB6v4RzcZfNeJ5iHvQVn+WYuPK6NsQnkY2Uh7cdGZxhpdfl2YF+BmemT3RopHEY3DV//mOj0VTKsdY2o59wZ7Y2otFQb2rzFD4Xpxu0HUE6N+SCwy+NfnasXAm113sEgJ0FFzwED7geL74PyBybKdiiHBjMRgsEJtsQ0nD2mpao6Oo3yN61Q42uBK0nCfl6SsO0UEqO4WJeqU6JCjZUOcT0szQVM4laXfABxXaF5Oo59MtUOZYR9PNX3Km1Z9AP0ti+z/kMvzDBTlbYSxoG7YJs3dpP68EGAXgpSk217g56QHqGSL3E9vFjoZw6J3G3inu4T/C8+bNAWNAuM004+k1XVWWHMyos9YBj8=;5:iZjGdQg8pUY5sFax7gE7HWYHC8CcE6BOUIkrfW1dIZErqoB842RTP8ramFaUK1sZV/WG2AlTcJ/Bor+DK4sKFHeB7BqugsN428NUmhpXAvilANKl1IhGrJiYQPRSG+SSVbomKetes13SWv5GggRG160j+Ycu9tCjMQb8E2ILlZc=;24:LcLl85yIfGP+cFA4wdpeybsJrFArk7npbqtsKa50NVohRdUdWGw57JxWu1/RCqfdNndovo+4A9rnq/2uKvEPaGuxa9q2fqF3mYarhG+iKX4=;7:I0M8mwRgsu3SpTlu7P9P6tYOvXe821SpLpmpLaKsG96nJu4XHDEZ4uES4tp9VAlYP5qdYsRSFhC3NytSL+1FBPIwCNCTLPRpkinV6GiTlBqkstC+7MVRCS7wIP023wV8jILhJ0FszI1Es0v4PnxHOXb24CJHiGUjyU/nWw2xGWffK6ZTukXHaPEeNUXd7R42nQc4qSFA3yYmLV4xUYbu4eJYdU/obnGnJXVuFgNYG10KqddPrgaVo60fsebngBTi SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR12MB1144;20:DlrY/OBZ3+Fh5XroVhYEVWx27TyF7fdqfv5/XxHJvl2v01PrePwDedgBQ1O3y2NlFEZ72QkDIt+q5cFNU9rmvp9zg6jemqNkcTLZbJIdgFZ44rxwtKZ4fyaVLBD/YwRzLhnfJ6RSCb6VnNEfjMEpLl7VlMFr6SY8mko1bM4iPIfUsIVKZ4twEhgk5hv2e41RTHuovRX0hOqcO5tHnCb0/JXGkFv8ECngnP4a0ZiI9lqHJ4A4yj7pGjfPiWC8Jr0v X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2018 23:14:46.4458 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b0f11745-73a9-41ec-0671-08d56512978c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1144 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590681520403481900?= X-GMAIL-MSGID: =?utf-8?q?1590698692882958314?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 1/26/2018 4:10 PM, Borislav Petkov wrote: > On Fri, Jan 26, 2018 at 09:59:44PM +0000, David Woodhouse wrote: >> If we wanted to do this kind of thing, we'd do it the other way round. >> Turn the *Intel* feature into both 'IBRS' and 'IBPB' CPU-visible >> features, and have those defined in the AMD word. > > You lost me here: have those defined in the AMD word? > >> Then use virtual bits with "" for the software features, since we >> don't want *those* to appear in /proc/cpuinfo. > > Whatever we do, I think it would be most consistent to have three > strings, *both* on Intel and AMD visible in cpuinfo: "ibrs", "ibpb" and > "stibp" so that there's no confusion what is enabled on each box. > > Now, those three can be the *virtual* features which get set by the > actual CPUID features on init. And the latter, the *actual* CPUID > features don't need to be visible in cpuinfo: people shouldn't care > whether "spec_ctrl" on Intel and "pred_cmd" on AMD both mean "ibpb". It > should be simply "ibpb" on both vendors in cpuinfo. > > Ditto for the others. > > This way you have one unified message of what is enabled on *any* box. That sounds good to me. Thanks, Tom >