From mboxrd@z Thu Jan  1 00:00:00 1970
From: Zbigniew Bodek <zbodek@caviumnetworks.com>
Subject: Re: [PATCH v2 02/12] lib: add cryptodev type for the
 upcoming ARMv8 PMD
Date: Wed, 7 Dec 2016 20:04:03 +0100
Message-ID: <2cec934f-b645-be28-8e82-a271692260d0@caviumnetworks.com>
References: <1480851219-45071-1-git-send-email-zbigniew.bodek@caviumnetworks.com>
 <1481077985-4224-1-git-send-email-zbigniew.bodek@caviumnetworks.com>
 <1481077985-4224-3-git-send-email-zbigniew.bodek@caviumnetworks.com>
 <4126251.ynkckbu1rM@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <zbigniew.bodek@caviumnetworks.com>, <pablo.de.lara.guarch@intel.com>,
 <jerin.jacob@caviumnetworks.com>, <declan.doherty@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0040.outbound.protection.outlook.com [104.47.41.40])
 by dpdk.org (Postfix) with ESMTP id 5E9522BC5
 for <dev@dpdk.org>; Wed,  7 Dec 2016 20:04:13 +0100 (CET)
In-Reply-To: <4126251.ynkckbu1rM@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 06.12.2016 21:27, Thomas Monjalon wrote:
> 2016-12-06 18:32, zbigniew.bodek@caviumnetworks.com:
>> From: Zbigniew Bodek <zbigniew.bodek@caviumnetworks.com>
>>
>> Add type and name for ARMv8 crypto PMD
>>
>> Signed-off-by: Zbigniew Bodek <zbigniew.bodek@caviumnetworks.com>
> [...]
>> --- a/lib/librte_cryptodev/rte_cryptodev.h
>> +++ b/lib/librte_cryptodev/rte_cryptodev.h
>> @@ -66,6 +66,8 @@
>>  /**< KASUMI PMD device name */
>>  #define CRYPTODEV_NAME_ZUC_PMD		crypto_zuc
>>  /**< KASUMI PMD device name */
>> +#define CRYPTODEV_NAME_ARMV8_PMD	crypto_armv8
>> +/**< ARMv8 CM device name */
>>
>>  /** Crypto device type */
>>  enum rte_cryptodev_type {
>> @@ -77,6 +79,7 @@ enum rte_cryptodev_type {
>>  	RTE_CRYPTODEV_KASUMI_PMD,	/**< KASUMI PMD */
>>  	RTE_CRYPTODEV_ZUC_PMD,		/**< ZUC PMD */
>>  	RTE_CRYPTODEV_OPENSSL_PMD,    /**<  OpenSSL PMD */
>> +	RTE_CRYPTODEV_ARMV8_PMD,	/**< ARMv8 crypto PMD */
>>  };
>
> Can we remove all these types and names in the generic crypto API?
>

Hello Thomas,

I added another PMD type and therefore we need new, unique number for 
it. I'm not sure if I understand correctly what you mean here, so please 
elaborate.

Kind regards
Zbigniew