From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00E3BC433ED for ; Tue, 11 May 2021 08:58:59 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5768861364 for ; Tue, 11 May 2021 08:58:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5768861364 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgOED-0008At-3W for qemu-devel@archiver.kernel.org; Tue, 11 May 2021 04:58:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgNqt-0000qy-F4 for qemu-devel@nongnu.org; Tue, 11 May 2021 04:34:52 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40998) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgNqp-0004LT-Jm for qemu-devel@nongnu.org; Tue, 11 May 2021 04:34:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620722085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dtl0WP6ze59bBic0SmLC98x635Y4j/A3sQWxGw2lzHM=; b=KfhbAISn5zS8JLTEoJdh/h88ljXIJ3HP9uc9AfbJRYSSWIrJBlUUbu2Gnsoqq8HC21TxQG 5b7YAgy9Rajf238k9tYh3EpvS3xK68HiABXFa6gh2X+nxCbj+JD6OjFa1fDWKWVpVtwZXS 0mbrzS+8kXThNXkmRNJWZMgLCXA6BOU= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-393-IqOSRnhOPjKmZlWfRC2auA-1; Tue, 11 May 2021 04:34:44 -0400 X-MC-Unique: IqOSRnhOPjKmZlWfRC2auA-1 Received: by mail-ed1-f70.google.com with SMTP id i17-20020a50fc110000b0290387c230e257so10534236edr.0 for ; Tue, 11 May 2021 01:34:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=dtl0WP6ze59bBic0SmLC98x635Y4j/A3sQWxGw2lzHM=; b=KgY7IRaGsVzQK+Ia/GrVbXBRqiaZ7EScydXiINtdPlyzvUDJi6FL832yXN8PcjJYxC QGvMRT2bl4UVj2Ug1c5l38lpzV5xQWmYSbxR4EPOOPBPpoHXOTqy2qi7MI012+nwb18R VaPjIQvdGcVs1AveG9N2xHLDCvrlJIIr1JQaTiDyItTHifVVjOP9+8blpXxpE0y9Fvsy wG+9vsCE1ySLcKy0wDACFh6k2f7Vsp7HbBXcLksxAK0GmgYfwCpfM3feF6TjLu8YflIB eA1eW6HyzK+DdFBxZhtyQFaEQQ20mq39ET5M+QqwKIMNhjI9j0bUGbgssMDQqzsSTWXo Ehxw== X-Gm-Message-State: AOAM532Ff84qQGP2ZXn3J0IGnbGeBukG48zXePwBa9q5A1ltiU1hv91B WYobTWzyPyCOZTaTq1q5/pCZUeJQGqTqh6+DyzAQ04Drraweys2KDRj/kxMl9ekP1YZIyLF3gUO nc/fiEBOg7S813OBbZX7ik98akf+hD0tTsmetqf07K5CC+lv6i3XsvqjQJvN9/BbuceE= X-Received: by 2002:a50:bec1:: with SMTP id e1mr34702346edk.116.1620722083336; Tue, 11 May 2021 01:34:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydkiEe9S5kCz3MHMU6v5fXMWwgCtkOvmQj3KS3zyBvo2dTHYV5MCLQU0Xmc19XMkdSIAa04Q== X-Received: by 2002:a50:bec1:: with SMTP id e1mr34702320edk.116.1620722083109; Tue, 11 May 2021 01:34:43 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id o20sm7654889eds.20.2021.05.11.01.34.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 May 2021 01:34:42 -0700 (PDT) Subject: Re: [PATCH 5/6] co-shared-resource: protect with a mutex To: Vladimir Sementsov-Ogievskiy , Emanuele Giuseppe Esposito , qemu-block@nongnu.org References: <20210510085941.22769-1-eesposit@redhat.com> <20210510085941.22769-6-eesposit@redhat.com> <57fd4d5f-4645-905f-998c-a120c042fdc7@virtuozzo.com> From: Paolo Bonzini Message-ID: <2cedc820-d14c-b7e6-5024-10357e0e1b36@redhat.com> Date: Tue, 11 May 2021 10:34:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <57fd4d5f-4645-905f-998c-a120c042fdc7@virtuozzo.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , John Snow , qemu-devel@nongnu.org, Stefan Hajnoczi , Max Reitz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 10/05/21 13:40, Vladimir Sementsov-Ogievskiy wrote: > >> co-shared-resource is currently not thread-safe, as also reported >> in co-shared-resource.h. Add a QemuMutex because co_try_get_from_shres >> can also be invoked from non-coroutine context. > > But it doesn't. It's called only from co_get_from_shres(). So, better > make it a static function first. It's a sensible interface though. It lets you sleep or retry in your own way if you cannot get the resources, so (apart from the unlocked/locked confusion in the names) I like keeping it in the public API. Paolo