From: "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
To: "kuba@kernel.org" <kuba@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"yongxin.liu@windriver.com" <yongxin.liu@windriver.com>,
"sassmann@redhat.com" <sassmann@redhat.com>,
"Brelinski, TonyX" <tonyx.brelinski@intel.com>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>
Subject: Re: [PATCH net 1/3] net: ethernet: ixgbe: don't propagate -ENODEV from ixgbe_mii_bus_init()
Date: Thu, 4 Mar 2021 19:00:18 +0000 [thread overview]
Message-ID: <2cff55826c19c9765fac85dc0d59a0c0e0d38a47.camel@intel.com> (raw)
In-Reply-To: <20210304105000.5c001707@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Thu, 2021-03-04 at 10:50 -0800, Jakub Kicinski wrote:
> On Wed, 3 Mar 2021 17:06:47 -0800 Tony Nguyen wrote:
> > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> >
> > It's a valid use-case for ixgbe_mii_bus_init() to return -ENODEV -
> > we
> > still want to finalize the registration of the ixgbe device. Check
> > the
> > error code and don't bail out if err == -ENODEV.
> >
> > This fixes an issue on C3000 family of SoCs where four ixgbe
> > devices
> > share a single MDIO bus and ixgbe_mii_bus_init() returns -ENODEV
> > for
> > three of them but we still want to register them.
> >
> > Fixes: 09ef193fef7e ("net: ethernet: ixgbe: check the return value
> > of ixgbe_mii_bus_init()")
> > Reported-by: Yongxin Liu <yongxin.liu@windriver.com>
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > Tested-by: Tony Brelinski <tonyx.brelinski@intel.com>
> > Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
>
> Are you sure this is not already fixed upstream by:
>
> bd7f14df9492 ("ixgbe: fix probing of multi-port devices with one
> MDIO")
>
> ?
That looks to solve this issue. I'll drop this patch and resend the
series.
Thanks,
Tony
next prev parent reply other threads:[~2021-03-04 19:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-04 1:06 [PATCH net 0/3][pull request] Intel Wired LAN Driver Updates 2021-03-03 Tony Nguyen
2021-03-04 1:06 ` [PATCH net 1/3] net: ethernet: ixgbe: don't propagate -ENODEV from ixgbe_mii_bus_init() Tony Nguyen
2021-03-04 18:50 ` Jakub Kicinski
2021-03-04 19:00 ` Nguyen, Anthony L [this message]
2021-03-04 1:06 ` [PATCH net 2/3] ixgbe: fail to create xfrm offload of IPsec tunnel mode SA Tony Nguyen
2021-03-04 1:06 ` [PATCH net 3/3] ixgbe: Fix memleak in ixgbe_configure_clsu32 Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cff55826c19c9765fac85dc0d59a0c0e0d38a47.camel@intel.com \
--to=anthony.l.nguyen@intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
--cc=tonyx.brelinski@intel.com \
--cc=yongxin.liu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.