From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2425BC77B7A for ; Wed, 31 May 2023 08:30:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234805AbjEaIaR (ORCPT ); Wed, 31 May 2023 04:30:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235163AbjEaIaB (ORCPT ); Wed, 31 May 2023 04:30:01 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38DC4137 for ; Wed, 31 May 2023 01:30:00 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-96f99222e80so143725266b.1 for ; Wed, 31 May 2023 01:30:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685521798; x=1688113798; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mqeVSaDQ2xCQutIzmyZDcrRktFLClt8bCyhV44jjeTM=; b=hb6XbWCmFp9iggCj+EtVdZ++OFKwRK7+1Vx3wg7FkPd9247QX3FqpNb96H+oJ6Ot5q Oyzs1ENPgnGJO4LHgiI8ffFPQR1Ifu1qsT5bIOt+cbSXo1vwJTz+dv8tpA1wPv1dTinn 04Up8VvqXVhqL/HsXSZlB1+yT6v+M3qxDy65u96GiTHZSEAAMSVp0MMidnNCOpucvi+L qYVLZgpxbc3uSvooU5p4+jPOoN16Un2s+cllz/tQYw0vBi3fdSHUX6FqjZvgdnjjVDdJ t6ywCEzrvZzcJOd+3VjOZkWjoq/6oCb3eX2mjwFeiUjfR5WKhF41CLkcy3hJ16hpMLvK wFKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685521798; x=1688113798; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mqeVSaDQ2xCQutIzmyZDcrRktFLClt8bCyhV44jjeTM=; b=g/1ICCjW5Rvq3JcBfKBbCQxlKn+RNOLHN6c3CwHedS+PHPZg6Ltg9b4G5TD6UcvaiL x/jhlSfbxyEH7iuBDr89kZrInk8zUGutNucZcbg69sW5ipe6JBp9eFsM5z+kV8rsxdO6 CSjwse/EHUOoJRpswufZ5JjygQB7rmd0UlYq4tCOel+9bNuK+5pUPFSRDV83jekwEjSf LoZjfO5YEP5LbpRrwiAVhlQs76kVudBP2BUlLN4mZ0cqxpANNtFiG7UtXjJfmVryRwnw FIMLaASrh4LoVVcQfamQiyshL5sG6Mti8b5GrILfhLpf3HQMjpt8RYjR8KfmN7ITkvqC 1s2w== X-Gm-Message-State: AC+VfDzbDcTEl0zBo/OImCtt6HLTR1JoksOAhMSPY5Bgql7z8qg07qIX cLDEtazVT3mh7auuHCFEWvC3AQ== X-Google-Smtp-Source: ACHHUZ7UCWGXisoHiCFtacjTJmCPyZNi4Z9A9Xf3XV640s4WvgXKU0SGx9ikpx9i/6XdnDRRu38Yuw== X-Received: by 2002:a17:907:7e9e:b0:965:aa65:233f with SMTP id qb30-20020a1709077e9e00b00965aa65233fmr13240884ejc.2.1685521798567; Wed, 31 May 2023 01:29:58 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id r16-20020a056402019000b00514b3a2008esm1205699edv.2.2023.05.31.01.29.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 01:29:58 -0700 (PDT) Message-ID: <2d11ba2d-7977-abf8-99df-6e3184ce6220@linaro.org> Date: Wed, 31 May 2023 10:29:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 1/5] dt-bindings: arm: ti: add toradex,verdin-am62 et al. Content-Language: en-US To: Andrew Davis , Francesco Dolcini , Nishanth Menon , Vignesh Raghavendra Cc: Francesco Dolcini , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230524143631.42471-1-francesco@dolcini.it> <20230524143631.42471-2-francesco@dolcini.it> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/05/2023 19:48, Andrew Davis wrote: > On 5/24/23 9:36 AM, Francesco Dolcini wrote: >> From: Francesco Dolcini >> >> Add toradex,verdin-am62 for Toradex Verdin AM62 SoM, its >> nonwifi and wifi variants and the carrier boards (Dahlia, >> Verdin Development Board and Yavia) they may be mated in. >> >> Link: https://developer.toradex.com/hardware/verdin-som-family/modules/verdin-am62/ >> Link: https://www.toradex.com/computer-on-modules/verdin-arm-family/ti-am62 >> Signed-off-by: Francesco Dolcini >> --- >> .../devicetree/bindings/arm/ti/k3.yaml | 20 +++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml >> index e1183f90bb06..e3aee191d403 100644 >> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml >> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml >> @@ -33,6 +33,26 @@ properties: >> - ti,am62-lp-sk >> - const: ti,am625 >> >> + - description: K3 AM62x SoC Toradex Verdin Modules and Carrier Boards >> + items: >> + - enum: >> + - toradex,verdin-am62-nonwifi-dahlia # Verdin AM62 Module on Dahlia >> + - toradex,verdin-am62-nonwifi-dev # Verdin AM62 Module on Verdin Development Board >> + - toradex,verdin-am62-nonwifi-yavia # Verdin AM62 Module on Yavia >> + - const: toradex,verdin-am62-nonwifi # Verdin AM62 Module without Wi-Fi / BT > > Does this add anything? Not sure we need to split compatibles based on this, things > like wifi vs nowifi can be described in DT, same for different memory size models, etc.. > > In fact I'm not sure we get much value at all out of top level whole-SoC compatible > strings. Maybe we did when there was matching in kernel to do device specific fixups, > but that isn't really used much in ARM64. If I understand correctly, this is different SoM, so different hardware. It is fine to have different board compatibles, because you will have two different DTS. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B157FC77B73 for ; Wed, 31 May 2023 08:30:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hIZw9238iA0k30IfN/4QCHI4ZksKMKjwIxtgxLwuzvE=; b=h+ua1PezCRn5r3 FLCpmPVUUttJBTibJVW+fiDQvgexaaOkZdtuuy2iFbD01/6AXt0Pt0SncrBWT9cTaHX8X2miO/t5C L0tFRr1RRDj4MlHCz7ER+gRTmsb5pltgbm4eZX74Fjqb/L7O9n/0izeGJ56RktMybf/IvxRCqgIHf bOVYcL2ags1NIFRTD8RZ9YsvOETvbsTLZ6RUQSkkbgnd+txr+1pPgOdfdJGh4wYmy06iWkdxu3Mje V//mAgdLTFHF6gFq+30pFxpmuW2bJnDKtcDr3rX7UeNzyim2asPN1ejwCy4Mup/p8AoKVIjnrDj50 5BBecdRFrMosEPOiPPBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q4HDY-00GcYT-05; Wed, 31 May 2023 08:30:04 +0000 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q4HDV-00GcXT-0c for linux-arm-kernel@lists.infradead.org; Wed, 31 May 2023 08:30:02 +0000 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-96fab30d1e1so146659566b.0 for ; Wed, 31 May 2023 01:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685521798; x=1688113798; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mqeVSaDQ2xCQutIzmyZDcrRktFLClt8bCyhV44jjeTM=; b=hb6XbWCmFp9iggCj+EtVdZ++OFKwRK7+1Vx3wg7FkPd9247QX3FqpNb96H+oJ6Ot5q Oyzs1ENPgnGJO4LHgiI8ffFPQR1Ifu1qsT5bIOt+cbSXo1vwJTz+dv8tpA1wPv1dTinn 04Up8VvqXVhqL/HsXSZlB1+yT6v+M3qxDy65u96GiTHZSEAAMSVp0MMidnNCOpucvi+L qYVLZgpxbc3uSvooU5p4+jPOoN16Un2s+cllz/tQYw0vBi3fdSHUX6FqjZvgdnjjVDdJ t6ywCEzrvZzcJOd+3VjOZkWjoq/6oCb3eX2mjwFeiUjfR5WKhF41CLkcy3hJ16hpMLvK wFKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685521798; x=1688113798; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mqeVSaDQ2xCQutIzmyZDcrRktFLClt8bCyhV44jjeTM=; b=eDmpVvsIC4MOJXGOgOJycu9kcXSFAci+3raI0+L3HeQbfNqBEa98CoEXLfbleG4Zam xcQKMaw1Ke/BkJ+/HbO3v36FAnbfG0SJCZ5t2fW/V78ZWtfk70vWhC2mpCqMWGQmJtgK xYihWI3l7x01wjgzxTHLVk73gARwoGSdhDbqzWZ80EAjNzCmG0SvdUiMTqp5IEz5hyMi V/Ji3+ksu4LbvHMcbyyAXtwody4Fy+hzoME88+YCTgApVvqoDMB+Et3s0qnRkOJob1xJ qhByYdq81HEg0h3IViPsQd3k83zGCBVzB7mAO7OceyTWkE5kYRHGP7Qwz+MLJ6sjD7co PHPg== X-Gm-Message-State: AC+VfDzty0JFJM5Y25TCGBP9CeSllTcH07Cd432j5k7Dcp8PcieHu96E G9ueoa5Y056j6TZ9jKKyPW3E0g== X-Google-Smtp-Source: ACHHUZ7UCWGXisoHiCFtacjTJmCPyZNi4Z9A9Xf3XV640s4WvgXKU0SGx9ikpx9i/6XdnDRRu38Yuw== X-Received: by 2002:a17:907:7e9e:b0:965:aa65:233f with SMTP id qb30-20020a1709077e9e00b00965aa65233fmr13240884ejc.2.1685521798567; Wed, 31 May 2023 01:29:58 -0700 (PDT) Received: from [192.168.1.20] ([178.197.199.204]) by smtp.gmail.com with ESMTPSA id r16-20020a056402019000b00514b3a2008esm1205699edv.2.2023.05.31.01.29.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 May 2023 01:29:58 -0700 (PDT) Message-ID: <2d11ba2d-7977-abf8-99df-6e3184ce6220@linaro.org> Date: Wed, 31 May 2023 10:29:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1 1/5] dt-bindings: arm: ti: add toradex,verdin-am62 et al. Content-Language: en-US To: Andrew Davis , Francesco Dolcini , Nishanth Menon , Vignesh Raghavendra Cc: Francesco Dolcini , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230524143631.42471-1-francesco@dolcini.it> <20230524143631.42471-2-francesco@dolcini.it> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230531_013001_238387_0CCA8CD5 X-CRM114-Status: GOOD ( 15.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/05/2023 19:48, Andrew Davis wrote: > On 5/24/23 9:36 AM, Francesco Dolcini wrote: >> From: Francesco Dolcini >> >> Add toradex,verdin-am62 for Toradex Verdin AM62 SoM, its >> nonwifi and wifi variants and the carrier boards (Dahlia, >> Verdin Development Board and Yavia) they may be mated in. >> >> Link: https://developer.toradex.com/hardware/verdin-som-family/modules/verdin-am62/ >> Link: https://www.toradex.com/computer-on-modules/verdin-arm-family/ti-am62 >> Signed-off-by: Francesco Dolcini >> --- >> .../devicetree/bindings/arm/ti/k3.yaml | 20 +++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml >> index e1183f90bb06..e3aee191d403 100644 >> --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml >> +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml >> @@ -33,6 +33,26 @@ properties: >> - ti,am62-lp-sk >> - const: ti,am625 >> >> + - description: K3 AM62x SoC Toradex Verdin Modules and Carrier Boards >> + items: >> + - enum: >> + - toradex,verdin-am62-nonwifi-dahlia # Verdin AM62 Module on Dahlia >> + - toradex,verdin-am62-nonwifi-dev # Verdin AM62 Module on Verdin Development Board >> + - toradex,verdin-am62-nonwifi-yavia # Verdin AM62 Module on Yavia >> + - const: toradex,verdin-am62-nonwifi # Verdin AM62 Module without Wi-Fi / BT > > Does this add anything? Not sure we need to split compatibles based on this, things > like wifi vs nowifi can be described in DT, same for different memory size models, etc.. > > In fact I'm not sure we get much value at all out of top level whole-SoC compatible > strings. Maybe we did when there was matching in kernel to do device specific fixups, > but that isn't really used much in ARM64. If I understand correctly, this is different SoM, so different hardware. It is fine to have different board compatibles, because you will have two different DTS. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel