From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69632C433EF for ; Tue, 21 Sep 2021 14:08:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1B356115A for ; Tue, 21 Sep 2021 14:08:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E1B356115A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xen0n.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:42200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mSgRk-0006Xl-GG for qemu-devel@archiver.kernel.org; Tue, 21 Sep 2021 10:08:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43080) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSgQj-0005gQ-VL for qemu-devel@nongnu.org; Tue, 21 Sep 2021 10:07:29 -0400 Received: from [115.28.160.31] (port=52366 helo=mailbox.box.xen0n.name) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mSgQf-0002dq-FB for qemu-devel@nongnu.org; Tue, 21 Sep 2021 10:07:29 -0400 Received: from [192.168.9.172] (unknown [101.88.29.172]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id 88746600FF; Tue, 21 Sep 2021 22:07:08 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=xen0n.name; s=mail; t=1632233228; bh=hNNtRFfAvLnozrYNAs4M2bRQeMKeYQko95ogE8fVS0g=; h=Date:Subject:To:References:From:In-Reply-To:From; b=E8bYKqCJfhhu1v/fgcHK0XMZvYlNHDS8dLcQqU2CwsGsAm7tsHlhzmx7EnIXeJTA7 rHUSqPIG2Tpzt40lfRdkQDVDdmg8ZQ32weuqZtuBvb4ojx8edAS0hxj+RdwcFuR8db zCXUs/ltirnxEJ09l/IURz3uwjhATYVXFHMNEzHk= Message-ID: <2d1c4431-1d69-bd71-fc74-6a29cbd10f04@xen0n.name> Date: Tue, 21 Sep 2021 22:07:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:94.0) Gecko/20100101 Thunderbird/94.0a1 Subject: Re: [PATCH 28/30] configure, meson.build: Mark support for 64-bit LoongArch hosts Content-Language: en-US To: Richard Henderson , qemu-devel@nongnu.org References: <20210920080451.408655-1-git@xen0n.name> <20210920080451.408655-29-git@xen0n.name> From: WANG Xuerui In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Host-Lookup-Failed: Reverse DNS lookup failed for 115.28.160.31 (failed) Received-SPF: pass client-ip=115.28.160.31; envelope-from=i.qemu@xen0n.name; helo=mailbox.box.xen0n.name X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Richard, On 9/21/21 21:30, Richard Henderson wrote: > On 9/20/21 11:02 PM, WANG Xuerui wrote: > >> So should I drop the explicit probing for __loongarch64, instead just >> probe for __loongarch__ and later #error out the non-__loongarch64 >> cases individually? > > I'm ok with checking the __loongarch64 define, but I thing > ARCH=loongarch is sufficient. That name will apply to > linux-user/host/$ARCH/ and tcg/$ARCH/. > I just dug deeper into this while waiting for compilations; indeed the cpu variable must be "loongarch64" but ARCH could be just "loongarch". The $cpu is shoved directly into the meson cross file as CPU family name, for which only "loongarch64" is valid [1]. I'll keep probing for __loongarch64 but just transform the ARCH value. [1]: https://mesonbuild.com/Reference-tables.html#cpu-families