From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16738C47082 for ; Mon, 31 May 2021 14:09:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF3676135C for ; Mon, 31 May 2021 14:09:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233277AbhEaOKr (ORCPT ); Mon, 31 May 2021 10:10:47 -0400 Received: from szxga08-in.huawei.com ([45.249.212.255]:3306 "EHLO szxga08-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233032AbhEaNob (ORCPT ); Mon, 31 May 2021 09:44:31 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4FtxFF3VqMz1BG6n; Mon, 31 May 2021 21:38:09 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 31 May 2021 21:42:49 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 31 May 2021 21:42:49 +0800 Subject: Re: [PATCH 01/15] mm: add setup_initial_init_mm() helper To: Geert Uytterhoeven CC: Andrew Morton , Linux Kernel Mailing List References: <20210529105504.180544-1-wangkefeng.wang@huawei.com> <20210529105504.180544-2-wangkefeng.wang@huawei.com> From: Kefeng Wang Message-ID: <2d20b6c4-532a-282c-5184-4c0151eb30ce@huawei.com> Date: Mon, 31 May 2021 21:42:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/5/31 15:45, Geert Uytterhoeven wrote: > Hi Kefeng, > > On Sat, May 29, 2021 at 12:47 PM Kefeng Wang wrote: >> Add setup_initial_init_mm() helper to setup kernel text, >> data and brk. >> >> Signed-off-by: Kefeng Wang > Thanks for your patch! > >> --- a/include/linux/mm_types.h >> +++ b/include/linux/mm_types.h >> @@ -564,6 +564,16 @@ struct mm_struct { >> }; >> >> extern struct mm_struct init_mm; >> +static inline void setup_initial_init_mm(char *start_code, >> + char *end_code, >> + char *end_data, >> + char *brk) > "void *" (for all four)? The original users are all "char*",  so same here ;) > >> +{ >> + init_mm.start_code = (unsigned long)start_code; >> + init_mm.end_code = (unsigned long)end_code; >> + init_mm.end_data = (unsigned long)end_data; >> + init_mm.brk = (unsigned long)brk; >> +} > Gr{oetje,eeting}s, > > Geert >