From: Jens Axboe <axboe@kernel.dk>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
io-uring@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] io_uring: wakeup threads waiting for EPOLLOUT events
Date: Thu, 16 Jan 2020 08:29:07 -0700 [thread overview]
Message-ID: <2d2dda92-3c50-ee62-5ffe-0589d4c8fc0d@kernel.dk> (raw)
In-Reply-To: <20200116134946.184711-1-sgarzare@redhat.com>
On 1/16/20 6:49 AM, Stefano Garzarella wrote:
> io_uring_poll() sets EPOLLOUT flag if there is space in the
> SQ ring, then we should wakeup threads waiting for EPOLLOUT
> events when we expose the new SQ head to the userspace.
>
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
>
> Do you think is better to change the name of 'cq_wait' and 'cq_fasync'?
I honestly think it'd be better to have separate waits for in/out poll,
the below patch will introduce some unfortunate cacheline traffic
between the submitter and completer side.
--
Jens Axboe
next prev parent reply other threads:[~2020-01-16 15:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 13:49 [PATCH] io_uring: wakeup threads waiting for EPOLLOUT events Stefano Garzarella
2020-01-16 15:29 ` Jens Axboe [this message]
2020-01-16 15:55 ` Stefano Garzarella
2020-01-16 16:00 ` Jens Axboe
2020-01-16 16:26 ` Stefano Garzarella
2020-01-16 16:30 ` Jens Axboe
2020-01-16 17:03 ` Stefano Garzarella
2020-01-23 19:13 ` Jens Axboe
2020-01-23 21:45 ` Stefano Garzarella
2020-01-24 1:28 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d2dda92-3c50-ee62-5ffe-0589d4c8fc0d@kernel.dk \
--to=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sgarzare@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.