From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27DEAC433F5 for ; Thu, 3 Mar 2022 19:00:28 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 417C683D71; Thu, 3 Mar 2022 20:00:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="BcZNoGva"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5173D83D72; Thu, 3 Mar 2022 20:00:24 +0100 (CET) Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 08AE683D6F for ; Thu, 3 Mar 2022 20:00:21 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jbx6244@gmail.com Received: by mail-ej1-x62f.google.com with SMTP id p15so12684820ejc.7 for ; Thu, 03 Mar 2022 11:00:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=myE3kB3eEe9zXDRi/eime6X2ikBQDWttoq2Unt9qxtg=; b=BcZNoGvabpupHv2WHvANL512EXymRoA52raKJtU0Z1jyGtQxmD4GKKU1rjyYg8TVDZ S2dBeJFMhgZFxriJEm0+X3eBrFECwS4+ICZn9Tvh9cyyroHcuz0f7Le9gisNbWxbUjrS 0ynZGP77WklfHJjYhqL6hpqIETPVMcWwmUbfRXLbElOcoh4CT1f3QHwBHp+zIMbb4aAi bN7nodKtPQMQ/o79viij7EkTUjVlmKzm2rpnhYfVu5/oGSVqWCIm/D8Q0W7TghMwrC0g Wo2m5URmTxNeMuG77MU689lNbiE8QgG9/KvJ/g27r+v5FfzAnOd9nUjeHN69fM3B1Fga kjag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=myE3kB3eEe9zXDRi/eime6X2ikBQDWttoq2Unt9qxtg=; b=mkKsbh64OZGUf7IudnmRFnO8sVf2qhSjuS2aa5TeiQBjbGt/m6Mh7YfnZjOcdKreCJ A2NqcKSQvRis8SPdRItBV5xDydzen6U6p925ztHYMa6OdmwkgBhLaQ/kMylNa6pTk/bm VnJ5GRN53oGK2+KzKLQO7CxzqCiU7eV1k0NXB/2NJT0MwU+PnWeAbM+t1mBGDrmxOp2w 1q2uzZgSpi9OJ8h2MkGooC5192TeFaGpWga0S3CiHKBKrzdvjaaubjo9Bx8ZApwKZoAy kVKz4SgcQHmWcRYl8OdL4SsFWVQk5UvmWISrkTG+hNdW9l1EtF6VnP9T4kk+rQaLWTk3 Z6hA== X-Gm-Message-State: AOAM533AqA30oR0W/dB1T6mi5dVahO/E2LmdTm9C2ww2rupbK1jYjbS+ wSWsW+s+qLk6ugSpR8fEXTc= X-Google-Smtp-Source: ABdhPJyx3KH3klkMSY/TLV13OssAmZxXHl/KypGuHIYwoNqrs9fOHy1ZLIxYjmDQsG3qsvyusjZR0Q== X-Received: by 2002:a17:906:3fc3:b0:6ce:3eda:95a4 with SMTP id k3-20020a1709063fc300b006ce3eda95a4mr27923175ejj.271.1646334020346; Thu, 03 Mar 2022 11:00:20 -0800 (PST) Received: from [192.168.2.1] (81-204-249-205.fixed.kpn.net. [81.204.249.205]) by smtp.gmail.com with ESMTPSA id hc43-20020a17090716ab00b006c7622abe73sm1028285ejc.216.2022.03.03.11.00.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 11:00:19 -0800 (PST) Message-ID: <2d2e0ac0-0713-4dc8-9537-7fb04b71b029@gmail.com> Date: Thu, 3 Mar 2022 20:00:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 12/12] rockchip: fix boot_devices constants Content-Language: en-US From: Johan Jonker To: Simon Glass Cc: kever.yang@rock-chips.com, philipp.tomsich@vrull.eu, u-boot@lists.denx.de, w.egorov@phytec.de, hl@rock-chips.com, jagan@amarulasolutions.com, heiko@sntech.de References: <20220301014749.6446-1-jbx6244@gmail.com> <20220301014749.6446-12-jbx6244@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/3/22 15:37, Johan Jonker wrote: > Hi Simon, > > Thank you for your test report. > As I don't always have the hardware, could the board maintainers help me > identify u-boot specific property differences with Linux that need to be > moved to a dtsi file. > > Will send a new serie with fixes. > > Johan > > === > > After I sync rk3288.dtsi I get this warning. > fdt64_t is generated by a script and is not something that I can update > the regmap_init_mem_plat function for. > Any advice here? A possible solution with: config ROCKCHIP_RK3288 select PHYS_64BIT Adding PHYS_64BIT leads to other warning like this: drivers/video/rockchip/rk_vop.c: In function ‘rk_vop_probe’: drivers/video/rockchip/rk_vop.c:449:15: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] priv->regs = (struct rk3288_vop *)dev_read_addr(dev); Conclusion: a direct rk3288.dtsi sync from Linux with 64bit gives too much work to drivers or DT reg changes. Will look at a partial upgrade without reg size change. Johan > > ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- make chromebook_jerry_defconfig > > CC spl/drivers/ram/rockchip/sdram_rk3288.o > drivers/ram/rockchip/sdram_rk3288.c: In function ‘conv_of_plat’: > drivers/ram/rockchip/sdram_rk3288.c:1032:41: warning: passing argument 2 > of ‘regmap_init_mem_plat’ from incompatible pointer type > [-Wincompatible-pointer-types] > ret = regmap_init_mem_plat(dev, of_plat->reg, > ~~~~~~~^~~~~ > In file included from drivers/ram/rockchip/sdram_rk3288.c:18: > include/regmap.h:391:58: note: expected ‘fdt_val_t *’ {aka ‘unsigned int > *’} but argument is of type ‘fdt64_t *’ {aka ‘long long unsigned int *’} > int regmap_init_mem_plat(struct udevice *dev, fdt_val_t *reg, int count, > > > On 3/3/22 04:37, Simon Glass wrote: >> Hi Johan, >> >> On Mon, 28 Feb 2022 at 18:48, Johan Jonker wrote: >>> >>> The DT node name pattern in mmc-controller.yaml for mmc >>> is "^mmc(@.*)?$". The Rockchip mmc nodes have been synced >>> with Linux, so update the boot_devices constants as well. >>> >>> Signed-off-by: Johan Jonker >>> Reviewed-by: Simon Glass >>> --- >>> arch/arm/mach-rockchip/rk3188/rk3188.c | 4 ++-- >>> arch/arm/mach-rockchip/rk322x/rk322x.c | 4 ++-- >>> arch/arm/mach-rockchip/rk3288/rk3288.c | 4 ++-- >>> arch/arm/mach-rockchip/rk3328/rk3328.c | 4 ++-- >>> arch/arm/mach-rockchip/rk3368/rk3368.c | 4 ++-- >>> 5 files changed, 10 insertions(+), 10 deletions(-) >> > >> I tested this series on snow and it seems fine. >> >> I tried it on jerry and got: >> >> DRAM init failed: -19 > > noc: syscon@ffac0000 { > compatible = "rockchip,rk3288-noc", "syscon"; > reg = <0x0 0xffac0000 0x0 0x2000>; > > Forgot something. Does that help or is there more that needs to be fixed? > > ==> u-boot,dm-pre-reloc; > > }; > > TODO: Must change/update dmc/noc reg size when I sync rk3288.dtsi. > >> >> It also seemed fine on bob although my display is not coming up, for >> different reasons. > > In SPL or full U-boot? > > rk3288-veyron-chromebook.dtsi: > > aliases { > i2c20 = &i2c_tunnel; > video0 = &vopl; > video1 = &vopb; > }; > > Is this video alias something U-boot specific? > Fixing U-boot video is beyond my U-boot knowledge. > >> >> Regards >> >> Simon