From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F448C43334 for ; Mon, 18 Jul 2022 08:58:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233902AbiGRI6y (ORCPT ); Mon, 18 Jul 2022 04:58:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233822AbiGRI6r (ORCPT ); Mon, 18 Jul 2022 04:58:47 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E648F15FC2 for ; Mon, 18 Jul 2022 01:58:44 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id d16so16009083wrv.10 for ; Mon, 18 Jul 2022 01:58:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=isovalent-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=E5qdVtAhGRk9dSRPIpuKvbfIP1OxLhlEWe0abgwTtSA=; b=4nxDEs2aiLrsLpvWR3HrH4FNVSVRUnjBFLcpzM52zETeC5jvrDgxU61orz8kH6U0cQ tGoULePrb1J9FS+z0psoRnbYjXF0cHN1s6Q6/7ckh/Q3iuzXAzYo1zuLZhdyLBEK+DrN H3YNEFnn+YcumstvNVbVZA8bifj7W/DaUUE/MYo+HP72LvPf8Wv6VDUhkFRuDU5fDLOW 0LJKbHDOpUDREOY73BbHNmkqou8WMFsMZc/VQYPR6CrZ+RjHnrV97JDv+D46SO1+2Ayb 4dEZw++GWyOwx1T7yjNjLoPoMv3mq2YMFT9l+BVk+8aNW0gP2CXZD45Gk4tBY7s2za+e p2Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=E5qdVtAhGRk9dSRPIpuKvbfIP1OxLhlEWe0abgwTtSA=; b=T3+ULeJC3jr99SJ9/XDb+8nxdT4tK7XVHaQnC9n7YbQuOLNiQ/W7PDDwtGtAnWtNiS K0P1dqjQJ/Kw1EHYrwbYPg84S8TbQ1JJVf2C79M0iEOTRO+JBnKO/qiYSy6D9QJGU029 EDqBbpOhXYZTJQI2HBp2QMZEETCFlDEl1H2XFCG9AWt3h0f17Z/X8k51OErPbbwNK8gV kqQuJpje3oMcN7yS5l1Wes6oTRB9BuujeJYIgMRCYCS15YcLEjUJsEImArHnU+tMB0JE H9oNXuWU4WwZcIuozXDRujijZtm+H9wuSmeasPaX2HbRrSxP9aNChsmR9PAw3xlfRYFF Ti0g== X-Gm-Message-State: AJIora+bl8XlvCZvaCm3Vyqt87wUC7izc5CARLeD24RYNumGLWu997Ya C9tQTia6PjV69UVEg53RSnSCQA== X-Google-Smtp-Source: AGRyM1vc8DxxCp7n8iwjDgenX88lzvKjHTVcXeqNlOd7CHRhQwQPdM0ASkYMRKPA3NBNbLsmA6bhlw== X-Received: by 2002:a5d:414b:0:b0:21d:6e93:59c8 with SMTP id c11-20020a5d414b000000b0021d6e9359c8mr22359056wrq.290.1658134723332; Mon, 18 Jul 2022 01:58:43 -0700 (PDT) Received: from [192.168.178.32] ([51.155.200.13]) by smtp.gmail.com with ESMTPSA id a13-20020a05600c348d00b003a31d200a7dsm1750376wmq.9.2022.07.18.01.58.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jul 2022 01:58:42 -0700 (PDT) Message-ID: <2d2e60d9-f340-4c2d-e123-a858c46fae16@isovalent.com> Date: Mon, 18 Jul 2022 09:58:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH v2 2/5] tools include: add dis-asm-compat.h to handle version differences Content-Language: en-GB To: Andres Freund Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Alexei Starovoitov , Arnaldo Carvalho de Melo , Jiri Olsa , Sedat Dilek References: <20220622231624.t63bkmkzphqvh3kx@alap3.anarazel.de> <20220703212551.1114923-1-andres@anarazel.de> <20220703212551.1114923-3-andres@anarazel.de> <20220715193927.x6xy4h7n5rrh2ndc@awork3.anarazel.de> From: Quentin Monnet In-Reply-To: <20220715193927.x6xy4h7n5rrh2ndc@awork3.anarazel.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/07/2022 20:39, Andres Freund wrote: > Hi, > > On 2022-07-05 14:44:07 +0100, Quentin Monnet wrote: >>> diff --git a/tools/include/tools/dis-asm-compat.h b/tools/include/tools/dis-asm-compat.h >>> new file mode 100644 >>> index 000000000000..d1d003ee3e2f >>> --- /dev/null >>> +++ b/tools/include/tools/dis-asm-compat.h >>> @@ -0,0 +1,53 @@ >>> +/* SPDX-License-Identifier: GPL-2.0 */ >> >> Any chance you could contribute this wrapper as dual-licenced >> (GPL-2.0-only OR BSD-2-Clause), for better compatibility with the rest >> of bpftool's code? > > Happy to do that from my end - however, right now it includes > linux/compiler.h, which is GPL-2.0. I don't know what the policy around that > is - is it just a statement about the licence of the header itself, or does it > effectively include its dependencies? My understanding is that programs using a GPL header need to be released as GPL, but I don't believe they have to be only GPL, the dual-license should cover the requirements. If someone wanted to redistribute the code from the new header dis-asm-compat.h as BSD only, they would probably have to get rid of the GPL-only dependencies though. But again, this is only my understanding, and “I am not a lawyer”. > > FWIW, linux/compiler.h is also included from bpftool. > > If preferrable, I can replace the linux/compiler.h include by just using > __attribute__((__unused__)) directly or by using a (void) cast to avoid the > unused-parameter pedantry. If compiler.h is just needed for the “unused” attribute, I wouldn't mind doing that. Thanks, Quentin