From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE90AC433F5 for ; Fri, 4 Mar 2022 12:21:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D55D683689; Fri, 4 Mar 2022 13:21:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1646396492; bh=n6RKKW5M0cAjsJCzVcTpkNgQ1dbeYJX7nbT1pmiztdI=; h=Date:Subject:From:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=mO5rAUx+X2YPZ8TrRNPOY0fKDLX/jIekw65qtl1DkauQp8XJsPAh9uMmqn5IVQaP9 t8V7/EaXDBD47UaI+KHsU47KaF7EJh4tSt1agptbd89IxJ+x9EpxO2K6jBz3rVo2yC LuqYvCHQKtHfhm80RyJMk/H5mAIw/QyOX8ztg6lTbMeHZGZbWhNAxOEuucYYCqxXkT nEyEPoVx0BpZ1zR7QzbbnVCw1oIdlNzAY5bMdWIYeMnMEf/F6JPsMdb7zApUsvn7wP dqXukPErvTJelPyeK4f9UaNoPLqz7ZdEts6i6f9PLeBsEz93SvbLKhSwc5AXTiaGm5 8i1isPn2CHJKw== Received: by phobos.denx.de (Postfix, from userid 109) id CA2CB83C07; Fri, 4 Mar 2022 13:21:30 +0100 (CET) Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [IPv6:2001:67c:2050:1::465:204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B9EEA83678 for ; Fri, 4 Mar 2022 13:21:27 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp102.mailbox.org (unknown [91.198.250.119]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 4K96Qv2ZNFz9sS1; Fri, 4 Mar 2022 13:21:27 +0100 (CET) Message-ID: <2d3b8a2e-d668-5d1a-7b3f-b30b1c77f7b5@denx.de> Date: Fri, 4 Mar 2022 13:21:23 +0100 MIME-Version: 1.0 Subject: Re: [PATCH 1/2] pci: pci_mvebu: Remove unused SELECT and lane_mask Content-Language: en-US From: Stefan Roese To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , =?UTF-8?Q?Marek_Beh=c3=ban?= Cc: u-boot@lists.denx.de References: <20220218112523.10121-1-pali@kernel.org> <3fbed9c4-ad3f-aef8-90b8-7eb54a0f7968@denx.de> In-Reply-To: <3fbed9c4-ad3f-aef8-90b8-7eb54a0f7968@denx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 2/18/22 15:17, Stefan Roese wrote: > On 2/18/22 12:25, Pali Rohár wrote: >> Macro SELECT() is unused and struct mvebu_pcie field lane_mask is unused >> too. Remove them. >> >> Signed-off-by: Pali Rohár > > Reviewed-by: Stefan Roese Applied to u-boot-marvell/master Thanks, Stefan > Thanks, > Stefan > >> --- >>   drivers/pci/pci_mvebu.c | 3 --- >>   1 file changed, 3 deletions(-) >> >> diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c >> index 5a0a59a8b9ec..16fe54fd366f 100644 >> --- a/drivers/pci/pci_mvebu.c >> +++ b/drivers/pci/pci_mvebu.c >> @@ -30,8 +30,6 @@ >>   #include >>   /* PCIe unit register offsets */ >> -#define SELECT(x, n)            ((x >> n) & 1UL) >> - >>   #define PCIE_DEV_ID_OFF            0x0000 >>   #define PCIE_CMD_OFF            0x0004 >>   #define PCIE_DEV_REV_OFF        0x0008 >> @@ -77,7 +75,6 @@ struct mvebu_pcie { >>       u32 lane; >>       bool is_x4; >>       int devfn; >> -    u32 lane_mask; >>       int sec_busno; >>       char name[16]; >>       unsigned int mem_target; > > Viele Grüße, > Stefan Roese > Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de