All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@kernel.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: move gen5 SDR driver to DM
Date: Thu, 14 Feb 2019 09:37:13 -0600	[thread overview]
Message-ID: <2d4a246d-87fa-f38d-4e70-97aec2211897@kernel.org> (raw)
In-Reply-To: <e9ff5e31-034a-b9f1-a52d-34417c86ffaa@denx.de>

Hi Marek,

On 2/9/19 4:01 AM, Marek Vasut wrote:
> On 2/7/19 10:23 PM, Simon Goldschmidt wrote:
>> To clean up reset handling for socfpga gen5, let's move the code snippet
>> taking the DDR controller out of reset from SPL to the DDR driver.
>>
>> While at it, port the ddr driver to UCLASS_RAM and use dts.
>>
>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
>> ---
>>
>> This is an RFC to show what the SDRAM driver moved to DM (UCLASS_RAM) would
>> look like. It's RFC both because Dinh did not seem too fond of changing the
>> register address of the SDR in devicetree to include what the undocumented
>> registers 'sequencer.c' uses as well as because of my observed code growth.
> 
> Dinh, if the SDRAM controller spans some addresses, it should be
> described like so in the DT. Whether those registers are documented or
> not does not matter, DT is a hardware description and should describe
> hardware accurately.

Yes, I agree with above statement. I'll wait for this patch to land here
and will take the DTS patch to sync up Linux and U-Boot DTS.

Dinh

  parent reply	other threads:[~2019-02-14 15:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-07 21:23 [U-Boot] [PATCH] arm: socfpga: move gen5 SDR driver to DM Simon Goldschmidt
2019-02-08 20:28 ` Dalon L Westergreen
2019-02-08 20:36   ` Simon Goldschmidt
2019-02-08 22:51     ` Dalon L Westergreen
2019-02-09 10:02       ` Marek Vasut
2019-02-11 18:38         ` Dalon L Westergreen
2019-02-11 19:38           ` Simon Goldschmidt
2019-02-09 10:01 ` Marek Vasut
2019-02-09 10:38   ` Simon Goldschmidt
2019-02-13 21:10     ` Simon Goldschmidt
2019-02-14 15:37   ` Dinh Nguyen [this message]
2019-02-14 15:39     ` Simon Goldschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d4a246d-87fa-f38d-4e70-97aec2211897@kernel.org \
    --to=dinguyen@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.