From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH V3 2/5] ethdev: add new eth_dev_ops function
 for mtr ops get
Date: Thu, 12 Oct 2017 16:28:21 +0530
Message-ID: <2d538d82-406d-0a71-ff2d-83cf387b2256@nxp.com>
References: <1507208974-180500-2-git-send-email-cristian.dumitrescu@intel.com>
 <1507301136-131382-1-git-send-email-cristian.dumitrescu@intel.com>
 <1507301136-131382-3-git-send-email-cristian.dumitrescu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <thomas@monjalon.net>, <adrien.mazarguil@6wind.com>,
 <jingjing.wu@intel.com>, <jerin.jacob@caviumnetworks.com>,
 <jasvinder.singh@intel.com>
To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0047.outbound.protection.outlook.com [104.47.38.47])
 by dpdk.org (Postfix) with ESMTP id 29E281B217
 for <dev@dpdk.org>; Thu, 12 Oct 2017 12:58:28 +0200 (CEST)
In-Reply-To: <1507301136-131382-3-git-send-email-cristian.dumitrescu@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/6/2017 8:15 PM, Cristian Dumitrescu wrote:
> Following similar approach as rte_flow and rte_tm for modularity reasons,
> the ops for the new rte_mtr API are retrieved through a new eth_dev_ops
> function.
>
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> ---
> Changes in v3:
> - None
>
> Changes in v2:
> -None
>
> Changes in v1 (from RFC [1]):
> - Removed ethdev API function to get the MTR ops, as it is not needed
>   (input from Thomas)
>
> [1] RFC: http://www.dpdk.org/ml/archives/dev/2017-May/066888.html
>
>  lib/librte_ether/rte_ethdev.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
> index 99cdd54..a5802b0 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -1424,6 +1424,9 @@ typedef int (*eth_filter_ctrl_t)(struct rte_eth_dev *dev,
>  typedef int (*eth_tm_ops_get_t)(struct rte_eth_dev *dev, void *ops);
>  /**< @internal Get Traffic Management (TM) operations on an Ethernet device */
>
> +typedef int (*eth_mtr_ops_get_t)(struct rte_eth_dev *dev, void *ops);
> +/**< @internal Get Trafffic Metering and Policing (MTR) operations */
> +
>  typedef int (*eth_get_dcb_info)(struct rte_eth_dev *dev,
>  				 struct rte_eth_dcb_info *dcb_info);
>  /**< @internal Get dcb information on an Ethernet device */
> @@ -1548,6 +1551,9 @@ struct eth_dev_ops {
>
>  	eth_tm_ops_get_t tm_ops_get;
>  	/**< Get Traffic Management (TM) operations. */
> +
> +	eth_mtr_ops_get_t mtr_ops_get;
> +	/**< Get Traffic Metering and Policing (MTR) operations. */
>  };
>
>  /**
>
Reviewed-by:  Hemant Agrawal <hemant.agrawal@nxp.com>