From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3555FC47255 for ; Mon, 11 May 2020 17:26:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10172206D7 for ; Mon, 11 May 2020 17:26:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730826AbgEKR0J (ORCPT ); Mon, 11 May 2020 13:26:09 -0400 Received: from foss.arm.com ([217.140.110.172]:36646 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729698AbgEKR0J (ORCPT ); Mon, 11 May 2020 13:26:09 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 658B930E; Mon, 11 May 2020 10:26:08 -0700 (PDT) Received: from [10.37.12.116] (unknown [10.37.12.116]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2C3493F305; Mon, 11 May 2020 10:26:00 -0700 (PDT) Subject: Re: [PATCH] coresight: platform: use dev_warn instead of dev_warn_once To: mathieu.poirier@linaro.org, kathirav@codeaurora.org Cc: mike.leach@linaro.org, alexander.shishkin@linux.intel.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1588933721-18700-1-git-send-email-kathirav@codeaurora.org> <20200511165851.GB13202@xps15> From: Suzuki K Poulose Message-ID: <2d59194a-2785-8762-81cd-bef34c6a51ec@arm.com> Date: Mon, 11 May 2020 18:31:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20200511165851.GB13202@xps15> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/11/2020 05:58 PM, Mathieu Poirier wrote: > Hi Kathiravan, > > On Fri, May 08, 2020 at 03:58:41PM +0530, Kathiravan T wrote: >> When more than one coresight components uses the obsolete DT bindings, >> warning is displayed for only one component and not for the others. >> Lets warn it for all components by replacing dev_warn_once with dev_warn. >> >> Signed-off-by: Kathiravan T >> --- >> drivers/hwtracing/coresight/coresight-platform.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c >> index 43418a2..b7d9a02 100644 >> --- a/drivers/hwtracing/coresight/coresight-platform.c >> +++ b/drivers/hwtracing/coresight/coresight-platform.c >> @@ -284,7 +284,7 @@ static int of_get_coresight_platform_data(struct device *dev, >> if (!parent) { >> legacy_binding = true; >> parent = node; >> - dev_warn_once(dev, "Uses obsolete Coresight DT bindings\n"); >> + dev_warn(dev, "Uses obsolete Coresight DT bindings\n"); > > We made a concious decision to use dev_warn_once() rather than dev_warn(). > There can be a lot of coresight devices on a platform and warning for every > device doesn't do anything more than adding noise. > > If one device is using obsolete bindings the others very likely to do so as > well. While fixing one device, checking the remaining devices should be > intuitive. Exactly ! Or someone could repeat the process until all are fixed ;-) Cheers Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 330F1C54E8D for ; Mon, 11 May 2020 17:26:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1C55206D7 for ; Mon, 11 May 2020 17:26:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WL7pLxHb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1C55206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kEbpZWz7pfnEGNOb/QexlOC5C3ybV4u/omaIUu2HVRI=; b=WL7pLxHbjKTggXmPNS9/0kEmN vstevKAG9BrrcYpck9CwZ7Wd5qk3YwDVqZlj485GMxUP+rO0CtThW6DHCPcCO9OWX6AK4uYgJYSwr oddh7LYjoQC1zfXBalJCku74dVX1vkI5A1/a1mWRZEZHufZs7ORnGLHVKs6azyrnAD6FVqgOXmvnO YkPfOBBc817PBFrlzvpWmE2xMAc+3mHWCm/vYv+atjEcnlBrlerBxHMUbpQh0WP4yKahnc1r+f0lU 5Ja7NuLqkPuHCZtnDgTunWGQ6ElaQfuT7Eo87FgSPa3B4UnG6cPc/2h2EqasRMU2uMS64fZX26JIE wAqEHZlqw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYCBx-0002w9-HL; Mon, 11 May 2020 17:26:13 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jYCBu-0002vI-0R for linux-arm-kernel@lists.infradead.org; Mon, 11 May 2020 17:26:11 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 658B930E; Mon, 11 May 2020 10:26:08 -0700 (PDT) Received: from [10.37.12.116] (unknown [10.37.12.116]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2C3493F305; Mon, 11 May 2020 10:26:00 -0700 (PDT) Subject: Re: [PATCH] coresight: platform: use dev_warn instead of dev_warn_once To: mathieu.poirier@linaro.org, kathirav@codeaurora.org References: <1588933721-18700-1-git-send-email-kathirav@codeaurora.org> <20200511165851.GB13202@xps15> From: Suzuki K Poulose Message-ID: <2d59194a-2785-8762-81cd-bef34c6a51ec@arm.com> Date: Mon, 11 May 2020 18:31:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20200511165851.GB13202@xps15> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200511_102610_093198_8A4AC062 X-CRM114-Status: GOOD ( 19.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/11/2020 05:58 PM, Mathieu Poirier wrote: > Hi Kathiravan, > > On Fri, May 08, 2020 at 03:58:41PM +0530, Kathiravan T wrote: >> When more than one coresight components uses the obsolete DT bindings, >> warning is displayed for only one component and not for the others. >> Lets warn it for all components by replacing dev_warn_once with dev_warn. >> >> Signed-off-by: Kathiravan T >> --- >> drivers/hwtracing/coresight/coresight-platform.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/hwtracing/coresight/coresight-platform.c b/drivers/hwtracing/coresight/coresight-platform.c >> index 43418a2..b7d9a02 100644 >> --- a/drivers/hwtracing/coresight/coresight-platform.c >> +++ b/drivers/hwtracing/coresight/coresight-platform.c >> @@ -284,7 +284,7 @@ static int of_get_coresight_platform_data(struct device *dev, >> if (!parent) { >> legacy_binding = true; >> parent = node; >> - dev_warn_once(dev, "Uses obsolete Coresight DT bindings\n"); >> + dev_warn(dev, "Uses obsolete Coresight DT bindings\n"); > > We made a concious decision to use dev_warn_once() rather than dev_warn(). > There can be a lot of coresight devices on a platform and warning for every > device doesn't do anything more than adding noise. > > If one device is using obsolete bindings the others very likely to do so as > well. While fixing one device, checking the remaining devices should be > intuitive. Exactly ! Or someone could repeat the process until all are fixed ;-) Cheers Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel