From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 647CFC43331 for ; Fri, 6 Sep 2019 10:48:35 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 398832082C for ; Fri, 6 Sep 2019 10:48:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 398832082C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:54484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i6Bn8-0000eV-Dz for qemu-devel@archiver.kernel.org; Fri, 06 Sep 2019 06:48:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54520) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i6BmI-0008QS-1e for qemu-devel@nongnu.org; Fri, 06 Sep 2019 06:47:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i6BmG-0001ov-SS for qemu-devel@nongnu.org; Fri, 06 Sep 2019 06:47:41 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:58807) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i6BmG-0001oa-Aw for qemu-devel@nongnu.org; Fri, 06 Sep 2019 06:47:40 -0400 Received: from [192.168.100.1] ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue108 [213.165.67.119]) with ESMTPSA (Nemesis) id 1MnpwC-1iTuvR0AVG-00pL1y; Fri, 06 Sep 2019 12:47:23 +0200 To: Aleksandar Markovic , qemu-devel@nongnu.org References: <1567601968-26946-1-git-send-email-aleksandar.markovic@rt-rk.com> <1567601968-26946-9-git-send-email-aleksandar.markovic@rt-rk.com> From: Laurent Vivier Openpgp: preference=signencrypt Autocrypt: addr=laurent@vivier.eu; prefer-encrypt=mutual; keydata= mQINBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABtCJMYXVyZW50IFZp dmllciA8bGF1cmVudEB2aXZpZXIuZXU+iQI4BBMBAgAiBQJWBTDeAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAAKCRDzDDi9Py++PCEdD/oD8LD5UWxhQrMQCsUgLlXCSM7sxGLkwmmF ozqSSljEGRhffxZvO35wMFcdX9Z0QOabVoFTKrT04YmvbjsErh/dP5zeM/4EhUByeOS7s6Yl HubMXVQTkak9Wa9Eq6irYC6L41QNzz/oTwNEqL1weV1+XC3TNnht9B76lIaELyrJvRfgsp9M rE+PzGPo5h7QHWdL/Cmu8yOtPLa8Y6l/ywEJ040IoiAUfzRoaJs2csMXf0eU6gVBhCJ4bs91 jtWTXhkzdl4tdV+NOwj3j0ukPy+RjqeL2Ej+bomnPTOW8nAZ32dapmu7Fj7VApuQO/BSIHyO NkowMMjB46yohEepJaJZkcgseaus0x960c4ua/SUm/Nm6vioRsxyUmWd2nG0m089pp8LPopq WfAk1l4GciiMepp1Cxn7cnn1kmG6fhzedXZ/8FzsKjvx/aVeZwoEmucA42uGJ3Vk9TiVdZes lqMITkHqDIpHjC79xzlWkXOsDbA2UY/P18AtgJEZQPXbcrRBtdSifCuXdDfHvI+3exIdTpvj BfbgZAar8x+lcsQBugvktlQWPfAXZu4Shobi3/mDYMEDOE92dnNRD2ChNXg2IuvAL4OW40wh gXlkHC1ZgToNGoYVvGcZFug1NI+vCeCFchX+L3bXyLMg3rAfWMFPAZLzn42plIDMsBs+x2yP +bkCDQRWBSYZARAAvFJBFuX9A6eayxUPFaEczlMbGXugs0mazbOYGlyaWsiyfyc3PStHLFPj rSTaeJpPCjBJErwpZUN4BbpkBpaJiMuVO6egrC8Xy8/cnJakHPR2JPEvmj7Gm/L9DphTcE15 92rxXLesWzGBbuYxKsj8LEnrrvLyi3kNW6B5LY3Id+ZmU8YTQ2zLuGV5tLiWKKxc6s3eMXNq wrJTCzdVd6ThXrmUfAHbcFXOycUyf9vD+s+WKpcZzCXwKgm7x1LKsJx3UhuzT8ier1L363RW ZaJBZ9CTPiu8R5NCSn9V+BnrP3wlFbtLqXp6imGhazT9nJF86b5BVKpF8Vl3F0/Y+UZ4gUwL d9cmDKBcmQU/JaRUSWvvolNu1IewZZu3rFSVgcpdaj7F/1aC0t5vLdx9KQRyEAKvEOtCmP4m 38kU/6r33t3JuTJnkigda4+Sfu5kYGsogeYG6dNyjX5wpK5GJIJikEhdkwcLM+BUOOTi+I9u tX03BGSZo7FW/J7S9y0l5a8nooDs2gBRGmUgYKqQJHCDQyYut+hmcr+BGpUn9/pp2FTWijrP inb/Pc96YDQLQA1q2AeAFv3Rx3XoBTGl0RCY4KZ02c0kX/dm3eKfMX40XMegzlXCrqtzUk+N 8LeipEsnOoAQcEONAWWo1HcgUIgCjhJhBEF0AcELOQzitbJGG5UAEQEAAYkCHwQYAQIACQUC VgUmGQIbDAAKCRDzDDi9Py++PCD3D/9VCtydWDdOyMTJvEMRQGbx0GacqpydMEWbE3kUW0ha US5jz5gyJZHKR3wuf1En/3z+CEAEfP1M3xNGjZvpaKZXrgWaVWfXtGLoWAVTfE231NMQKGoB w2Dzx5ivIqxikXB6AanBSVpRpoaHWb06tPNxDL6SVV9lZpUn03DSR6gZEZvyPheNWkvz7bE6 FcqszV/PNvwm0C5Ju7NlJA8PBAQjkIorGnvN/vonbVh5GsRbhYPOc/JVwNNr63P76rZL8Gk/ hb3xtcIEi5CCzab45+URG/lzc6OV2nTj9Lg0SNcRhFZ2ILE3txrmI+aXmAu26+EkxLLfqCVT ohb2SffQha5KgGlOSBXustQSGH0yzzZVZb+HZPEvx6d/HjQ+t9sO1bCpEgPdZjyMuuMp9N1H ctbwGdQM2Qb5zgXO+8ZSzwC+6rHHIdtcB8PH2j+Nd88dVGYlWFKZ36ELeZxD7iJflsE8E8yg OpKgu3nD0ahBDqANU/ZmNNarBJEwvM2vfusmNnWm3QMIwxNuJghRyuFfx694Im1js0ZY3LEU JGSHFG4ZynA+ZFUPA6Xf0wHeJOxGKCGIyeKORsteIqgnkINW9fnKJw2pgk8qHkwVc3Vu+wGS ZiJK0xFusPQehjWTHn9WjMG1zvQ5TQQHxau/2FkP45+nRPco6vVFQe8JmgtRF8WFJA== Message-ID: <2d5e7f28-7fa4-7637-c512-b443848eb61b@vivier.eu> Date: Fri, 6 Sep 2019 12:47:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1567601968-26946-9-git-send-email-aleksandar.markovic@rt-rk.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:bvFL22rJ9PEGrVAlS7Oe0n/7Th8HizUT3ypvA02rgPvYoqUH5wD fsC4LW5SMp+yOxm/D8DgByzBpF0C4vRMgVKx9VVEajx3Fg8AzvCZcT1/ojkyae7lboIAvgE wYXir3nPedMdDt4pzBAV908XUJ2r8Ti41gSmpL0jrb9n/vH+SjXl1LleKlr59FwUWNmSIES ijfrE1bGTpiAuR2v9ys6A== X-UI-Out-Filterresults: notjunk:1;V03:K0:NjOIRu2kjdQ=:QgfAowwP0uRG3H8QCu41hq 9c0I+BT2hZas8bDtLbhGBI0yVKIymRkUrYg2z7jeU7en6Hs4f1FhbA4F4hDzHLoBvigt7jZT7 hrG7E4DIrhwLbkvJ4RCAdK2kwPUORJZtASZR5CiEos/IRpUg8LAttLBcHAcUKV0UUG2fSpQP0 JyEFh6YYMLXhVX2iEcw/MCILyIKyse7Wcm7J0+EIGzGHJP30iOd2w9YFnpazCglT3VB/ndEyj jKZY5fRh6qmvlnimrQX9Cu3LeN8kf+aHsS9bYIoTMeweTnvGiK78YdREbPPuutkqg1USAXIZ4 JviF6E6w9siYBo25kw+tiJ6bsMlhu7i6loJiHbmhidgt/lk6LiNGjJ/+NryUC6TYlJMGunehD 7evneXc5FQM7/ZD4Wv95HiCGxRNKCWPo72N35HsXT9UBfT585Gj+M585/zN8YJ8YwgR14+BMt CT2vIds/ncXd4Mcs/jLediZNZVqnRT70zOcGpe9mfKQIUYzfb82652r4WIARrm0vqZ2DAheci Wt3IyZeEUXKnQMyc9LU28uHxF/YFw/Eh0jf0qYwpGwPFT4mqGVNsNueewfw9DaLHH34z1nmv5 wHQpSH9ZwuH8APZo2awwAdiahOO0w+6PpYcZyoZKkFKIzTLXaf5Z1LSZ7zwbWm1viga6L56A4 3qonBVC5+hQf8zyybI4pP0V7gr+d9MS4oXFSrIxo9/WAUDK3i9/lDqPapLw9EP9Ep+agcMiBT 0pql56Ce0KPVSNnUIaDf+EhtyLSW1HBA47P8E+MDaAUscxu0H9pABYGBMvZdFtJUSk3LOttKc PXKxaK0N3ZfERZtBZ5A9r3tddWCTFumovx6NmlO58sZzNXxvcQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.10 Subject: Re: [Qemu-devel] [PATCH v6 8/8] linux-user: Add support for FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: riku.voipio@iki.fi, amarkovic@wavecomp.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 04/09/2019 à 14:59, Aleksandar Markovic a écrit : > From: Aleksandar Markovic > > FDSETEMSGTRESH, FDSETMAXERRS, and FDGETMAXERRS ioctls are commands > for controlling error reporting of a floppy drive. > > Signed-off-by: Aleksandar Markovic > --- > linux-user/ioctls.h | 2 ++ > linux-user/syscall_defs.h | 19 +++++++++++++++++++ > linux-user/syscall_types.h | 7 +++++++ > 3 files changed, 28 insertions(+) > > diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h > index 622874b..0c75d03 100644 > --- a/linux-user/ioctls.h > +++ b/linux-user/ioctls.h > @@ -118,6 +118,8 @@ > IOCTL(FDFMTTRK, IOC_W, MK_PTR(MK_STRUCT(STRUCT_format_descr))) > IOCTL(FDFMTEND, 0, TYPE_NULL) > IOCTL(FDFLUSH, 0, TYPE_NULL) > + IOCTL(FDSETMAXERRS, IOC_W, MK_PTR(MK_STRUCT(STRUCT_floppy_max_errors))) > + IOCTL(FDGETMAXERRS, IOC_R, MK_PTR(MK_STRUCT(STRUCT_floppy_max_errors))) where is FDSETEMSGTRESH? > IOCTL(FDRESET, 0, TYPE_NULL) > IOCTL(FDRAWCMD, 0, TYPE_NULL) > IOCTL(FDTWADDLE, 0, TYPE_NULL) > diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h > index 834a085..7c5b614 100644 > --- a/linux-user/syscall_defs.h > +++ b/linux-user/syscall_defs.h > @@ -890,12 +890,31 @@ struct target_pollfd { > > /* From */ > > +struct target_floppy_max_errors { > + abi_uint abort; > + abi_uint read_track; > + abi_uint reset; > + abi_uint recal; > + abi_uint reporting; > +}; You don't need this, you can use floppy_max_errors from . But you can define it if you want because it is used to know the size of the target structure (and if alignment or data types differ it can mismatch. With "int" it's not the case). > +struct target_format_descr { > + abi_uint device; > + abi_uint head; > + abi_uint track; > +}; > + This one is for the previous patch. Same comment as above. Thanks, Laurent