From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D42BC4332F for ; Wed, 11 May 2022 17:55:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239578AbiEKRzH (ORCPT ); Wed, 11 May 2022 13:55:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234595AbiEKRzG (ORCPT ); Wed, 11 May 2022 13:55:06 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1C2821A953 for ; Wed, 11 May 2022 10:55:02 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id k27so3478570edk.4 for ; Wed, 11 May 2022 10:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=vRxXDx59BwVAdE/yeHzMrpA2E8oV/k7BSRSKcJYdNfA=; b=j0bCP9Ac9nsbSjZPAcD6tdqqrZV4sDP3RbsQMgYi2x5TCCiRzj83bEfxfyxjpposIi fXlRRRYWSmtJrhuCCbQTE8MTt2iT63WqGTsfMYSiRzrOcvRnRstfaMJuyuI7qhwZFzCQ IQSgpSI6eD/1J1MZTTlrLce8q7RLHtNE0FaYZ5n7rAF6EmLhc53FInghMRjL5oujH9Tk y9a67Ng8mpZ4/DrSbm3cdv16kis8MutYiRMCgNtajxWIGOxIzXSQWK2PqhH8IipabXgs k1sYGaINvDPdY68wqd79jP1OY9Tnu9eRJD/0Hv+P8Jfi32tbvvPlLXVUHavjm2Zv38f+ 5zGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=vRxXDx59BwVAdE/yeHzMrpA2E8oV/k7BSRSKcJYdNfA=; b=ha+uS6d7HHs8OlRsaf6CM3C1LXzaemHT6VKuJc0s5m9VFTMfg6CoVeDrdoDkLDiGLw 8OQEtp4tz1uNLdiO8iHMsb5fIWWgx+WgYi8rCj+UCOB9tFPLqAhSwt0YI16LJnAFHAnk M9Q4cCYeM0fLpruW1e/KodtFDhcp+KU+UeD1+tenzsIUfTRnMFdg/gOJ7ztCik+A1z0/ lyaxmvwWNadCB09AeVq+UTgFSSXm6nPeeA+dY7Uvc5syX5taCYRxPFUi9Lwgp67WNell dSQC6+mn0oI0xiyf7+k3wxrdfnLWQXSCzyazRZ6a0HuCbr8NArA6u4gYAA9ynyIrJOjb PqMQ== X-Gm-Message-State: AOAM530XxHfKN6IUrcRlMGN5Jnak+v5q2DHTc19+l4O1dfW2FCZaNE1k 33zPs6ESpg9vSX2wXn8ky9yKPuz+xAfFU51z X-Google-Smtp-Source: ABdhPJxhoebCeo/8aCGNu+Eiiq15xXHJ5M3E/dBl0X+mb8fVJ9xZI1u4poNv7tbPbiIiBRgXjNfWmA== X-Received: by 2002:a05:6402:50d1:b0:42a:2e52:c286 with SMTP id h17-20020a05640250d100b0042a2e52c286mr1328969edb.390.1652291701427; Wed, 11 May 2022 10:55:01 -0700 (PDT) Received: from [192.168.0.155] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id q21-20020aa7d455000000b0042617ba63d3sm1448654edr.93.2022.05.11.10.55.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 May 2022 10:55:01 -0700 (PDT) Message-ID: <2d68e610-e8ae-9e08-257a-3c94c3697334@linaro.org> Date: Wed, 11 May 2022 19:55:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 9/9] arm64: dts: qcom: msm8953: Add remote processor nodes Content-Language: en-US To: Sireesh Kodali , linux-remoteproc@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, bjorn.andersson@linaro.org, devicetree@vger.kernel.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Gross , Rob Herring , Krzysztof Kozlowski References: <20220511161602.117772-1-sireeshkodali1@gmail.com> <20220511161602.117772-10-sireeshkodali1@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220511161602.117772-10-sireeshkodali1@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 11/05/2022 18:16, Sireesh Kodali wrote: > This commit adds the modem (q6v5_mss), WiFi (wcnss-pil) and audio DSP > (q6v5_pas) remote processor nodes for the MSM8953 platform. It also adds > the coresponding SMP2P, SMSM and pinctrl nodes that are needed by these > remote processors. > > Signed-off-by: Sireesh Kodali > + }; > + > + wcnss_sleep: wcnss-sleep-pins { > + wcss_wlan2 { No underscores in node names, unless something needs it? > + pins = "gpio76"; > + function = "wcss_wlan2"; > + }; > + wcss_wlan1 { > + pins = "gpio77"; > + function = "wcss_wlan1"; > + }; > + wcss_wlan0 { > + pins = "gpio78"; > + function = "wcss_wlan0"; > + }; > + wcss_wlan { > + pins = "gpio79", "gpio80"; > + function = "wcss_wlan"; > + }; > + > + pinconf { > + pins = "gpio76", "gpio77", > + "gpio78", "gpio79", > + "gpio80"; > + drive-strength = <2>; > + bias-pull-down; > + }; > + }; > }; > > gcc: clock-controller@1800000 { > @@ -745,6 +892,59 @@ spmi_bus: spmi@200f000 { > #size-cells = <0>; > }; > > + modem: remoteproc@4080000 { > + compatible = "qcom,msm8953-mss-pil"; > + reg = <0x4080000 0x100>, > + <0x4020000 0x040>; > + > + reg-names = "qdsp6", "rmb"; > + > + interrupts-extended = <&intc 0 24 1>, > + <&modem_smp2p_in 0 0>, > + <&modem_smp2p_in 1 0>, > + <&modem_smp2p_in 2 0>, > + <&modem_smp2p_in 3 0>; > + interrupt-names = "wdog", "fatal", "ready", > + "handover", "stop-ack"; > + > + clocks = <&gcc GCC_MSS_CFG_AHB_CLK>, > + <&gcc GCC_MSS_Q6_BIMC_AXI_CLK>, > + <&gcc GCC_BOOT_ROM_AHB_CLK>, > + <&xo_board>; > + clock-names = "iface", "bus", "mem", "xo"; > + > + power-domains = <&rpmpd MSM8953_VDDCX>, <&rpmpd MSM8953_VDDMX>; > + power-domain-names = "cx", "mx"; > + > + qcom,smem-states = <&modem_smp2p_out 0>; > + qcom,smem-state-names = "stop"; > + > + resets = <&gcc GCC_MSS_BCR>; > + reset-names = "mss_restart"; > + > + qcom,halt-regs = <&tcsr 0x18000 0x19000 0x1a000>; > + > + status = "okay"; No need for okay. > + > + mba { > + memory-region = <&mba_mem>; > + }; > + > + mpss { > + memory-region = <&mpss_mem>; > + }; > + > + smd-edge { > + interrupts = ; > + > + qcom,smd-edge = <0>; > + qcom,ipc = <&apcs 8 12>; > + qcom,remote-pid = <1>; > + > + label = "modem"; > + }; > + }; > + > usb3: usb@70f8800 { > compatible = "qcom,msm8953-dwc3", "qcom,dwc3"; > reg = <0x70f8800 0x400>; > @@ -1057,6 +1257,74 @@ i2c_8: i2c@7af8000 { > status = "disabled"; > }; > > + pronto: remoteproc@a21b000 { > + compatible = "qcom,pronto-v3-pil", "qcom,pronto"; > + reg = <0xa204000 0x2000>, > + <0xa202000 0x1000>, > + <0xa21b000 0x3000>; > + reg-names = "ccu", "dxe", "pmu"; > + > + memory-region = <&wcnss_fw_mem>; > + > + interrupts-extended = <&intc 0 149 IRQ_TYPE_EDGE_RISING>, > + <&wcnss_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, > + <&wcnss_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, > + <&wcnss_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, > + <&wcnss_smp2p_in 3 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "wdog", "fatal", "ready", "handover", "stop-ack"; > + > + power-domains = <&rpmpd MSM8953_VDDCX>, <&rpmpd MSM8953_VDDMX>; > + power-domain-names = "cx", "mx"; > + > + qcom,state = <&wcnss_smp2p_out 0>; > + qcom,state-names = "stop"; > + > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&wcnss_default>; > + pinctrl-1 = <&wcnss_sleep>; > + > + status = "okay"; No need for status. > + > + iris: iris { > + compatible = "qcom,wcn3660b"; > + > + clocks = <&rpmcc RPM_SMD_RF_CLK2>; > + clock-names = "xo"; > + }; > + > + smd-edge { > + interrupts = ; > + > + qcom,ipc = <&apcs 8 17>; > + qcom,smd-edge = <6>; > + qcom,remote-pid = <4>; > + > + label = "pronto"; > + > + wcnss { > + compatible = "qcom,wcnss"; > + qcom,smd-channels = "WCNSS_CTRL"; > + > + qcom,mmio = <&pronto>; > + > + bt { > + compatible = "qcom,wcnss-bt"; > + }; > + > + wifi { > + compatible = "qcom,wcnss-wlan"; > + > + interrupts = , > + ; > + interrupt-names = "tx", "rx"; > + > + qcom,smem-states = <&apps_smsm 10>, <&apps_smsm 9>; > + qcom,smem-state-names = "tx-enable", "tx-rings-empty"; > + }; > + }; > + }; > + }; > + > intc: interrupt-controller@b000000 { > compatible = "qcom,msm-qgic2"; > interrupt-controller; > @@ -1070,6 +1338,116 @@ apcs: mailbox@b011000 { > #mbox-cells = <1>; > }; > > + lpass: remoteproc@c200000 { > + compatible = "qcom,msm8953-adsp-pil"; > + reg = <0xc200000 0x100>; > + > + interrupts-extended = <&intc 0 293 IRQ_TYPE_EDGE_RISING>, > + <&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>, > + <&smp2p_adsp_in 1 IRQ_TYPE_EDGE_RISING>, > + <&smp2p_adsp_in 2 IRQ_TYPE_EDGE_RISING>, > + <&smp2p_adsp_in 3 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "wdog", "fatal", "ready", > + "handover", "stop-ack"; > + clocks = <&xo_board>; > + clock-names = "xo"; > + > + power-domains = <&rpmpd MSM8953_VDDCX>; > + power-domain-names = "cx"; > + > + memory-region = <&adsp_fw_mem>; > + > + qcom,smem-states = <&smp2p_adsp_out 0>; > + qcom,smem-state-names = "stop"; > + > + smd-edge { > + interrupts = ; > + > + label = "lpass"; > + mboxes = <&apcs 8>; > + qcom,smd-edge = <1>; > + qcom,remote-pid = <2>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + apr { > + compatible = "qcom,apr-v2"; > + qcom,smd-channels = "apr_audio_svc"; > + qcom,apr-domain = ; > + #address-cells = <1>; > + #size-cells = <0>; > + > + q6core { > + reg = ; > + compatible = "qcom,q6core"; > + }; > + > + q6afe: q6afe { > + compatible = "qcom,q6afe"; > + reg = ; > + q6afedai: dais { > + compatible = "qcom,q6afe-dais"; > + #address-cells = <1>; > + #size-cells = <0>; > + #sound-dai-cells = <1>; > + > + dai@16 { > + reg = ; > + qcom,sd-lines = <0 1>; > + }; > + > + dai@21 { > + reg = ; > + qcom,sd-lines = <0 1>; > + }; > + }; > + q6afecc: clock-controller { > + compatible = "qcom,q6afe-clocks"; > + #clock-cells = <2>; > + }; > + }; > + > + q6asm: q6asm { > + compatible = "qcom,q6asm"; > + reg = ; > + q6asmdai: dais { > + compatible = "qcom,q6asm-dais"; > + #address-cells = <1>; > + #size-cells = <0>; > + #sound-dai-cells = <1>; > + > + dai@0 { > + reg = ; > + }; > + > + dai@1 { > + reg = ; > + }; > + > + dai@2 { > + reg = ; > + }; > + > + dai@3 { > + reg = ; > + is-compress-dai; > + }; > + }; > + }; > + > + q6adm: q6adm { > + compatible = "qcom,q6adm"; > + reg = ; > + q6routing: routing { > + compatible = "qcom,q6adm-routing"; > + #sound-dai-cells = <0>; > + }; > + }; > + }; > + }; > + Remove unneeded blank lines. > + }; > + > timer@b120000 { > compatible = "arm,armv7-timer-mem"; > reg = <0xb120000 0x1000>; Best regards, Krzysztof