From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [iproute PATCH] ssfilter: Fix for inverted last expression Date: Fri, 30 Nov 2018 10:22:59 -0800 Message-ID: <2d859754-f62b-302e-e681-6f7f493ee2e8@gmail.com> References: <20181129122037.10569-1-phil@nwl.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, Eric Dumazet , David Ahern , Eric Dumazet To: Phil Sutter , Stephen Hemminger Return-path: Received: from mail-pf1-f194.google.com ([209.85.210.194]:44859 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725754AbeLAFdP (ORCPT ); Sat, 1 Dec 2018 00:33:15 -0500 Received: by mail-pf1-f194.google.com with SMTP id u6so3191889pfh.11 for ; Fri, 30 Nov 2018 10:23:07 -0800 (PST) In-Reply-To: <20181129122037.10569-1-phil@nwl.cc> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/29/2018 04:20 AM, Phil Sutter wrote: > When fixing for shift/reduce conflicts, possibility to invert the last > expression by prefixing with '!' or 'not' was accidentally removed. > > Fix this by allowing for expr to be an inverted expr so that any > reference to it in exprlist accepts the inverted prefix. > > Reported-by: Eric Dumazet > Fixes: b2038cc0b2403 ("ssfilter: Eliminate shift/reduce conflicts") > Signed-off-by: Phil Sutter > --- Thanks Phil ! Acked-by: Eric Dumazet