From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sinan Kaya <okaya@codeaurora.org>
Subject: Re: [PATCH] ethdev: support PCI domains
Date: Tue, 4 Oct 2016 09:59:58 -0400
Message-ID: <2d9df664-7b51-a0d5-4073-5bb386e8433c@codeaurora.org>
References: <1469201650-32447-1-git-send-email-okaya@codeaurora.org>
 <20160722141259.35ea0a7e@xeon-e3>
 <e3fc647d-32fe-6fb8-b957-dfc8b55c4c95@codeaurora.org>
 <3354300.QnNDgIpU56@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96])
 by dpdk.org (Postfix) with ESMTP id 28F5D2BA6
 for <dev@dpdk.org>; Tue,  4 Oct 2016 16:00:01 +0200 (CEST)
In-Reply-To: <3354300.QnNDgIpU56@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/4/2016 4:15 AM, Thomas Monjalon wrote:
> 2016-07-22 18:56, Sinan Kaya:
>> On 7/22/2016 5:12 PM, Stephen Hemminger wrote:
>>> On Fri, 22 Jul 2016 11:34:10 -0400
>>> Sinan Kaya <okaya@codeaurora.org> wrote:
>>>
>>>> The current code is enumerating devices based on bus, device and function
>>>> pairs. This does not work well for architectures with multiple PCI
>>>> segments/domains. Multiple PCI devices will have the same BDF value but
>>>> different segment numbers (01:01:01.0 and 02:01:01.0) for instance.
>>>>
>>>> Adding segment numbers to device naming so that we can uniquely identify
>>>> devices.
>>>>
>>>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
>>>
>>> I ran into this yes. There is a small risk of breaking some application that
>>> assumed something about names though.
>>>
>>> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>>>
>>
>> Thanks, hopefully the change is minor and can be contained until next release.
> 
> It is part of the EAL rework.
> The function has been moved in EAL and includes the PCI domain:
> 	http://dpdk.org/commit/affe1cdc
> 

Thanks for taking care of it.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.