From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6996C10F13 for ; Tue, 16 Apr 2019 14:33:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 97A9C205F4 for ; Tue, 16 Apr 2019 14:33:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=cumulusnetworks.com header.i=@cumulusnetworks.com header.b="BSOWJPW5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729552AbfDPOdv (ORCPT ); Tue, 16 Apr 2019 10:33:51 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:34426 "EHLO mail-wr1-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726605AbfDPOdv (ORCPT ); Tue, 16 Apr 2019 10:33:51 -0400 Received: by mail-wr1-f41.google.com with SMTP id p10so27435552wrq.1 for ; Tue, 16 Apr 2019 07:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cumulusnetworks.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Ni2H4isCo0SlaQAXQAOQIyyFLNE2DUNHsfTL8j5gkmY=; b=BSOWJPW54X7U2heOSWQi0/Bro5N8XW1xKPfpsf8f5vWBZuuO2bmXdNZy9W0qJJlhY0 ueK97l/vMdfDNxf+V1VmB9G312345NrRq4Aln8t/tZnmsIGeh+dkGEbRY63zsnd3n9kw 2AnMxd6BbR/0nLcujLN4RNO4CQVguTR4oRM98= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ni2H4isCo0SlaQAXQAOQIyyFLNE2DUNHsfTL8j5gkmY=; b=pqSccpREtAd7uBUQLd09+WkPHs4RXlvRP1z6hZrezJQtz0u60TA8VYHdIZccu85DBA DKuJWJSD2RZhPkYzjNzZpj7uSs9TMtOfgKrjEx5Cc1g2mZvv44z94tN6B6UoxRbjVzAT yeCyZctg1PE6wTy+Gw86UUG4Qj8YT1mStlSPHu+5aXRjW1mV9jFUN03R/stVcuDQUVgX I//RJUjs55wBJtYyfN5ClZ91fYNeBV2vjB0sQ7yIB/YYwjWywG3nu6fY++XX4lYrE4mX 1u/3Q/RpQSDg/wexodwWtgFmdOwoXfUiLLs+X4uJshWRcFjYQ3HDr2yjQhX7rmn28CFc aZlQ== X-Gm-Message-State: APjAAAWdtw1GR3bWWp2QoHgyRtrmVKK3voPNhHAndQyQ9tXQrKDrLleu FVBsRnw92IoHpchj5kq2YptrrGkBjHo= X-Google-Smtp-Source: APXvYqymk57pNTp9Upgfn2em9cGgzJP0ay8kdmSoyymZSeOyOHmZVJLlxypwkC6UomzaMnwHiQOD1A== X-Received: by 2002:adf:fe41:: with SMTP id m1mr53416876wrs.220.1555425229192; Tue, 16 Apr 2019 07:33:49 -0700 (PDT) Received: from [192.168.51.243] ([93.152.141.58]) by smtp.gmail.com with ESMTPSA id c20sm94048625wre.28.2019.04.16.07.33.48 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 16 Apr 2019 07:33:48 -0700 (PDT) Subject: Re: iproute2 broken vlan stats output To: Roopa Prabhu Cc: Stephen Hemminger , network dev , David Ahern References: From: Nikolay Aleksandrov Message-ID: <2da90287-6526-5523-9e58-7f00a9dd1781@cumulusnetworks.com> Date: Tue, 16 Apr 2019 17:33:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 16/04/2019 17:28, Roopa Prabhu wrote: > On Tue, Apr 16, 2019 at 5:38 AM Nikolay Aleksandrov > wrote: >> >> Hi Stephen, >> It seems standard (non-json) vlan stats output has been broken since commit: >> 0f36267485e3 ("bridge: fix vlan show formatting") >> >> bridge -s vlan show output before commit 0f36267485e3: >> port vlan id >> br0 1 PVID untagged >> RX: 0 bytes 0 packets >> TX: 0 bytes 0 packets >> eth4 1 PVID untagged >> RX: 0 bytes 0 packets >> TX: 0 bytes 0 packets >> >> bridge -s vlan show output after commit 0f36267485e3: >> root@debian~/# bridge -s vlan >> port vlan id >> br0br0 1 PVID Egress Untagged >> RX: 0 bytes 0 packets >> TX: 0 bytes 0 packetseth4eth4 1 PVID Egress Untagged >> RX: 0 bytes 0 packets >> TX: 0 bytes 0 packetsroot@debian:~/# >> > > :(. Looks like iproute2 should have selftests too. Its hard to catch > these in code review. > I made a mistake about the commit, the actual culprits are: 45fca4ed9412 ("bridge: fix vlan show stats formatting") c7c1a1ef51ae ("bridge: colorize output and use JSON print library") They both broke a different thing about standard stats output: - 45fca4ed9412 ("bridge: fix vlan show stats formatting") Added a second print of an interface name (e.g. eth4eth4) - c7c1a1ef51ae ("bridge: colorize output and use JSON print library") Broke normal vlan stats output by not printing a new line after them I'll post a fix in a minute.