From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 1/3] drm/ttm: fix ttm_bo_bulk_move_helper Date: Sat, 8 Sep 2018 12:43:55 +0200 Message-ID: <2db0c2ed-79e4-08c9-29a7-751fc69762d0@amd.com> References: <20180831131019.2486-1-christian.koenig@amd.com> <20180906100244.GA27674@hr-amur2> <3be7e67a-2ffe-21c0-2160-69a330413858@amd.com> <24dbe7c4-63df-b8a7-28c3-df0e9866841f@gmail.com> <20180908075412.GA12334@hr-amur2> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180908075412.GA12334@hr-amur2> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Huang Rui Cc: =?UTF-8?B?TWljaGVsIETvv71uemVy?= , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" QW0gMDguMDkuMjAxOCB1bSAwOTo1NCBzY2hyaWViIEh1YW5nIFJ1aToKPiBPbiBGcmksIFNlcCAw NywgMjAxOCBhdCAwNzoxODo1OVBNICswODAwLCBDaHJpc3RpYW4gS++/vW5pZyB3cm90ZToKPj4g QW0gMDcuMDkuMjAxOCB1bSAxMzowMiBzY2hyaWViIEh1YW5nLCBSYXk6Cj4+Cj4+ICAgICAgICAg ICAgICAgWWVzLCB0aGF0IHdhcyBvbmUgcHJvYmxlbS4gQW5vdGhlciB3YXMgdGhhdCB0aGUgY3V0 dGluZyBjb2RlIHdhcyBidWdneQo+PiAgICAgICAgICAgICAgICBhbmQgZGV0ZXJtaW5lZCBvbmUg b2YgdGhlIHBvc2l0aW9ucyB0byBjdXQgYXQgdGhlIHdyb25nIHRpbWUuCj4+Cj4+ICAgICAgSSB3 ZW50IHRocm91Z2ggYWdhaW4gYWJvdXQgdGhlIGxpc3QgY3V0dGluZyBiZWhhdmlvciBhbmQgd3Jv dGUgZG93biB3aXRoIHRoZSBhdHRhY2hlZCBwaWN0dXJlLgo+PiAgICAgIEFmdGVyIGRvIHRoZSBz ZWNvbmQgbGlzdF9jdXRfcG9zaXRpb24sIHRoZSBsaXN0MiBzaG91bGQgYmUgcG9pbnQgdGhlIGVu ZCBvZiAiYmVmb3JlIiBsaXN0LiBBbmQgbGlzdDIgd29uJ3QgYmUgdXNlZCBhbnltb3JlIGFmdGVy IGxpc3QgY3V0dGluZy4gTWF5IEkga25vdyBhbSBJIHNvbWV0aGluZyBtaXNzZWQ/Cj4+Cj4+Cj4+ IExldCdzIHRha2UgYSBsb29rIGF0IHRoZSBvcmlnaW5hbCBjb2RlOgo+Pgo+PiAgICAgIGxpc3Qx ID0gaXNfc3dhcCA/ICZwb3MtPmxhc3QtPnN3YXAgOiAmcG9zLT5sYXN0LT5scnU7Cj4+ICAgICAg bGlzdDIgPSBpc19zd2FwID8gcG9zLT5maXJzdC0+c3dhcC5wcmV2IDogcG9zLT5maXJzdC0+bHJ1 LnByZXY7Cj4+ICAgICAgIAo+PiAgICAgIGxpc3RfY3V0X3Bvc2l0aW9uKCZlbnRyaWVzLCBscnUs IGxpc3QxKTsKPj4gICAgICBsaXN0X2N1dF9wb3NpdGlvbigmYmVmb3JlLCAmZW50cmllcywgbGlz dDIpOwo+Pgo+Pgo+PiBBcyBmYXIgYXMgSSBjYW4gc2VlIHRoZSBwcm9ibGVtIGlzIHRoYXQgdGhl IGZpcnN0IGxpc3RfY3VyX3Bvc2l0aW9uIGNvdWxkCj4+IG1vZGlmeSB0aGUgdmFsdWUgb2YgcG9z LT5maXJzdC0+bHJ1LnByZXYgYW5kIHNvIG1ha2UgdGhlIHNlY29uZAo+PiBsaXN0X2N1dF9wb3Np dGlvbiB3b3JrIG9uIHRoZSB3cm9uZyBwb3NpdGlvbi4KPj4KPiBJIHRoaW5rIEkgdW5kZXJzdG9v ZC4gSW4gdGhpcyBjYXNlICh0aGUgZmlyc3QgZWxlbWVudCBvZiBMUlUgPT0KPiBwb3MtPmZpcnN0 LT5scnUpLCBwbGVhc2Ugc2VlIHRoZSBwaWN0dXJlLiBJZiB3ZSBzdG9yZSBmaXJzdC0+bHJ1LnBy ZXYgYXMKPiBsaXN0MihMUlUgaGVhZCksIGFmdGVyIGRvIGxpc3QgY3V0dGluZywgdGhlIGZpcnN0 LT5scnUucHJldiB3aWxsIG92ZXJ3cml0ZQo+IGFzIG5ldyBoZWFkIChlbnRyaWVzKSwgaG93ZXZl ciwgdGhlIG9yaWduYWwgbGlzdDIgd2lsbCBzdGlsbCBwb2ludCBwcmV2aW91cwo+IGhlYWQgKHRo YXQgaXMgdGhlIHdyb25nIHBvc2l0aW9uIG5vdykuIFdlIGFjdHVhbGx5IGV4cGVjdGVkIHRvIHVz ZSB0aGUKPiBsYXRlc3QgZmlyc3QtPmxydS5wcmV2IGFzIHRoZSBzZWNvbmQgY3V0dGluZyBwb3Np dGlvbi4gU28gd2Ugc2hvdWxkIGFkanVzdAo+IGNvZGUgc2VxdWVuY2UgbGlrZSBiZWxvdzoKPgo+ IGxpc3QxID0gaXNfc3dhcCA/ICZwb3MtPmxhc3QtPnN3YXAgOiAmcG9zLT5sYXN0LT5scnU7Cj4g bGlzdF9jdXRfcG9zaXRpb24oJmVudHJpZXMsIGxydSwgbGlzdDEpOwo+Cj4gbGlzdDIgPSBpc19z d2FwID8gcG9zLT5maXJzdC0+c3dhcC5wcmV2IDogcG9zLT5maXJzdC0+bHJ1LnByZXY7Cj4gbGlz dF9jdXRfcG9zaXRpb24oJmJlZm9yZSwgJmVudHJpZXMsIGxpc3QyKTsKPgo+IEFtIEkgdW5kZXJz dGFuZGluZyByaWdodD8KClllcywgZXhhY3RseS4gQW5kIHRoZSBmaXggbG9va3MgbGlrZSB3aGF0 IEkgZGlkIGFzIHdlbGwuIEp1c3Qgb25seSB1c2VkIApvbmUgdmFyaWFibGUgYW5kIGFkZGVkIHNv bWUgZXh0cmEgQlVHX09OKCkuCgpDaHJpc3RpYW4uCgo+Cj4gVGhhbmtzLAo+IFJheQo+Cj4+IFJl Z2FyZHMsCj4+IENocmlzdGlhbi4KPj4KPj4KPj4KPj4gICAgICBUaGFua3MsCj4+ICAgICAgUmF5 Cj4+Cj4+ICAgICAgRnJvbTogYW1kLWdmeCA8YW1kLWdmeC1ib3VuY2VzQGxpc3RzLmZyZWVkZXNr dG9wLm9yZz4gb24gYmVoYWxmIG9mIENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdA YW1kLmNvbT4KPj4gICAgICBTZW50OiBUaHVyc2RheSwgU2VwdGVtYmVyIDYsIDIwMTggNjowNiBQ TQo+PiAgICAgIFRvOiBIdWFuZywgUmF5Cj4+ICAgICAgQ2M6IE1pY2hlbCBEw6RuemVyOyBhbWQt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiAgICAgIFN1YmplY3Q6IFJlOiBbUEFUQ0ggMS8z XSBkcm0vdHRtOiBmaXggdHRtX2JvX2J1bGtfbW92ZV9oZWxwZXIKPj4gICAgICAgCj4+Cj4+ICAg ICAgQW0gMDYuMDkuMjAxOCB1bSAxMjowMiBzY2hyaWViIEh1YW5nIFJ1aToKPj4KPj4gICAgICAg ICAgT24gRnJpLCBBdWcgMzEsIDIwMTggYXQgMDU6MTc6MzNQTSArMDIwMCwgQ2hyaXN0aWFuIEvD tm5pZyB3cm90ZToKPj4KPj4gICAgICAgICAgICAgIEFtIDMxLjA4LjIwMTggdW0gMTc6MTUgc2No cmllYiBNaWNoZWwgRMOkbnplcjoKPj4KPj4gICAgICAgICAgICAgICAgICBPbiAyMDE4LTA4LTMx IDM6MTAgcC5tLiwgQ2hyaXN0aWFuIEvDtm5pZyB3cm90ZToKPj4KPj4gICAgICAgICAgICAgICAg ICAgICAgU3RhcmluZyBhdCB0aGUgZnVuY3Rpb24gZm9yIHNpeCBob3VycywganVzdCB0byBlc3Nl bnRpYWxseSBtb3ZlIG9uZSBsaW5lCj4+ICAgICAgICAgICAgICAgICAgICAgIG9mIGNvZGUuCj4+ Cj4+ICAgICAgICAgICAgICAgICAgVGhhdCBzdWNrcywgYnV0IHRoZSBjb21taXQgbG9nIHNob3Vs ZCBkZXNjcmliZSB3aGF0IHRoZSBwcm9ibGVtIHdhcyBhbmQKPj4gICAgICAgICAgICAgICAgICBo b3cgdGhpcyBwYXRjaCBzb2x2ZXMgaXQuCj4+Cj4+Cj4+Cj4+ICAgICAgICAgICAgICAgICAgICAg IFNpZ25lZC1vZmYtYnk6IENocmlzdGlhbiBLw7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNv bT4KPj4gICAgICAgICAgICAgICAgICAgICAgLS0tCj4+ICAgICAgICAgICAgICAgICAgICAgICAg IGRyaXZlcnMvZ3B1L2RybS90dG0vdHRtX2JvLmMgfCAxMyArKysrKysrKy0tLS0tCj4+ICAgICAg ICAgICAgICAgICAgICAgICAgIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDUgZGVs ZXRpb25zKC0pCj4+Cj4+ICAgICAgICAgICAgICAgICAgICAgIGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vdHRtL3R0bV9iby5jIGIvZHJpdmVycy9ncHUvZHJtL3R0bS90dG1fYm8uYwo+PiAg ICAgICAgICAgICAgICAgICAgICBpbmRleCAzNWQ1M2Q4MWY0ODYuLjEzOGM5ODkwMjAzMyAxMDA2 NDQKPj4gICAgICAgICAgICAgICAgICAgICAgLS0tIGEvZHJpdmVycy9ncHUvZHJtL3R0bS90dG1f Ym8uYwo+PiAgICAgICAgICAgICAgICAgICAgICArKysgYi9kcml2ZXJzL2dwdS9kcm0vdHRtL3R0 bV9iby5jCj4+ICAgICAgICAgICAgICAgICAgICAgIEBAIC0yNTAsMTUgKzI1MCwxOCBAQCBFWFBP UlRfU1lNQk9MKHR0bV9ib19tb3ZlX3RvX2xydV90YWlsKTsKPj4gICAgICAgICAgICAgICAgICAg ICAgICAgc3RhdGljIHZvaWQgdHRtX2JvX2J1bGtfbW92ZV9oZWxwZXIoc3RydWN0IHR0bV9scnVf YnVsa19tb3ZlX3BvcyAqcG9zLAo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBzdHJ1Y3QgbGlzdF9oZWFkICpscnUsIGJvb2wgaXNfc3dhcCkK Pj4gICAgICAgICAgICAgICAgICAgICAgICAgewo+PiAgICAgICAgICAgICAgICAgICAgICArICBz dHJ1Y3QgbGlzdF9oZWFkICpsaXN0Owo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgIExJU1Rf SEVBRChlbnRyaWVzKTsKPj4gICAgICAgICAgICAgICAgICAgICAgICAgICBMSVNUX0hFQUQoYmVm b3JlKTsKPj4gICAgICAgICAgICAgICAgICAgICAgLSAgc3RydWN0IGxpc3RfaGVhZCAqbGlzdDEs ICpsaXN0MjsKPj4gICAgICAgICAgICAgICAgICAgICAgLSAgbGlzdDEgPSBpc19zd2FwID8gJnBv cy0+bGFzdC0+c3dhcCA6ICZwb3MtPmxhc3QtPmxydTsKPj4gICAgICAgICAgICAgICAgICAgICAg LSAgbGlzdDIgPSBpc19zd2FwID8gcG9zLT5maXJzdC0+c3dhcC5wcmV2IDogcG9zLT5maXJzdC0+ bHJ1LnByZXY7Cj4+ICAgICAgICAgICAgICAgICAgICAgICsgIHJlc2VydmF0aW9uX29iamVjdF9h c3NlcnRfaGVsZChwb3MtPmxhc3QtPnJlc3YpOwo+PiAgICAgICAgICAgICAgICAgICAgICArICBs aXN0ID0gaXNfc3dhcCA/ICZwb3MtPmxhc3QtPnN3YXAgOiAmcG9zLT5sYXN0LT5scnU7Cj4+ICAg ICAgICAgICAgICAgICAgICAgICsgIGxpc3RfY3V0X3Bvc2l0aW9uKCZlbnRyaWVzLCBscnUsIGxp c3QpOwo+PiAgICAgICAgICAgICAgICAgICAgICArCj4+ICAgICAgICAgICAgICAgICAgICAgICsg IHJlc2VydmF0aW9uX29iamVjdF9hc3NlcnRfaGVsZChwb3MtPmZpcnN0LT5yZXN2KTsKPj4gICAg ICAgICAgICAgICAgICAgICAgKyAgbGlzdCA9IGlzX3N3YXAgPyBwb3MtPmZpcnN0LT5zd2FwLnBy ZXYgOiBwb3MtPmZpcnN0LT5scnUucHJldjsKPj4gICAgICAgICAgICAgICAgICAgICAgKyAgbGlz dF9jdXRfcG9zaXRpb24oJmJlZm9yZSwgJmVudHJpZXMsIGxpc3QpOwo+Pgo+PiAgICAgICAgICAg ICAgICAgIFNvIHRoZSBwcm9ibGVtIHdhcyB0aGF0IHRoZSBmaXJzdCBsaXN0X2N1dF9wb3NpdGlv biBjYWxsIGNvdWxkIHJlc3VsdCBpbgo+PiAgICAgICAgICAgICAgICAgIGxpc3QyIHBvaW50aW5n IHRvIGxhLWxhLWxhbmQ/IEdvb2QgY2F0Y2ghCj4+Cj4+ICAgICAgICAgICAgICBZZXMsIGV4YWN0 bHkuIFRob3VnaHQgdGhhdCB3b3VsZCBiZSBvYnZpb3VzLCBidXQgZ29pbmcgdG8gYWRkIHRoYXQK Pj4gICAgICAgICAgICAgIHRvIHRoZSBjb21taXQgbG9nLgo+Pgo+PiAgICAgICAgICAgICAgQ2Fu IEkgZ2V0IGEgdGVzdGVkLWJ5PyBZb3Ugd2hlcmUgbXVjaCBiZXR0ZXIgYXQgcmVwcm9kdWNpbmcg dGhhdCB0aGFuIEknbS4KPj4KPj4KPj4gICAgICAgICAgTWljaGVsLCBDaHJpc3RpYW4sIHRoYW5r cyBzbyBtdWNoIHRvIHRha2UgY2FyZSBvZiB0aGlzIHdoZW4gSSB3YXMgb24KPj4gICAgICAgICAg dmFjYXRpb24uIEFuZCBzb3JyeSB0byBsZXQgeW91IHRha2UgYSBsb25nIHRpbWUgZm9yIGZpbmRp bmcgdGhlIGNhdXNlLgo+Pgo+PiAgICAgICAgICBJcyB0aGF0IGJlY2F1c2UgSSBkaWRuJ3QgaG9s ZCB0aGUgcmVzdmVyYXRpb24gYmVmb3JlIGN1dCB0aGUgbGlzdCBmcm9tCj4+ICAgICAgICAgIHBv c2l0aW9uICJmaXJzdCIgYW5kICJsYXN0Ij8KPj4KPj4gICAgICBZZXMsIHRoYXQgd2FzIG9uZSBw cm9ibGVtLiBBbm90aGVyIHdhcyB0aGF0IHRoZSBjdXR0aW5nIGNvZGUgd2FzIGJ1Z2d5Cj4+ICAg ICAgYW5kIGRldGVybWluZWQgb25lIG9mIHRoZSBwb3NpdGlvbnMgdG8gY3V0IGF0IHRoZSB3cm9u ZyB0aW1lLgo+Pgo+Pgo+PiAgICAgICAgICAgICBNYXkgSSBrbm93IGluIHdoaWNoIGNhc2VzLCB3 ZSBtdXN0IGhvbGQgdGhlCj4+ICAgICAgICAgIGJvJ3MgcmVzZXJ2YXRpb24gZmlyc3RseT8KPj4K Pj4gICAgICBCT3MgYXJlIHJlc2VydmVkIHRvIHByZXZlbnQgbW92aW5nIHRoZW0uIEUuZy4gd2hl biB0aGUgQk8gaXNuJ3QgcmVzZXJ2ZWQKPj4gICAgICBpdCBjYW4gbW92ZSBhcm91bmQgYW5kIHNv IHRoZSBMUlUgd2hlcmUgeW91IHdhbnQgdG8gYWRkL3JlbW92ZSBpdCBjb3VsZAo+PiAgICAgIGNo YW5nZS4KPj4KPj4gICAgICBDaHJpc3RpYW4uCj4+Cj4+Cj4+ICAgICAgICAgIFRoYW5rcywKPj4g ICAgICAgICAgUmF5Cj4+Cj4+Cj4+Cj4+ICAgICAgX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KPj4gICAgICBhbWQtZ2Z4IG1haWxpbmcgbGlzdAo+PiAgICAg IGFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+ICAgICAgaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cj4+Cj4+Cj4+ICAgICAgYW1kLWdm eCBJbmZvIFBhZ2UgLSBmcmVlZGVza3RvcC5vcmcKPj4gICAgICBsaXN0cy5mcmVlZGVza3RvcC5v cmcKPj4gICAgICBUbyBzZWUgdGhlIGNvbGxlY3Rpb24gb2YgcHJpb3IgcG9zdGluZ3MgdG8gdGhl IGxpc3QsIHZpc2l0IHRoZSBhbWQtZ2Z4IEFyY2hpdmVzLi4gVXNpbmcgYW1kLWdmeDogVG8gcG9z dCBhIG1lc3NhZ2UgdG8gYWxsIHRoZSBsaXN0IG1lbWJlcnMsIHNlbmQgZW1haWwgdG8gYW1kLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcuIFlvdSBjYW4gc3Vic2NyaWJlIHRvIHRoZSBsaXN0LCBv ciBjaGFuZ2UgeW91ciBleGlzdGluZyBzdWJzY3JpcHRpb24sIGluIHRoZSBzZWN0aW9ucyBiZWxv dy4KPj4KPj4KPj4KPj4KPj4gICAgIAo+PiAgICAgIF9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCj4+ICAgICAgYW1kLWdmeCBtYWlsaW5nIGxpc3QKPj4gICAg ICBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+PiAgICAgIGh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeAo+Pgo+PgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QK YW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==