From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Peter Xu <peterx@redhat.com>, qemu-devel@nongnu.org
Cc: Jason Wang <jasowang@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH] intel_iommu: Fix two misuse of "0x%u" prints
Date: Mon, 19 Oct 2020 21:50:14 +0200 [thread overview]
Message-ID: <2dc1f79a-da6a-3d66-5b34-a462adcb0a7d@redhat.com> (raw)
In-Reply-To: <20201019173922.100270-1-peterx@redhat.com>
On 10/19/20 7:39 PM, Peter Xu wrote:
> Dave magically found this. Fix them with "0x%x".
>
> Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> hw/i386/intel_iommu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index 749eb6ad63..70ac837733 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -2665,7 +2665,7 @@ static uint64_t vtd_mem_read(void *opaque, hwaddr addr, unsigned size)
>
> if (addr + size > DMAR_REG_SIZE) {
> error_report_once("%s: MMIO over range: addr=0x%" PRIx64
> - " size=0x%u", __func__, addr, size);
> + " size=0x%x", __func__, addr, size);
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
next prev parent reply other threads:[~2020-10-19 19:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 17:39 [PATCH] intel_iommu: Fix two misuse of "0x%u" prints Peter Xu
2020-10-19 18:33 ` Dr. David Alan Gilbert
2020-10-19 19:00 ` Peter Maydell
2020-10-19 19:12 ` Dr. David Alan Gilbert
2020-10-19 19:50 ` Philippe Mathieu-Daudé [this message]
2020-10-20 5:38 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dc1f79a-da6a-3d66-5b34-a462adcb0a7d@redhat.com \
--to=philmd@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.